Files
Elydora-Python-SDK/tests/test_transaction_lock.py
ZacharyZhang-NY e37418c489 feat(python): durable transaction subsystem and Kiro IDE 1.0 adapter
Land the crash-recoverable managed-file transaction engine (journal,
staging, commit, restart recovery, opaque snapshots, private artifacts,
Windows DACL hardening) and the Kiro IDE 1.0 workspace hook plugin with
legacy migration.

Repair five defects that kept the suite red (426 failures to zero):

- Anchor the transaction state directory at ~/.elydora/transactions
  instead of the shared system temp directory. The recovery journal now
  shares fate with the runtimes it repairs, survives temp cleaners, and
  isolates naturally under per-test fake homes.
- Skip pending-transaction recovery when no state directory exists so
  rejected installs never create runtime directories.
- Create the runtime root's parent before hardening it, matching the Go
  SDK's expand behavior for fresh homes.
- Stop using file timestamps as identity evidence: Windows exposes
  mtime/ctime with delayed cross-handle visibility. Reads now prove
  stability through a verification re-read; snapshots compare device,
  inode, size, and SHA-256.
- Stop comparing synthetic Windows permission bits across stat
  boundaries: path stats derive execute bits from file extensions while
  handle stats do not, which falsely flagged every managed .cmd wrapper.
  Snapshots store raw modes for restoration and compare portable bits.

Reservation cleanup now verifies content before discarding so a
concurrent writer's file at a rollback path is preserved, and the
install-failure tests assert the precise contract: no agent runtime
residue, with the durable state directory allowed to remain.

Gates: pytest 807 passed, mypy clean, pip check clean, wheel builds.
2026-07-21 18:53:06 -04:00

170 lines
5.3 KiB
Python

from __future__ import annotations
import os
from pathlib import Path
import stat
import subprocess # nosec B404
import sys
import time
import pytest
from elydora.plugins import _transaction_lock
if os.name == "nt":
from elydora.plugins._windows_security import verify_private_path
def _use_isolated_state(
monkeypatch: pytest.MonkeyPatch,
root: Path,
) -> None:
monkeypatch.setenv("HOME", str(root))
monkeypatch.setenv("USERPROFILE", str(root))
def test_transaction_state_directory_has_owner_boundary(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
_use_isolated_state(monkeypatch, tmp_path)
state = Path(_transaction_lock.transaction_state_directory())
assert state.is_dir()
if os.name == "nt":
verify_private_path(str(state), directory=True)
else:
metadata = state.stat()
assert metadata.st_uid == getattr(os, "geteuid")()
assert stat.S_IMODE(metadata.st_mode) == 0o700
@pytest.mark.skipif(os.name != "posix", reason="POSIX owner contract")
def test_transaction_state_directory_rejects_foreign_owner(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
_use_isolated_state(monkeypatch, tmp_path)
state = Path(_transaction_lock.transaction_state_directory())
owner = state.stat().st_uid
monkeypatch.setattr(os, "geteuid", lambda: owner + 1)
with pytest.raises(PermissionError, match="owned by the current user"):
_transaction_lock.transaction_state_directory()
@pytest.mark.skipif(os.name != "posix", reason="POSIX owner contract")
def test_posix_lock_rejects_foreign_owner(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
lock_path = tmp_path / "transaction.lock"
lock_path.write_bytes(b"")
owner = lock_path.stat().st_uid
monkeypatch.setattr(
_transaction_lock,
"transaction_state_directory",
lambda: str(tmp_path),
)
monkeypatch.setattr(os, "geteuid", lambda: owner + 1)
with pytest.raises(PermissionError, match="owned by the current user"):
_transaction_lock._PosixLock().__enter__()
def test_transaction_lock_rejects_reparse_path(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
_use_isolated_state(monkeypatch, tmp_path)
state = Path(_transaction_lock.transaction_state_directory())
target = tmp_path / "target.lock"
target.write_bytes(b"")
lock_path = state / "transaction.lock"
try:
lock_path.symlink_to(target)
except OSError as error:
pytest.skip(f"Symbolic links unavailable: {error}")
with pytest.raises(OSError, match="physical file"):
with _transaction_lock.serialized_transactions():
pass
@pytest.mark.skipif(os.name != "nt", reason="Windows DACL contract")
def test_windows_lock_file_has_owner_only_protected_dacl(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
_use_isolated_state(monkeypatch, tmp_path)
state = Path(_transaction_lock.transaction_state_directory())
with _transaction_lock.serialized_transactions():
lock_path = state / "transaction.lock"
assert lock_path.is_file()
verify_private_path(str(lock_path), directory=False)
def test_transaction_lock_serializes_independent_processes(tmp_path: Path) -> None:
state_root = tmp_path / "state-root"
state_root.mkdir()
entered = tmp_path / "entered"
release = tmp_path / "release"
second_entered = tmp_path / "second-entered"
script = """
import pathlib
import sys
import time
from elydora.plugins._transaction_lock import serialized_transactions
entered, release = map(pathlib.Path, sys.argv[1:3])
with serialized_transactions():
entered.write_text("entered", encoding="utf-8")
if len(sys.argv) == 4:
deadline = time.monotonic() + 10
while not release.exists():
if time.monotonic() >= deadline:
raise TimeoutError("release gate timed out")
time.sleep(0.01)
"""
environment = os.environ.copy()
environment["HOME"] = str(state_root)
environment["USERPROFILE"] = str(state_root)
repository = Path(__file__).resolve().parents[1]
first = subprocess.Popen( # nosec B603
[sys.executable, "-c", script, str(entered), str(release), "wait"],
cwd=repository,
env=environment,
)
second: subprocess.Popen[bytes] | None = None
try:
deadline = time.monotonic() + 10
while not entered.exists() and first.poll() is None:
if time.monotonic() >= deadline:
raise TimeoutError("first process did not acquire the lock")
time.sleep(0.01)
assert first.poll() is None
second = subprocess.Popen( # nosec B603
[sys.executable, "-c", script, str(second_entered), str(release)],
cwd=repository,
env=environment,
)
time.sleep(0.25)
assert second.poll() is None
assert not second_entered.exists()
release.write_text("release", encoding="utf-8")
assert first.wait(timeout=10) == 0
assert second.wait(timeout=10) == 0
assert second_entered.read_text(encoding="utf-8") == "entered"
finally:
if first.poll() is None:
first.kill()
first.wait()
if second is not None and second.poll() is None:
second.kill()
second.wait()