Harden the seams a project sweep surfaced

A systematic review of the whole codebase (main process, renderer,
IPC/migration/packaging seams) surfaced four real defects; each is
fixed at its root:

- Legacy catalogue drift: the operator's profile still carried 89
  active skills from the removed ~/.agents import era next to the 228
  built-ins. Catalogue sync now mirrors the bundle - actives whose slug
  the bundle does not ship retire (bindings keep resolving via their
  pinned revisions; retired skills leave list_skills and cannot be
  granted anew)
- Broken-bundle guard: staging now refuses a bundle without the
  humanizer skill, so an empty or quarantined resources folder can
  never trigger the mirror pass into retiring a healthy catalogue
- Duplicate agent names: @mentions, DM routing, and task assignment all
  resolve by name, so createAgent and updateAgent renames now reject a
  name already held by an active agent (case-insensitive); the mention
  resolver still refuses to guess between legacy duplicates
- Stale DM titles: agent-to-agent conversation rows titled themselves
  from the frozen creation-time space name, so renames never reached
  the sidebar; direct titles now derive from members' current names

Verified clean in the same sweep: IPC surface (82 channels, handler +
preload + api aligned), per-migration transactions with rollback,
quota-parking month rollover, retry-budget counting, meeting spot
reuse across floor-plan rebuilds.
This commit is contained in:
ZacharyZhang-NY committed 2026-07-08 23:41:51 -04:00
1 parent c50f17190c
commit 04093c4869
8 files changed
+156 -12

No files matched your search

+17 -2
View File
@@ -29,6 +29,8 @@ export interface StagedBuiltinSkill {
export interface BuiltinSkillSyncReport {
imported: number;
skipped: number;
/** Active skills retired because the bundle no longer carries their slug. */
retired: number;
failures: string[];
}
@@ -57,12 +59,24 @@ export function stageBuiltinSkillsLibrary(sourceRoot: string, libraryRoot: strin
}
staged.push(...stageCategorySkills(sourceDir, libraryRoot, seen));
}
// A bundle without the forced house-style skill is a broken install, not a
// small catalogue. Failing here keeps the import (and the mirror-retire
// pass) from wiping a healthy org catalogue against an empty directory.
if (!seen.has("humanizer")) {
throw new Error(`Built-in skills bundle at ${sourceRoot} is missing the humanizer skill - refusing to sync a broken bundle.`);
}
return staged;
}
/** Publishes every staged skill the org does not already carry. */
/**
* Makes the org catalogue mirror the bundle: publishes every staged skill
* the org does not carry yet, then retires active skills whose slug the
* bundle no longer ships (legacy ~/.agents imports, removed skills).
* Existing bindings pin revisions directly and keep working; retired skills
* simply leave list_skills and stop being grantable.
*/
export function importStagedSkills(skills: SkillService, orgId: string, staged: StagedBuiltinSkill[]): BuiltinSkillSyncReport {
const report: BuiltinSkillSyncReport = { imported: 0, skipped: 0, failures: [] };
const report: BuiltinSkillSyncReport = { imported: 0, skipped: 0, retired: 0, failures: [] };
for (const unit of staged) {
try {
if (skills.hasSkill(orgId, unit.slug)) {
@@ -75,6 +89,7 @@ export function importStagedSkills(skills: SkillService, orgId: string, staged:
report.failures.push(`${unit.slug}: ${error instanceof Error ? error.message : String(error)}`);
}
}
report.retired = skills.retireSkillsNotIn(orgId, staged.map((unit) => unit.slug)).length;
return report;
}