Remove final AppDatabase pass-through methods with ESLint guard (C1 part 3/3)
Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:
- createHireRequest (multi-module composite: agents + approvalsMod)
- rollbackConfigRevision (multi-module composite: documents + entityCrud)
- queryAll (raw-SQL escape hatch, @internal)
The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.
Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.
A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
This commit is contained in:
1 parent
a69fbb053b
commit
118e3d8795
120 files changed
+838
-933
No files matched your search
@@ -7,6 +7,22 @@ interface ConnectorModelPolicyDeps {
|
||||
getDisabledModels: (companyId: string, connectorId: string) => Array<{ id: string; label: string }>;
|
||||
}
|
||||
|
||||
/**
|
||||
* Adapter over AppDatabase that returns the structural shape consumed by
|
||||
* `getConnectorModelPolicy` / `validateConnectorModelSelection`. Callers
|
||||
* pass an `AppDatabase`-ish object; the helper unwraps the two typed
|
||||
* domain modules so we do not repeat the closure literal at every site.
|
||||
*/
|
||||
export function connectorPolicyDepsFromDb(db: {
|
||||
connectorsCrud: { getConnector: (id: ConnectorId) => { id: ConnectorId; label?: string | null; model: string | null } };
|
||||
settings: { getDisabledModels: (companyId: string, connectorId: string) => Array<{ id: string; label: string }> };
|
||||
}): ConnectorModelPolicyDeps {
|
||||
return {
|
||||
getConnector: (id) => db.connectorsCrud.getConnector(id),
|
||||
getDisabledModels: (cid, connId) => db.settings.getDisabledModels(cid, connId),
|
||||
};
|
||||
}
|
||||
|
||||
export interface ConnectorModelPolicyResult {
|
||||
connectorId: ConnectorId;
|
||||
connectorLabel: string;
|
||||
|
||||
Reference in new issue
Block a user