Remove final AppDatabase pass-through methods with ESLint guard (C1 part 3/3)

Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:

  - createHireRequest (multi-module composite: agents + approvalsMod)
  - rollbackConfigRevision (multi-module composite: documents + entityCrud)
  - queryAll (raw-SQL escape hatch, @internal)

The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.

Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.

A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-20 13:31:39 -04:00
1 parent a69fbb053b
commit 118e3d8795
120 files changed
+838 -933

No files matched your search

@@ -68,9 +68,9 @@ export function finalizeRun(
leaseRenewalMap.delete(event.runId);
const runOutcome = db.runs.finishRun(event);
if (run.workspaceId) {
db.releaseWorkspaceLock(run.workspaceId, run.id);
db.workspacesMod.releaseWorkspaceLock(run.workspaceId, run.id);
}
db.addActivity({
db.activityMod.addActivity({
companyId: run.companyId,
actor: run.agentId,
action: `run.${event.status}`,
@@ -165,7 +165,7 @@ export function emitAndNotifyCompletion(
}
if (updatedAgent && runOutcome.budgetHardStopped) {
db.addActivity({
db.activityMod.addActivity({
companyId: updatedAgent.companyId,
actor: "system",
action: "agent.auto_paused",
@@ -229,8 +229,8 @@ export function runPostCompletionAutomation(
// EXEC-05: Promote deferred wakes after run completion
let hadDeferredWakes = false;
if (!isQuitting() && !destroyed) {
const promoted = db.promoteWakeupRequests(run.agentId, run.companyId);
const pendingWakeTrigger = db.getPreferredWakeTrigger(run.agentId, run.companyId);
const promoted = db.wakeup.promoteWakeupRequests(run.agentId, run.companyId);
const pendingWakeTrigger = db.wakeup.getPreferredWakeTrigger(run.agentId, run.companyId);
if (promoted > 0) {
logger.info(`[worker] Promoted ${promoted} deferred wake(s) for agent ${run.agentId}`);
}
@@ -348,7 +348,7 @@ function hasUnfinishedTeamBuilding(
.getDirectReports(agentId, companyId)
.filter((r) => r.status !== "pending_approval" && r.status !== "terminated");
if (activeReports.length > 0) return false;
const goalCount = db.countActiveGoalsForCompany(companyId);
const goalCount = db.entityCrud.countActiveGoalsForCompany(companyId);
if (goalCount === 0) return false;
const pendingHires = db.approvalsMod
.listCompanyApprovalsByType(companyId, "hire_agent")