Remove final AppDatabase pass-through methods with ESLint guard (C1 part 3/3)

Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:

  - createHireRequest (multi-module composite: agents + approvalsMod)
  - rollbackConfigRevision (multi-module composite: documents + entityCrud)
  - queryAll (raw-SQL escape hatch, @internal)

The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.

Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.

A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-20 13:31:39 -04:00
1 parent a69fbb053b
commit 118e3d8795
120 files changed
+838 -933

No files matched your search

+11 -11
View File
@@ -27,7 +27,7 @@ function createTestCompany(db: AppDatabase): string {
}
function createTestConnector(db: AppDatabase): void {
db.saveConnector({
db.connectorsCrud.saveConnector({
id: "openai-codex",
model: "gpt-5",
envBindingText: "",
@@ -36,7 +36,7 @@ function createTestConnector(db: AppDatabase): void {
}
function createTestWorkspace(db: AppDatabase, companyId: string): string {
return db.saveWorkspace({
return db.workspacesMod.saveWorkspace({
companyId,
name: "Wakeup Workspace",
localPath: "/tmp/wakeup-workspace",
@@ -87,9 +87,9 @@ describe("wakeup lifecycle", () => {
const workspaceId = createTestWorkspace(db, companyId);
const agentId = createTestAgent(db, companyId, workspaceId);
db.enqueueWakeupRequest(companyId, agentId, "task.created", "New task assigned");
db.wakeup.enqueueWakeupRequest(companyId, agentId, "task.created", "New task assigned");
const wakes = db.listWakeupRequests(companyId);
const wakes = db.wakeup.listWakeupRequests(companyId);
expect(wakes.length).toBe(1);
expect(wakes[0].agentId).toBe(agentId);
expect(wakes[0].status).toBe("queued");
@@ -107,10 +107,10 @@ describe("wakeup lifecycle", () => {
const workspaceId = createTestWorkspace(db, companyId);
const agentId = createTestAgent(db, companyId, workspaceId);
db.enqueueWakeupRequest(companyId, agentId, "task.created", "First task");
db.enqueueWakeupRequest(companyId, agentId, "task.status_changed", "Second trigger");
db.wakeup.enqueueWakeupRequest(companyId, agentId, "task.created", "First task");
db.wakeup.enqueueWakeupRequest(companyId, agentId, "task.status_changed", "Second trigger");
const wakes = db.listWakeupRequests(companyId);
const wakes = db.wakeup.listWakeupRequests(companyId);
// D-07: Per-agent scope -- only one wakeup row should exist
expect(wakes.length).toBe(1);
expect(wakes[0].coalescedCount).toBe(1);
@@ -128,15 +128,15 @@ describe("wakeup lifecycle", () => {
const agent1Id = createTestAgent(db, companyId, workspaceId, "Agent1");
const agent2Id = createTestAgent(db, companyId, workspaceId, "Agent2");
db.enqueueWakeupRequest(companyId, agent1Id, "task.created", "Agent1 task");
db.enqueueWakeupRequest(companyId, agent2Id, "task.created", "Agent2 task");
db.wakeup.enqueueWakeupRequest(companyId, agent1Id, "task.created", "Agent1 task");
db.wakeup.enqueueWakeupRequest(companyId, agent2Id, "task.created", "Agent2 task");
// List all for company
const allWakes = db.listWakeupRequests(companyId);
const allWakes = db.wakeup.listWakeupRequests(companyId);
expect(allWakes.length).toBe(2);
// Filter by agentId
const agent1Wakes = db.listWakeupRequests(companyId, { agentId: agent1Id });
const agent1Wakes = db.wakeup.listWakeupRequests(companyId, { agentId: agent1Id });
expect(agent1Wakes.length).toBe(1);
expect(agent1Wakes[0].agentId).toBe(agent1Id);
});