Hotfix: separate workspace observation from lock claim — restore artifact projector for cognitive runs
Production regression of T1 (7829acc..15e3863). User reports "明明生成
了很多文件,但只有一个" — the filesystem shows 19 markdown deliverables
in ~/Documents/Github/test/{business-plan,operations,ceo-coordination}/
but the DocumentCenter surfaces only one row.
Root cause is structural, predicted in spirit by Karpathy's Round 1
take ("把'认知'和'执行'两件事一起锁是数据结构错"). The T1 rewrite
collapsed two concerns into one nullable field on the run context:
workspacePath = workspace?.localPath ?? null
^^^^^^^^^ ^^^^
lock target observation root
For lockMode='none' (every cognitive C-suite agent post-T1) the
resolver returns workspace=null, so workspacePath was null, so
artifact-projector.ts:242 short-circuited every projection with
`{ kind: "skipped", reason: "no_workspace" }`. The agents kept
writing files via bash (cwd falls back to the company default
workspace at worker/runtime/index.ts:142), but nothing observed
them — the DocumentCenter only saw the one file that was projected
back when the agent still held an exclusive workspace.
Fix: split the two concerns. WorkspaceResolution gains a non-lock
`observationPath` field; the resolver populates it from the company
primary workspace (new `getCompanyObservationWorkspace` query —
primary first, oldest second, null only when company has zero
workspace rows) for lockMode='none' runs, and from `workspace.localPath`
itself for lockMode='exclusive' runs. RunDispatchParams threads the
field through; turn-context's `workspacePath` reads it first.
artifact-projector.ts is unchanged — it just sees a non-null path
again and resumes baselining, diffing, and upserting work_products
rows the way it did pre-T1.
Three new unit tests pin the regression: cognitive role with
workspace ⇒ observationPath set; cognitive role with no workspace ⇒
observationPath null; exclusive ⇒ observationPath equals
workspace.localPath. typecheck green, 543/543 unit tests, 10/10
eval. No fallback, no mock, no silent degradation.
This commit is contained in:
1 parent
e15bf67c9f
commit
1f2f9770a6
6 files changed
+132
-4
No files matched your search
@@ -217,4 +217,49 @@ describe("resolveWorkspaceWithLockMode", () => {
|
||||
expect(m.workspace).toBeNull();
|
||||
}
|
||||
});
|
||||
|
||||
it("lockMode=none still returns observationPath when company has a workspace (artifact projector regression)", () => {
|
||||
const { companyId } = seedCompany(db);
|
||||
const result = resolveWorkspaceWithLockMode(
|
||||
db,
|
||||
null,
|
||||
{ workspaceId: null, role: "CMO", department: "marketing" },
|
||||
companyId,
|
||||
);
|
||||
expect(result.lockMode).toBe("none");
|
||||
expect(result.workspace).toBeNull();
|
||||
// Observation path is the company's primary workspace localPath
|
||||
// even though no lock is claimed — the artifact projector needs
|
||||
// somewhere to baseline + diff so files written by cognitive
|
||||
// runs surface in the DocumentCenter.
|
||||
expect(result.observationPath).toBe("/tmp/fixture");
|
||||
});
|
||||
|
||||
it("lockMode=none observationPath is null when company has no workspace at all", () => {
|
||||
const companyId = db.company.saveCompany({
|
||||
name: "No-workspace Co",
|
||||
description: "",
|
||||
status: "active",
|
||||
});
|
||||
const result = resolveWorkspaceWithLockMode(
|
||||
db,
|
||||
null,
|
||||
{ workspaceId: null, role: "CFO", department: "finance" },
|
||||
companyId,
|
||||
);
|
||||
expect(result.lockMode).toBe("none");
|
||||
expect(result.observationPath).toBeNull();
|
||||
});
|
||||
|
||||
it("lockMode=exclusive observationPath equals workspace.localPath (single source)", () => {
|
||||
const { companyId, workspaceId } = seedCompany(db);
|
||||
const result = resolveWorkspaceWithLockMode(
|
||||
db,
|
||||
null,
|
||||
{ workspaceId, role: "CTO", department: "engineering" },
|
||||
companyId,
|
||||
);
|
||||
expect(result.lockMode).toBe("exclusive");
|
||||
expect(result.observationPath).toBe(result.workspace?.localPath);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user