fix(artifacts): classify projection filesystem errors
This commit is contained in:
1 parent
eefb515aa2
commit
212e03219d
4 files changed
+190
-22
No files matched your search
@@ -4,9 +4,10 @@
|
|||||||
// modules. If 2026-05-20 passes without decomposition, a follow-up session
|
// modules. If 2026-05-20 passes without decomposition, a follow-up session
|
||||||
// MUST revisit and either decompose or justify the ceiling exception.
|
// MUST revisit and either decompose or justify the ceiling exception.
|
||||||
import { isAbsolute, relative, resolve } from "node:path";
|
import { isAbsolute, relative, resolve } from "node:path";
|
||||||
import { execFileSync } from "node:child_process";
|
import { execFileSync, spawnSync } from "node:child_process";
|
||||||
import { readdirSync, statSync } from "node:fs";
|
import { readdirSync, statSync } from "node:fs";
|
||||||
import type { AppDatabase } from "@main/database";
|
import type { AppDatabase } from "@main/database";
|
||||||
|
import { logAppError, type Logger } from "../errors/index.js";
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Filesystem artifact protocol for pi tool invocations.
|
* Filesystem artifact protocol for pi tool invocations.
|
||||||
@@ -84,6 +85,7 @@ export type ArtifactProjectorRunContext = {
|
|||||||
taskId: string | null;
|
taskId: string | null;
|
||||||
workspaceId: string | null;
|
workspaceId: string | null;
|
||||||
workspacePath: string | null;
|
workspacePath: string | null;
|
||||||
|
logger?: Logger;
|
||||||
/**
|
/**
|
||||||
* mtime snapshot captured at run start for workspaces that are NOT
|
* mtime snapshot captured at run start for workspaces that are NOT
|
||||||
* a git repo. Diff-against-baseline is how `projectBashArtifacts`
|
* a git repo. Diff-against-baseline is how `projectBashArtifacts`
|
||||||
@@ -114,6 +116,28 @@ const BASELINE_SKIP_DIR_NAMES: ReadonlySet<string> = new Set([
|
|||||||
".pnpm-store",
|
".pnpm-store",
|
||||||
]);
|
]);
|
||||||
|
|
||||||
|
const DEFAULT_ARTIFACT_LOGGER: Logger = console;
|
||||||
|
|
||||||
|
function logArtifactFsError(
|
||||||
|
logger: Logger | undefined,
|
||||||
|
error: unknown,
|
||||||
|
code: string,
|
||||||
|
message: string,
|
||||||
|
context: Record<string, unknown>,
|
||||||
|
): void {
|
||||||
|
logAppError(
|
||||||
|
logger ?? DEFAULT_ARTIFACT_LOGGER,
|
||||||
|
error,
|
||||||
|
{
|
||||||
|
kind: "recoverable",
|
||||||
|
code,
|
||||||
|
message,
|
||||||
|
context,
|
||||||
|
},
|
||||||
|
"warn",
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Capture a run-start mtime baseline only for workspaces that need
|
* Capture a run-start mtime baseline only for workspaces that need
|
||||||
* one. Git workspaces return null here because `git status` already
|
* one. Git workspaces return null here because `git status` already
|
||||||
@@ -130,12 +154,22 @@ const BASELINE_SKIP_DIR_NAMES: ReadonlySet<string> = new Set([
|
|||||||
* still covers every path that was captured while the operator sees
|
* still covers every path that was captured while the operator sees
|
||||||
* the cap signal.
|
* the cap signal.
|
||||||
*/
|
*/
|
||||||
export function captureBaselineIfRequired(workspacePath: string | null): WorkspaceBaseline | null {
|
export function captureBaselineIfRequired(
|
||||||
|
workspacePath: string | null,
|
||||||
|
logger?: Logger,
|
||||||
|
): WorkspaceBaseline | null {
|
||||||
if (!workspacePath) return null;
|
if (!workspacePath) return null;
|
||||||
if (isGitRepo(workspacePath)) return null;
|
if (isGitRepo(workspacePath)) return null;
|
||||||
try {
|
try {
|
||||||
if (!statSync(workspacePath).isDirectory()) return null;
|
if (!statSync(workspacePath).isDirectory()) return null;
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.workspace_stat_failed",
|
||||||
|
"Failed to stat workspace before artifact baseline capture.",
|
||||||
|
{ workspacePath },
|
||||||
|
);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
const mtimeByRelPath = new Map<string, number>();
|
const mtimeByRelPath = new Map<string, number>();
|
||||||
@@ -151,7 +185,14 @@ export function captureBaselineIfRequired(workspacePath: string | null): Workspa
|
|||||||
let entries: { name: string; isDirectory: () => boolean; isSymbolicLink: () => boolean }[];
|
let entries: { name: string; isDirectory: () => boolean; isSymbolicLink: () => boolean }[];
|
||||||
try {
|
try {
|
||||||
entries = readdirSync(dir, { withFileTypes: true });
|
entries = readdirSync(dir, { withFileTypes: true });
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.baseline_readdir_failed",
|
||||||
|
"Failed to read workspace directory during artifact baseline capture.",
|
||||||
|
{ workspacePath, dir },
|
||||||
|
);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
for (const entry of entries) {
|
for (const entry of entries) {
|
||||||
@@ -168,7 +209,14 @@ export function captureBaselineIfRequired(workspacePath: string | null): Workspa
|
|||||||
const rel = relative(workspacePath, abs);
|
const rel = relative(workspacePath, abs);
|
||||||
if (rel.length === 0) continue;
|
if (rel.length === 0) continue;
|
||||||
mtimeByRelPath.set(rel, stat.mtimeMs);
|
mtimeByRelPath.set(rel, stat.mtimeMs);
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.baseline_stat_failed",
|
||||||
|
"Failed to stat workspace file during artifact baseline capture.",
|
||||||
|
{ workspacePath, absPath: abs },
|
||||||
|
);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
if (mtimeByRelPath.size >= MAX_BASELINE_ENTRIES) {
|
if (mtimeByRelPath.size >= MAX_BASELINE_ENTRIES) {
|
||||||
@@ -366,7 +414,11 @@ function retireDeletedArtifacts(
|
|||||||
* emit a `baseline_truncated` outcome so operators see the degraded
|
* emit a `baseline_truncated` outcome so operators see the degraded
|
||||||
* signal.
|
* signal.
|
||||||
*/
|
*/
|
||||||
function diffAgainstBaseline(workspacePath: string, baseline: WorkspaceBaseline): GitChangeSet {
|
function diffAgainstBaseline(
|
||||||
|
workspacePath: string,
|
||||||
|
baseline: WorkspaceBaseline,
|
||||||
|
logger: Logger | undefined,
|
||||||
|
): GitChangeSet {
|
||||||
const changed: string[] = [];
|
const changed: string[] = [];
|
||||||
const seenRels = new Set<string>();
|
const seenRels = new Set<string>();
|
||||||
const stack: string[] = [workspacePath];
|
const stack: string[] = [workspacePath];
|
||||||
@@ -376,7 +428,14 @@ function diffAgainstBaseline(workspacePath: string, baseline: WorkspaceBaseline)
|
|||||||
let entries: { name: string; isDirectory: () => boolean; isSymbolicLink: () => boolean }[];
|
let entries: { name: string; isDirectory: () => boolean; isSymbolicLink: () => boolean }[];
|
||||||
try {
|
try {
|
||||||
entries = readdirSync(dir, { withFileTypes: true });
|
entries = readdirSync(dir, { withFileTypes: true });
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.diff_readdir_failed",
|
||||||
|
"Failed to read workspace directory during artifact diff.",
|
||||||
|
{ workspacePath, dir },
|
||||||
|
);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
for (const entry of entries) {
|
for (const entry of entries) {
|
||||||
@@ -392,7 +451,14 @@ function diffAgainstBaseline(workspacePath: string, baseline: WorkspaceBaseline)
|
|||||||
const stat = statSync(abs);
|
const stat = statSync(abs);
|
||||||
if (!stat.isFile()) continue;
|
if (!stat.isFile()) continue;
|
||||||
mtimeMs = stat.mtimeMs;
|
mtimeMs = stat.mtimeMs;
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.diff_stat_failed",
|
||||||
|
"Failed to stat workspace file during artifact diff.",
|
||||||
|
{ workspacePath, absPath: abs },
|
||||||
|
);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
const rel = relative(workspacePath, abs);
|
const rel = relative(workspacePath, abs);
|
||||||
@@ -458,12 +524,19 @@ function collectChangedPaths(ctx: ArtifactProjectorRunContext): ChangeSet {
|
|||||||
try {
|
try {
|
||||||
const gitSet = listChangedRelPaths(ctx.workspacePath);
|
const gitSet = listChangedRelPaths(ctx.workspacePath);
|
||||||
return { source: "git", changed: gitSet.changed, deleted: gitSet.deleted };
|
return { source: "git", changed: gitSet.changed, deleted: gitSet.deleted };
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
ctx.logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.git_status_failed",
|
||||||
|
"Failed to read git status during artifact projection.",
|
||||||
|
{ workspacePath: ctx.workspacePath, runId: ctx.runId },
|
||||||
|
);
|
||||||
return { source: "none", changed: [], deleted: [], skipReason: "git_status_failed" };
|
return { source: "none", changed: [], deleted: [], skipReason: "git_status_failed" };
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (ctx.workspaceBaseline) {
|
if (ctx.workspaceBaseline) {
|
||||||
const diff = diffAgainstBaseline(ctx.workspacePath, ctx.workspaceBaseline);
|
const diff = diffAgainstBaseline(ctx.workspacePath, ctx.workspaceBaseline, ctx.logger);
|
||||||
return {
|
return {
|
||||||
source: "baseline",
|
source: "baseline",
|
||||||
changed: diff.changed,
|
changed: diff.changed,
|
||||||
@@ -510,16 +583,12 @@ function projectBashArtifacts(
|
|||||||
* itself would accept the directory, which is the semantics we want.
|
* itself would accept the directory, which is the semantics we want.
|
||||||
*/
|
*/
|
||||||
function isGitRepo(workspacePath: string): boolean {
|
function isGitRepo(workspacePath: string): boolean {
|
||||||
try {
|
const result = spawnSync("git", ["rev-parse", "--is-inside-work-tree"], {
|
||||||
execFileSync("git", ["rev-parse", "--is-inside-work-tree"], {
|
cwd: workspacePath,
|
||||||
cwd: workspacePath,
|
timeout: 2_000,
|
||||||
timeout: 2_000,
|
stdio: ["ignore", "ignore", "ignore"],
|
||||||
stdio: ["ignore", "ignore", "ignore"],
|
});
|
||||||
});
|
return result.status === 0;
|
||||||
return true;
|
|
||||||
} catch {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
interface GitChangeSet {
|
interface GitChangeSet {
|
||||||
@@ -597,7 +666,18 @@ function upsertFilesystemArtifact(
|
|||||||
let stat: ReturnType<typeof statSync>;
|
let stat: ReturnType<typeof statSync>;
|
||||||
try {
|
try {
|
||||||
stat = statSync(absPath);
|
stat = statSync(absPath);
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
logArtifactFsError(
|
||||||
|
ctx.logger,
|
||||||
|
error,
|
||||||
|
"artifact.fs.path_stat_failed",
|
||||||
|
"Failed to stat filesystem artifact before projection.",
|
||||||
|
{
|
||||||
|
workspacePath,
|
||||||
|
absPath,
|
||||||
|
runId: ctx.runId,
|
||||||
|
},
|
||||||
|
);
|
||||||
return { kind: "skipped", reason: "path_missing" };
|
return { kind: "skipped", reason: "path_missing" };
|
||||||
}
|
}
|
||||||
if (!stat.isFile()) {
|
if (!stat.isFile()) {
|
||||||
|
|||||||
@@ -162,6 +162,7 @@ export function handleAfterToolCall(
|
|||||||
taskId: ctx.taskId,
|
taskId: ctx.taskId,
|
||||||
workspaceId: ctx.workspaceId,
|
workspaceId: ctx.workspaceId,
|
||||||
workspacePath: ctx.workspacePath,
|
workspacePath: ctx.workspacePath,
|
||||||
|
logger: deps.logger,
|
||||||
workspaceBaseline: ctx.workspaceBaseline,
|
workspaceBaseline: ctx.workspaceBaseline,
|
||||||
};
|
};
|
||||||
try {
|
try {
|
||||||
|
|||||||
@@ -195,6 +195,7 @@ export class RuntimeBridge {
|
|||||||
taskId: ctx.taskId,
|
taskId: ctx.taskId,
|
||||||
workspaceId: ctx.workspaceId,
|
workspaceId: ctx.workspaceId,
|
||||||
workspacePath: ctx.workspacePath,
|
workspacePath: ctx.workspacePath,
|
||||||
|
logger: this.deps.logger,
|
||||||
workspaceBaseline: ctx.workspaceBaseline,
|
workspaceBaseline: ctx.workspaceBaseline,
|
||||||
});
|
});
|
||||||
const inserted = outcomes.filter((o) => o.kind === "inserted").length;
|
const inserted = outcomes.filter((o) => o.kind === "inserted").length;
|
||||||
@@ -643,7 +644,7 @@ export class RuntimeBridge {
|
|||||||
// `git status` is the source of truth there, and paying for an
|
// `git status` is the source of truth there, and paying for an
|
||||||
// O(tree) scan on every run just to throw the result away is a
|
// O(tree) scan on every run just to throw the result away is a
|
||||||
// hot-path tax the scheduler should not be paying.
|
// hot-path tax the scheduler should not be paying.
|
||||||
const baseline = captureBaselineIfRequired(payload.workspacePath);
|
const baseline = captureBaselineIfRequired(payload.workspacePath, this.deps.logger);
|
||||||
this.registerActiveRun({
|
this.registerActiveRun({
|
||||||
runId,
|
runId,
|
||||||
agentId: payload.agentId,
|
agentId: payload.agentId,
|
||||||
|
|||||||
@@ -0,0 +1,86 @@
|
|||||||
|
import { mkdtemp, rm } from "node:fs/promises";
|
||||||
|
import { join } from "node:path";
|
||||||
|
import { tmpdir } from "node:os";
|
||||||
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||||
|
import type { AppDatabase } from "../../src/main/database";
|
||||||
|
import {
|
||||||
|
captureBaselineIfRequired,
|
||||||
|
projectToolExecutionToWorkProduct,
|
||||||
|
type ArtifactProjectorRunContext,
|
||||||
|
} from "../../src/main/agent-runtime/artifact-projector";
|
||||||
|
|
||||||
|
const tempDirs: string[] = [];
|
||||||
|
|
||||||
|
async function createTempDir(prefix: string): Promise<string> {
|
||||||
|
const dir = await mkdtemp(join(tmpdir(), prefix));
|
||||||
|
tempDirs.push(dir);
|
||||||
|
return dir;
|
||||||
|
}
|
||||||
|
|
||||||
|
function createLogger() {
|
||||||
|
return {
|
||||||
|
warn: vi.fn(),
|
||||||
|
error: vi.fn(),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
afterEach(async () => {
|
||||||
|
await Promise.all(tempDirs.splice(0).map((dir) => rm(dir, { recursive: true, force: true })));
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("artifact projector error taxonomy", () => {
|
||||||
|
it("classifies unreadable workspace baseline capture failures", async () => {
|
||||||
|
const logger = createLogger();
|
||||||
|
const parent = await createTempDir("agentcompany-missing-workspace-parent-");
|
||||||
|
const workspacePath = join(parent, "missing-workspace");
|
||||||
|
|
||||||
|
const baseline = captureBaselineIfRequired(workspacePath, logger);
|
||||||
|
|
||||||
|
expect(baseline).toBeNull();
|
||||||
|
expect(logger.warn).toHaveBeenCalledWith(
|
||||||
|
"[artifact.fs.workspace_stat_failed] Failed to stat workspace before artifact baseline capture.",
|
||||||
|
{ workspacePath },
|
||||||
|
expect.stringContaining("cause="),
|
||||||
|
);
|
||||||
|
expect(logger.error).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("classifies missing filesystem artifact projection failures", async () => {
|
||||||
|
const logger = createLogger();
|
||||||
|
const workspacePath = await createTempDir("agentcompany-artifact-errors-");
|
||||||
|
const absPath = join(workspacePath, "missing.md");
|
||||||
|
const ctx: ArtifactProjectorRunContext = {
|
||||||
|
runId: "run-artifact-error",
|
||||||
|
agentId: "agent-artifact-error",
|
||||||
|
companyId: "company-artifact-error",
|
||||||
|
taskId: "task-artifact-error",
|
||||||
|
workspaceId: "workspace-artifact-error",
|
||||||
|
workspacePath,
|
||||||
|
logger,
|
||||||
|
workspaceBaseline: null,
|
||||||
|
};
|
||||||
|
|
||||||
|
const outcomes = projectToolExecutionToWorkProduct(
|
||||||
|
{} as AppDatabase,
|
||||||
|
ctx,
|
||||||
|
{
|
||||||
|
toolName: "write",
|
||||||
|
args: { path: "missing.md" },
|
||||||
|
result: null,
|
||||||
|
isError: false,
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(outcomes).toEqual([{ kind: "skipped", reason: "path_missing" }]);
|
||||||
|
expect(logger.warn).toHaveBeenCalledWith(
|
||||||
|
"[artifact.fs.path_stat_failed] Failed to stat filesystem artifact before projection.",
|
||||||
|
{
|
||||||
|
workspacePath,
|
||||||
|
absPath,
|
||||||
|
runId: "run-artifact-error",
|
||||||
|
},
|
||||||
|
expect.stringContaining("cause="),
|
||||||
|
);
|
||||||
|
expect(logger.error).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in new issue
Block a user