Chat-wake tasks live and die with their reply run
Of the 202 tasks stranded in the backlog on July 9, 200 were "Reply to ..." wake vehicles: every agent @mention creates a task plus a queued run, the reply goes out, and nothing ever closed the task — a task with a completed run is never enqueued again, so each one became a permanent zombie row. On top of that, every message in an active thread minted a fresh wake even when the target already had one queued, multiplying runs that would each read the same conversation. The lifecycle contract, made explicit: - The reply run IS the wake task's deliverable. Completing a chat_mention run now closes its task (backlog/in_progress -> done, via the audited status path). Tasks an agent moved to review are left alone. - One pending wake per (agent, thread): wakeFromMention returns the queued run instead of minting a duplicate — that run reads the thread's newest messages when it executes anyway. - Migration 054 heals existing rows: wake tasks whose runs are all spent close as done; in-flight wakes keep working. This also stops Fix 1's retry-budget healing from resurrecting 31 stale replies on next launch. The chat-governance loop test now completes each pending wake run between posts, matching how the exchange actually interleaves in production.
This commit is contained in:
1 parent
927bdc91f2
commit
2526633bfb
9 files changed
+149
-4
No files matched your search
@@ -0,0 +1,16 @@
|
||||
export const closeStaleWakeTasksSchema = `
|
||||
-- Chat-wake tasks are conversation vehicles: the reply run is their whole
|
||||
-- deliverable. Runs used to complete without closing them, stranding every
|
||||
-- "Reply to ..." row in the backlog forever (a task with a completed run is
|
||||
-- never enqueued again). Close each wake task whose runs have all been
|
||||
-- spent; run completion closes them from now on. In-flight wakes (a queued
|
||||
-- or running run) keep working normally.
|
||||
update tasks
|
||||
set status = 'done', updated_at = datetime('now')
|
||||
where status in ('backlog', 'in_progress')
|
||||
and exists (select 1 from task_runs r where r.task_id = tasks.id and r.trigger = 'chat_mention')
|
||||
and not exists (select 1 from task_runs r where r.task_id = tasks.id and r.state in ('queued', 'running'));
|
||||
|
||||
insert into schema_migrations(version, name, applied_at)
|
||||
values (54, 'close_stale_wake_tasks', datetime('now'));
|
||||
`;
|
||||
@@ -52,6 +52,7 @@ import { financeSalesDepartmentsSchema } from "./migrations/050-finance-sales-de
|
||||
import { purgeRuntimeSnapshotBloatSchema } from "./migrations/051-purge-runtime-snapshot-bloat";
|
||||
import { avatarImagesSchema } from "./migrations/052-avatar-images";
|
||||
import { autonomousPauseSchema } from "./migrations/053-autonomous-pause";
|
||||
import { closeStaleWakeTasksSchema } from "./migrations/054-close-stale-wake-tasks";
|
||||
|
||||
interface Migration {
|
||||
version: number;
|
||||
@@ -113,6 +114,7 @@ const MIGRATIONS: Migration[] = [
|
||||
{ version: 51, name: "purge_runtime_snapshot_bloat", sql: purgeRuntimeSnapshotBloatSchema },
|
||||
{ version: 52, name: "avatar_images", sql: avatarImagesSchema },
|
||||
{ version: 53, name: "autonomous_pause", sql: autonomousPauseSchema },
|
||||
{ version: 54, name: "close_stale_wake_tasks", sql: closeStaleWakeTasksSchema },
|
||||
];
|
||||
|
||||
const SCHEMA_VERSION = MIGRATIONS[MIGRATIONS.length - 1].version;
|
||||
|
||||
@@ -37,6 +37,11 @@ export class ChatAgentWakeService {
|
||||
|
||||
wakeFromMention(input: SendMessageInput, agentId: string, messageId: string, threadId: string, now: string): AgentWakeResult {
|
||||
const agent = this.requireRunnableAgent(input.orgId, agentId, "Agent mention");
|
||||
// One pending wake per (agent, thread): the queued run reads the thread's
|
||||
// newest messages when it executes, so waking again before it starts would
|
||||
// spend a whole run to answer the same conversation twice.
|
||||
const pending = this.pendingWakeRun(input.orgId, agentId, threadId);
|
||||
if (pending) return { targetId: agentId, taskId: pending.taskId, runId: pending.runId };
|
||||
const workspace = this.workspaceForAgent(input.orgId, agent.workspace_id);
|
||||
const from = this.principalName(input.orgId, input.senderType, input.senderId);
|
||||
const space = this.spaceRow(input.orgId, input.spaceId);
|
||||
@@ -81,6 +86,16 @@ export class ChatAgentWakeService {
|
||||
return { targetId: agent.id, taskId, runId };
|
||||
}
|
||||
|
||||
private pendingWakeRun(orgId: string, agentId: string, threadId: string): { taskId: string; runId: string } | null {
|
||||
const row = this.db.prepare(`
|
||||
select id, task_id from task_runs
|
||||
where org_id = ? and agent_id = ? and state = 'queued' and trigger = 'chat_mention'
|
||||
and json_extract(secret_scope_json, '$.sourceThreadId') = ?
|
||||
limit 1
|
||||
`).get(orgId, agentId, threadId) as { id: string; task_id: string } | undefined;
|
||||
return row ? { taskId: row.task_id, runId: row.id } : null;
|
||||
}
|
||||
|
||||
private requireAgentMention(mentions: ResolvedMention[]): string {
|
||||
const target = mentions.find((mention) => mention.target.type === "agent")?.target;
|
||||
if (!target || target.type !== "agent") throw new Error("Slash command /agent requires an agent mention.");
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import type { DatabaseSync } from "node:sqlite";
|
||||
import type { RunTaskInput } from "../../shared/commands";
|
||||
import { APPROVAL_STATE, RISK_LEVEL } from "../../shared/domain";
|
||||
import { APPROVAL_STATE, RISK_LEVEL, TASK_STATUS } from "../../shared/domain";
|
||||
import { currentProviderUsageWindow, isTransientProviderFailure } from "../../shared/provider-runtime-domain";
|
||||
import { createId } from "../../shared/ids";
|
||||
import { AuditService } from "./audit-service";
|
||||
@@ -524,6 +524,23 @@ export class TaskExecutionService {
|
||||
set state = ?, provider_request_id = ?, completed_at = ?, error_message = null
|
||||
where id = ? and org_id = ?
|
||||
`).run(TASK_RUN_STATE.COMPLETED, providerRequestId, new Date().toISOString(), runId, orgId);
|
||||
this.closeChatWakeTask(orgId, runId);
|
||||
}
|
||||
|
||||
/**
|
||||
* A chat-wake task exists only to carry its reply run — the reply is the
|
||||
* whole deliverable. The run completing therefore closes the task; left
|
||||
* open it would strand forever (a task with a completed run is never
|
||||
* enqueued again) and pile zombie "Reply to ..." rows onto the board.
|
||||
*/
|
||||
private closeChatWakeTask(orgId: string, runId: string): void {
|
||||
const run = this.db.prepare("select task_id, trigger from task_runs where id = ? and org_id = ?")
|
||||
.get(runId, orgId) as { task_id: string; trigger: string } | undefined;
|
||||
if (!run || run.trigger !== "chat_mention") return;
|
||||
const task = this.db.prepare("select status from tasks where id = ? and org_id = ?")
|
||||
.get(run.task_id, orgId) as { status: string } | undefined;
|
||||
if (!task || (task.status !== TASK_STATUS.BACKLOG && task.status !== TASK_STATUS.IN_PROGRESS)) return;
|
||||
this.organization.updateTaskStatus(orgId, run.task_id, TASK_STATUS.DONE);
|
||||
}
|
||||
|
||||
private failRun(orgId: string, runId: string, providerRequestId: string | null, errorMessage: string): void {
|
||||
|
||||
Reference in new issue
Block a user