refactor(errors): surface 57 deferred catch-and-swallow sites via logger

The earlier sweep cleaned the hot path (worker/runtime/automation/api-
server/ipc core — 59 sites). This pass finishes the deferred long tail:
main/* services, database/* CRUD modules, api-server/* routes, ipc-*
handlers, thread-integration, automation helpers, browser, skills.

Default strategy: catch (error) { logger.warn("[module] context:", ...) }
— preserve current behavior, make the failure visible instead of
silently hidden. Widened 3 logger interface signatures to include warn
where callers only passed info/error previously (thread-helpers,
host-environment-service, ipc-domain-common).

Legitimate boundaries left intact: JSON.parse on untrusted input, DNS
resolver no-records paths, explicit safe* helpers (safeJson, parseJson,
parseTriggerDetail), URL-parse predicates, and `<unserialisable>`
fallbacks inside the prompt-builder summarisers. Each kept catch now
either has a reason in context or is a documented safe* helper.

Tests adjusted only where test-constructed no-op loggers needed a warn
stub (message-dispatch, company-mode-switch, ipc-agent-graph-handlers).

With the earlier pass, AgentCompany no longer has silently-swallowing
catch blocks in main-process or renderer business code.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 15:25:13 -04:00
1 parent ecd1bc2e33
commit 40040b3dd2
46 files changed
+209 -113

No files matched your search

+7 -3
View File
@@ -1,3 +1,4 @@
import log from "electron-log/main.js";
import { z } from "zod";
import { goalInputSchema, projectInputSchema } from "@shared/contracts";
import { canManageGoal, canManageProject } from "../agent-permissions";
@@ -102,7 +103,8 @@ export function registerWorkGraphRoutes(server: AgentApiServer) {
});
onDomainChanged();
server.json(res, 200, { ok: true });
} catch {
} catch (err) {
log.warn(`[api/work-graph] Failed to update project:`, err instanceof Error ? err.message : String(err));
server.json(res, 500, { error: "Failed to update project" });
}
});
@@ -187,7 +189,8 @@ export function registerWorkGraphRoutes(server: AgentApiServer) {
});
onDomainChanged();
server.json(res, 200, { ok: true });
} catch {
} catch (err) {
log.warn(`[api/work-graph] Failed to update goal:`, err instanceof Error ? err.message : String(err));
server.json(res, 500, { error: "Failed to update goal" });
}
});
@@ -241,7 +244,8 @@ export function registerWorkGraphRoutes(server: AgentApiServer) {
});
onDomainChanged();
server.json(res, 201, { id });
} catch {
} catch (err) {
log.warn(`[api/work-graph] Invalid sprint data:`, err instanceof Error ? err.message : String(err));
server.json(res, 400, { error: "Invalid sprint data" });
}
});