refactor(errors): surface 57 deferred catch-and-swallow sites via logger

The earlier sweep cleaned the hot path (worker/runtime/automation/api-
server/ipc core — 59 sites). This pass finishes the deferred long tail:
main/* services, database/* CRUD modules, api-server/* routes, ipc-*
handlers, thread-integration, automation helpers, browser, skills.

Default strategy: catch (error) { logger.warn("[module] context:", ...) }
— preserve current behavior, make the failure visible instead of
silently hidden. Widened 3 logger interface signatures to include warn
where callers only passed info/error previously (thread-helpers,
host-environment-service, ipc-domain-common).

Legitimate boundaries left intact: JSON.parse on untrusted input, DNS
resolver no-records paths, explicit safe* helpers (safeJson, parseJson,
parseTriggerDetail), URL-parse predicates, and `<unserialisable>`
fallbacks inside the prompt-builder summarisers. Each kept catch now
either has a reason in context or is a documented safe* helper.

Tests adjusted only where test-constructed no-op loggers needed a warn
stub (message-dispatch, company-mode-switch, ipc-agent-graph-handlers).

With the earlier pass, AgentCompany no longer has silently-swallowing
catch blocks in main-process or renderer business code.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 15:25:13 -04:00
1 parent ecd1bc2e33
commit 40040b3dd2
46 files changed
+209 -113

No files matched your search

+3 -2
View File
@@ -1,4 +1,5 @@
import type { DatabaseSync, SQLInputValue } from "node:sqlite";
import log from "electron-log/main.js";
import type { AgentRecord, AgentRoleLevel, ConnectorId } from "@shared/types";
import {
type ReadAll,
@@ -125,8 +126,8 @@ export function buildAgentCrudMethods(
configBefore: beforeConfig,
configAfter: afterConfig,
});
} catch {
/* Non-fatal: revision recording should never block agent save */
} catch (err) {
log.warn(`[database/agents] recordConfigRevision failed for agent ${id}:`, err instanceof Error ? err.message : String(err));
}
}
}
+3 -2
View File
@@ -2,6 +2,7 @@ import { chmodSync, existsSync, mkdirSync } from "node:fs";
import { copyFile, cp, rm } from "node:fs/promises";
import { join } from "node:path";
import { DatabaseSync, backup as backupDatabase } from "node:sqlite";
import log from "electron-log/main.js";
async function copyIfExists(source: string, destination: string) {
if (!existsSync(source)) {
@@ -107,8 +108,8 @@ export function buildBackupMethods(
try {
deps.setDb(deps.openConnection());
deps.init();
} catch {
// Reopen failed. Caller sees original + recovery messages.
} catch (reopenError) {
log.error(`[database/backup] Reopen failed after restore/recovery failure:`, reopenError instanceof Error ? reopenError.message : String(reopenError));
}
throw new Error(
`Restore failed: ${message}. Recovery also failed: ${recoveryMessage}. Previous profile is at ${recoveryDir}.`,
+5 -2
View File
@@ -1,4 +1,5 @@
import type { DatabaseSync } from "node:sqlite";
import log from "electron-log/main.js";
import type { ConnectorId, ConnectorRecord } from "@shared/types";
import type { ReadAll } from "./helpers";
import { nowIso } from "./helpers";
@@ -30,7 +31,8 @@ export function buildConnectorMethods(
let definition;
try {
definition = getConnectorDefinition(row.id as ConnectorId);
} catch {
} catch (err) {
log.warn(`[database/connectors] Unknown connector id ${row.id}; skipping row:`, err instanceof Error ? err.message : String(err));
continue;
}
result.push({
@@ -110,7 +112,8 @@ export function buildConnectorMethods(
let definition;
try {
definition = getConnectorDefinition(row.id as ConnectorId);
} catch {
} catch (err) {
log.warn(`[database/connectors] Unknown connector id ${row.id} in findConnector:`, err instanceof Error ? err.message : String(err));
return null;
}
return {
+5 -2
View File
@@ -1,5 +1,6 @@
import { randomUUID } from "node:crypto";
import type { DatabaseSync, SQLInputValue } from "node:sqlite";
import log from "electron-log/main.js";
import type { AgentMessageRecord, AgentRecord } from "@shared/types";
import {
BOARD_READER_ID,
@@ -139,7 +140,8 @@ export function buildMessageMethods(
if (agent.companyId === companyId) {
department = agent.department;
}
} catch {
} catch (err) {
log.warn(`[database/messages] getAgent failed for ${opts.agentId}; department filter disabled:`, err instanceof Error ? err.message : String(err));
department = null;
}
@@ -277,7 +279,8 @@ export function buildMessageMethods(
if (agent.companyId === companyId) {
department = agent.department;
}
} catch {
} catch (err) {
log.warn(`[database/messages] getAgent failed for ${agentId} in listAgentInboxUnread; department filter disabled:`, err instanceof Error ? err.message : String(err));
department = null;
}
+3 -1
View File
@@ -3,6 +3,7 @@ import { writeFileSync, readFileSync, existsSync, statSync, openSync, readSync,
import { appendFile } from "node:fs/promises";
import { join } from "node:path";
import type { DatabaseSync, SQLInputValue } from "node:sqlite";
import log from "electron-log/main.js";
import type { ConnectorId, RunLogChunk, RunRecord } from "@shared/types";
import { type ReadAll, type SqliteRow, type Transaction, nowIso, toBoolean } from "./helpers";
@@ -90,7 +91,8 @@ export function buildRunMethods(
if (!run?.logPath) return "";
try {
return readFileSync(run.logPath, "utf8");
} catch {
} catch (err) {
log.warn(`[database/runs] readFileSync failed for run ${runId} log ${run.logPath}:`, err instanceof Error ? err.message : String(err));
return "";
}
},