refactor(errors): surface 57 deferred catch-and-swallow sites via logger

The earlier sweep cleaned the hot path (worker/runtime/automation/api-
server/ipc core — 59 sites). This pass finishes the deferred long tail:
main/* services, database/* CRUD modules, api-server/* routes, ipc-*
handlers, thread-integration, automation helpers, browser, skills.

Default strategy: catch (error) { logger.warn("[module] context:", ...) }
— preserve current behavior, make the failure visible instead of
silently hidden. Widened 3 logger interface signatures to include warn
where callers only passed info/error previously (thread-helpers,
host-environment-service, ipc-domain-common).

Legitimate boundaries left intact: JSON.parse on untrusted input, DNS
resolver no-records paths, explicit safe* helpers (safeJson, parseJson,
parseTriggerDetail), URL-parse predicates, and `<unserialisable>`
fallbacks inside the prompt-builder summarisers. Each kept catch now
either has a reason in context or is a documented safe* helper.

Tests adjusted only where test-constructed no-op loggers needed a warn
stub (message-dispatch, company-mode-switch, ipc-agent-graph-handlers).

With the earlier pass, AgentCompany no longer has silently-swallowing
catch blocks in main-process or renderer business code.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 15:25:13 -04:00
1 parent ecd1bc2e33
commit 40040b3dd2
46 files changed
+209 -113

No files matched your search

+5 -3
View File
@@ -7,6 +7,7 @@ import { app } from "electron";
interface HostEnvironmentDependencies {
logger: {
info: (...args: unknown[]) => void;
warn: (...args: unknown[]) => void;
};
}
@@ -29,7 +30,8 @@ function enrichWindowsPath(logger: HostEnvironmentDependencies["logger"]) {
return readdirSync(pythonBase)
.filter((name) => /^Python\d+$/.test(name))
.map((name) => join(pythonBase, name, "Scripts"));
} catch {
} catch (err) {
logger.warn(`[path] readdirSync failed for ${pythonBase}:`, err instanceof Error ? err.message : String(err));
return [];
}
})();
@@ -94,8 +96,8 @@ export async function prepareHostEnvironment({
logger.info(`[path] Added ${toAdd.length} shell PATH entries.`);
}
}
} catch {
// Non-fatal environment enrichment.
} catch (err) {
logger.warn(`[path] Shell PATH probe failed:`, err instanceof Error ? err.message : String(err));
}
} else {
logger.info("[path] Skipping interactive shell PATH probe; using deterministic PATH setup only.");