Codemod db pass-through calls to domain modules: tasks + agents (C1 part 1/3)

Rewrite ~525 call sites from `db.<method>()` to `db.<module>.<method>()`
for tasks and agents domains (including `getAgent`/`findAgent`/`getTask`
which live on the `entityCrud` field). Delete the corresponding
pass-through methods on AppDatabaseBase. Structural types that narrowed
`db` to a bag of flat methods (CapabilityMatchDb, EscalationDeps,
SweepStaleReviewsDeps) are reshaped to match the new namespace. Internal
callback references inside database.ts/database-base.ts now invoke the
owning module directly (e.g. `this.agents.saveAgent`) rather than the
deleted pass-through.

The codemod lives at scripts/codemod/remove-appdatabase-passthrough.mjs
and filters by owning module + optional explicit method list. It is
idempotent and does not re-rewrite already-namespaced calls.
This commit is contained in:
ZacharyZhang-NY committed 2026-04-20 13:17:01 -04:00
1 parent 411294afa6
commit 5e9b7acbc6
95 files changed
+1123 -793

No files matched your search

+6 -6
View File
@@ -41,7 +41,7 @@ function createScaffold(db: AppDatabase) {
repoRef: "",
isPrimary: true,
});
const ceoId = db.saveAgent({
const ceoId = db.agents.saveAgent({
companyId,
name: "CEO",
role: "CEO",
@@ -54,7 +54,7 @@ function createScaffold(db: AppDatabase) {
capabilities: "Lead the company",
budgetMonthlyUsd: 250,
});
const ctoId = db.saveAgent({
const ctoId = db.agents.saveAgent({
companyId,
name: "CTO",
role: "CTO",
@@ -68,7 +68,7 @@ function createScaffold(db: AppDatabase) {
budgetMonthlyUsd: 200,
department: "engineering",
});
const cmoId = db.saveAgent({
const cmoId = db.agents.saveAgent({
companyId,
name: "CMO",
role: "CMO",
@@ -82,7 +82,7 @@ function createScaffold(db: AppDatabase) {
budgetMonthlyUsd: 200,
department: "marketing",
});
const pendingId = db.saveAgent({
const pendingId = db.agents.saveAgent({
companyId,
name: "Pending Recruit",
role: "IC",
@@ -96,7 +96,7 @@ function createScaffold(db: AppDatabase) {
budgetMonthlyUsd: 100,
department: "engineering",
});
const terminatedId = db.saveAgent({
const terminatedId = db.agents.saveAgent({
companyId,
name: "Former COO",
role: "COO",
@@ -111,7 +111,7 @@ function createScaffold(db: AppDatabase) {
department: "operations",
});
const taskId = db.saveTask({
const taskId = db.tasks.saveTask({
companyId,
title: "Review architecture plan",
description: "Need board feedback in the thread.",