Q7: an agent runs one session at a time

Claims skip agents that already have a running run, manual runs refuse a
busy agent, a run whose task was reassigned fails before executing, and
tasks with a run in progress cannot be deleted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/integration/task-context-scope.test.ts

@@ -7,6 +7,7 @@ import { OnboardingService } from "../../src/main/services/onboarding-service";
 import { ProviderService } from "../../src/main/services/provider-service";
 import { providerAdapters } from "../../src/main/services/provider-adapters";
 import { TaskExecutionService } from "../../src/main/services/task-execution-service";
+import { OrganizationService } from "../../src/main/services/organization-service";
 import { claimNextQueuedRun } from "../../src/main/app/task-queue-worker";
 import { canonicalMentionHandle } from "../../src/shared/mention-handles";
 import type { AgentTurnResult, ProviderToolTurnInput, ToolCall } from "../../src/main/services/provider-tool-turn";
@@ -64,9 +65,53 @@ describe("task prompt scope", () => {
     const task = connection.db.prepare("select id from tasks where org_id = ? and title = 'Build the booking API'").get(orgId) as { id: string };
     await execution.runTask({ orgId, taskId: task.id });
 
+    const danaId = (connection.db.prepare("select id from agents where org_id = ? and name = 'Dana Lee'").get(orgId) as { id: string }).id;
+    connection.db.prepare("update task_runs set state = 'running' where agent_id = ? and trigger = 'chat_mention'").run(danaId);
+    await expect(execution.runTask({ orgId, taskId: task.id })).rejects.toThrow("This agent is already working on");
+    const busyTaskId = (connection.db.prepare("select task_id from task_runs where agent_id = ? and state = 'running'").get(danaId) as { task_id: string }).task_id;
+    expect(() => new OrganizationService(connection.db).deleteTask({ orgId, taskId: busyTaskId })).toThrow("has a run in progress");
+    expect(connection.db.prepare("select count(*) as n from task_runs where task_id = ? and state = 'running'").get(busyTaskId)).toEqual({ n: 1 });
     expect(danaPrompts).toHaveLength(1);
     expect(danaPrompts[0]).toContain("Build the booking API");
     expect(danaPrompts[0]).not.toContain(CHANNEL_NOTE);
     connection.close();
   });
+
+  test("a queued run whose task was reassigned fails instead of running as someone else", async () => {
+    const connection = new DatabaseConnection(join(tmpdir(), `ac-reassign-${randomUUID()}.db`));
+    let calls = 0;
+    const turn = async (): Promise<AgentTurnResult> => {
+      calls += 1;
+      return { text: "done", toolCalls: [], rawResponseJson: "{}" };
+    };
+    const providers = new ProviderService(connection.db, providerAdapters, testVault, undefined, turn);
+    const onboarding = new OnboardingService({ db: connection.db, saveProviderCredential: (input) => providers.saveCredential(input) });
+    const organization = new OrganizationService(connection.db);
+    const execution = new TaskExecutionService(connection.db, providers);
+    let orgId = "";
+    let ceoId = "";
+    connection.transaction(() => {
+      const summary = onboarding.bootstrap({
+        companyName: "OrbitOps AI", companyDescription: "Ops.", employeeName: "Yang", workspacePath: "",
+        executionMode: "ai_ceo", autoApproveHires: true, reviewDeliverables: false,
+        goalTitle: "Stand up a service business.", goalDescription: "Win customers.",
+        providerKey: "openai", providerSecret: "sk-test-key", providerModel: "gpt-5.4",
+      });
+      orgId = summary.orgId;
+      ceoId = summary.ceoAgentId;
+    });
+    const providerId = (connection.db.prepare("select model_provider_id as id from agents where id = ?").get(ceoId) as { id: string }).id;
+    const otherId = organization.createAgent({
+      orgId, name: "Ops Lead", role: "Ops", department: "Operations",
+      modelProviderId: providerId, modelId: "gpt-5.4", budgetCents: 1000, managerAgentId: ceoId,
+    });
+    const kickoff = claimNextQueuedRun(connection)!;
+    const taskId = (connection.db.prepare("select task_id from task_runs where id = ?").get(kickoff.id) as { task_id: string }).task_id;
+    connection.db.prepare("update tasks set assignee_agent_id = ? where id = ?").run(otherId, taskId);
+
+    await expect(execution.executeRun(orgId, kickoff.id)).rejects.toThrow("Task was reassigned after this run was queued");
+    expect(connection.db.prepare("select state from task_runs where id = ?").get(kickoff.id)).toEqual({ state: "failed" });
+    expect(calls).toBe(0);
+    connection.close();
+  });
 });

tests/unit/claim-priority.test.ts

@@ -98,3 +98,41 @@ describe("queue claim priority", () => {
     h.connection.close();
   });
 });
+
+describe("one session per agent", () => {
+  test("a queued run for an agent that is already running waits; others proceed", () => {
+    const h = harness();
+    const spaceWithCeo = h.chat.ensureDirectSpace(h.orgId, { type: "employee", id: h.employeeId }, { type: "agent", id: h.ceoId });
+    const spaceWithDana = h.chat.ensureDirectSpace(h.orgId, { type: "employee", id: h.employeeId }, { type: "agent", id: h.danaId });
+    const say = (spaceId: string, bodyMd: string) => h.chat.sendMessage({
+      orgId: h.orgId, spaceId, threadId: null, senderType: "employee", senderId: h.employeeId, bodyMd, attachmentFileIds: [],
+    });
+    say(spaceWithCeo, "First question?");
+    say(spaceWithCeo, "Second, separate question?");
+    say(spaceWithDana, "Dana, a question?");
+
+    const first = claimNextQueuedRun(h.connection)!;
+    expect(h.connection.db.prepare("select agent_id from task_runs where id = ?").get(first.id)).toEqual({ agent_id: h.ceoId });
+    const second = claimNextQueuedRun(h.connection)!;
+    expect(h.connection.db.prepare("select agent_id from task_runs where id = ?").get(second.id)).toEqual({ agent_id: h.danaId });
+    expect(claimNextQueuedRun(h.connection)).toBeNull();
+
+    h.connection.db.prepare("update task_runs set state = 'completed' where id = ?").run(first.id);
+    const third = claimNextQueuedRun(h.connection)!;
+    expect(h.connection.db.prepare("select agent_id from task_runs where id = ?").get(third.id)).toEqual({ agent_id: h.ceoId });
+    h.connection.close();
+  });
+
+  test("a running run whose agent was deleted blocks nobody", () => {
+    const h = harness();
+    const spaceWithDana = h.chat.ensureDirectSpace(h.orgId, { type: "employee", id: h.employeeId }, { type: "agent", id: h.danaId });
+    h.chat.sendMessage({ orgId: h.orgId, spaceId: spaceWithDana, threadId: null, senderType: "employee", senderId: h.employeeId, bodyMd: "Hi?", attachmentFileIds: [] });
+    h.connection.db.prepare(`
+      insert into task_runs(id, org_id, task_id, agent_id, provider_id, execution_context_id, service_identity_id, workspace_mount_json, secret_scope_json, trigger, state, created_at)
+      select 'run_orphan', org_id, task_id, null, provider_id, 'ctx_orphan', service_identity_id, workspace_mount_json, '{}', 'manual', 'running', created_at
+      from task_runs where agent_id = ?
+    `).run(h.danaId);
+    expect(h.connection.db.prepare("select agent_id from task_runs where id = ?").get(claimNextQueuedRun(h.connection)!.id)).toEqual({ agent_id: h.danaId });
+    h.connection.close();
+  });
+});

tests/unit/task-queue-worker.test.ts

@@ -40,14 +40,17 @@ describe("task queue worker claim", () => {
     const second = seedQueuedRun(connection, orgId, taskId, agentId, providerId);
 
     const claimedA = claimNextQueuedRun(connection);
+    // One session per agent: the second run waits while the first is running.
+    expect(claimNextQueuedRun(connection)).toBeNull();
+    connection.db.prepare("update task_runs set state = 'completed' where id = ?").run(claimedA!.id);
     const claimedB = claimNextQueuedRun(connection);
     const claimedC = claimNextQueuedRun(connection);
 
     expect([claimedA?.id, claimedB?.id].sort()).toEqual([first, second].sort());
     expect(claimedC).toBeNull();
 
-    const states = (connection.db.prepare("select state from task_runs where org_id = ? order by created_at").all(orgId) as Array<{ state: string }>).map((r) => r.state);
-    expect(states).toEqual(["running", "running"]);
+    const states = (connection.db.prepare("select state from task_runs where org_id = ? order by created_at").all(orgId) as Array<{ state: string }>).map((r) => r.state).sort();
+    expect(states).toEqual(["completed", "running"]);
     connection.close();
   });