From 9227e5f7c419951e892299c4cb5a6457f5475ec5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?=
 <zhangyanghaha0407@outlook.com>
Date: Thu, 16 Apr 2026 23:26:35 -0400
Subject: [PATCH] test(e2e): replace fixture-missing early returns with
 test.skip

3 code paths in desktop.smoke.spec.ts used bare `return` when fixtures
were unavailable (runtime not configured, too few model toggles), which
caused the test to silently pass without exercising the real flow.
Replace with `test.skip(true, reason)` so Playwright reports the skip
and surfaces the missing precondition.
---
 tests/e2e/desktop.smoke.spec.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/e2e/desktop.smoke.spec.ts b/tests/e2e/desktop.smoke.spec.ts
index 3a560744..5a095ed4 100644
--- a/tests/e2e/desktop.smoke.spec.ts
+++ b/tests/e2e/desktop.smoke.spec.ts
@@ -56,7 +56,7 @@ test("first launch onboarding advances into runtime setup and shell-ready flow",
     if (!(await providersContinue.isEnabled())) {
       await expect(page.getByText(/Set up one runtime to continue\./i)).toBeVisible();
       await expect(page.getByText(/Ready|Login required|Not installed|Checking|Error/i).first()).toBeVisible();
-      return;
+      test.skip(true, "runtime fixture missing: no enabled provider to continue past runtime setup");
     }
 
     await providersContinue.click();
@@ -146,7 +146,7 @@ test("onboarding model pool persists across relaunch for a ready connector", asy
     const providersContinue = page.getByRole("button", { name: /^Continue$/i });
     if (!(await providersContinue.isEnabled())) {
       await expect(page.getByText(/Set up one runtime to continue\./i)).toBeVisible();
-      return;
+      test.skip(true, "runtime fixture missing: no enabled provider to continue past runtime setup");
     }
     await providersContinue.click();
 
@@ -158,7 +158,7 @@ test("onboarding model pool persists across relaunch for a ready connector", asy
     const switches = page.getByRole("switch");
     const switchCount = await switches.count();
     if (switchCount < 2) {
-      return;
+      test.skip(true, "model pool fixture missing: need at least 2 model toggles to test persistence");
     }
 
     await switches.nth(1).click();
@@ -177,7 +177,7 @@ test("onboarding model pool persists across relaunch for a ready connector", asy
     const providersContinue = page.getByRole("button", { name: /^Continue$/i });
     if (!(await providersContinue.isEnabled())) {
       await expect(page.getByText(/Set up at least one provider to power your agents\./i)).toBeVisible();
-      return;
+      test.skip(true, "runtime fixture missing: no enabled provider persisted across relaunch");
     }
     await providersContinue.click();