refactor(approvals): move execution policy into database

This commit is contained in:
ZacharyZhang-NY committed 2026-04-24 00:33:56 -04:00
1 parent f8eb57ad8c
commit 9ee1425a71
12 files changed
+433 -101

No files matched your search

+63 -3
View File
@@ -18,12 +18,12 @@ import {
type ActiveRunContext,
} from "../../src/main/agent-runtime/hook-handlers";
function seedCofounderRun(db: AppDatabase) {
function seedRun(db: AppDatabase, executionMode: "ai_ceo" | "ai_cofounder" = "ai_cofounder") {
const companyId = db.core.company.saveCompany({
name: "Gate Co",
description: "Cofounder runtime gate test",
status: "active",
executionMode: "ai_cofounder",
executionMode,
});
db.core.connectors.saveConnector({
id: "openai-codex",
@@ -87,7 +87,7 @@ describe("cofounder approval runtime gate", () => {
});
it("blocks destructive tools while a cofounder plan review is pending", () => {
const { companyId, agentId, taskId, runContext } = seedCofounderRun(db);
const { companyId, agentId, taskId, runContext } = seedRun(db, "ai_cofounder");
const approvalId = db.core.approvals.requestApproval({
companyId,
relatedTaskId: taskId,
@@ -117,4 +117,64 @@ describe("cofounder approval runtime gate", () => {
expect(result.block).toBe(true);
expect(result.reason).toContain("plan_review");
});
it("lets CEO-mode execution proceed past plan review policy", () => {
const { companyId, agentId, taskId, runContext } = seedRun(db, "ai_ceo");
db.core.approvals.requestApproval({
companyId,
relatedTaskId: taskId,
requestedByAgentId: agentId,
type: "plan_review",
payloadSummary: "Review plan",
impactSummary: "Human review requested for planning.",
payloadJson: "{}",
});
expect(db.core.approvals.getBlockingApproval(companyId, agentId, taskId)).toBeNull();
const result = handleBeforeToolCall(
{
db,
logger: { info: () => {}, warn: () => {}, error: () => {} },
},
runContext,
{
toolName: "bash",
toolCallId: "call-1",
args: { command: "touch allowed.txt" },
},
);
expect(result.block).toBe(false);
});
it("blocks operational approvals in CEO mode", () => {
const { companyId, agentId, taskId, runContext } = seedRun(db, "ai_ceo");
const approvalId = db.core.approvals.requestApproval({
companyId,
relatedTaskId: taskId,
requestedByAgentId: agentId,
type: "dangerous_command",
payloadSummary: "Approve destructive command",
impactSummary: "Host-level mutation requires explicit approval.",
payloadJson: "{}",
});
const blocking = db.core.approvals.getBlockingApproval(companyId, agentId, taskId);
expect(blocking?.id).toBe(approvalId);
const result = handleBeforeToolCall(
{
db,
logger: { info: () => {}, warn: () => {}, error: () => {} },
},
runContext,
{
toolName: "bash",
toolCallId: "call-1",
args: { command: "rm -rf dist" },
},
);
expect(result.block).toBe(true);
expect(result.reason).toContain("dangerous_command");
});
});