Tighten communication shell grammar

This commit is contained in:
ZacharyZhang-NY committed 2026-04-19 17:45:03 -04:00
1 parent caf2c7b337
commit b7870d966e
4 files changed
+50 -60

No files matched your search

@@ -55,27 +55,21 @@ impl AppRoot {
div() div()
.flex() .flex()
.flex_col() .flex_col()
.gap_6() .gap_5()
.child( .child(
div() div()
.flex()
.items_center()
.justify_between()
.child( .child(
div() div()
.child( .text_xl()
div() .text_color(theme::text_primary())
.text_xl() .child("Inbox"),
.text_color(theme::text_primary()) )
.child("Inbox"), .child(
) div()
.child( .mt(px(6.0))
div() .text_sm()
.mt(px(6.0)) .text_color(theme::text_muted())
.text_sm() .child(format!("{} items need attention", total_attention)),
.text_color(theme::text_muted())
.child(format!("{} items need attention", total_attention)),
),
), ),
) )
.child(inbox_filters( .child(inbox_filters(
@@ -86,47 +80,41 @@ impl AppRoot {
unread_messages.len(), unread_messages.len(),
cx, cx,
)) ))
.when(total_attention == 0, |container| { .child(
container.child( div()
div() .rounded_lg()
.min_h(px(260.0)) .border_1()
.flex() .border_color(theme::panel_border())
.items_center() .bg(theme::panel())
.justify_center() .when(total_attention == 0, |container| {
.rounded_lg() container.child(
.border_1()
.border_color(theme::panel_border())
.bg(theme::panel())
.child(
div() div()
.w(px(420.0)) .min_h(px(260.0))
.text_center() .flex()
.items_center()
.justify_center()
.child( .child(
div() div()
.text_xl() .w(px(420.0))
.text_color(theme::text_primary()) .text_center()
.child("All clear"), .child(
) div()
.child( .text_xl()
div() .text_color(theme::text_primary())
.mt(px(10.0)) .child("All clear"),
.text_base() )
.text_color(theme::text_muted()) .child(
.child("No approvals, reviews, failed runs, or unread internal messages need board attention right now."), div()
.mt(px(10.0))
.text_base()
.text_color(theme::text_muted())
.child("No approvals, reviews, failed runs, or unread internal messages need board attention right now."),
),
), ),
), )
) })
}) .when(!row_elements.is_empty(), |container| container.children(row_elements)),
.when(!row_elements.is_empty(), |container| { )
container.child(
div()
.rounded_lg()
.border_1()
.border_color(theme::panel_border())
.bg(theme::panel())
.children(row_elements),
)
})
} }
} }
@@ -204,7 +192,7 @@ impl InboxRow {
.flex_1() .flex_1()
.child( .child(
div() div()
.text_base() .text_sm()
.text_color(theme::text_primary()) .text_color(theme::text_primary())
.child(title), .child(title),
) )
@@ -324,7 +324,7 @@ fn render_message_sidebar<'a>(
"{} channels", "{} channels",
groups.iter().map(|group| group.rows.len()).sum::<usize>() groups.iter().map(|group| group.rows.len()).sum::<usize>()
)) ))
.child("message graph"), .child("live threads"),
) )
} }
@@ -355,7 +355,7 @@ fn render_message_header(
.mt(px(4.0)) .mt(px(4.0))
.text_sm() .text_sm()
.text_color(theme::text_muted()) .text_color(theme::text_muted())
.child(format!("{} visible items", visible_count)), .child(format!("{} visible messages", visible_count)),
), ),
) )
.child( .child(
@@ -434,7 +434,7 @@ fn render_message_inspector(selected: Option<&domain::AgentMessage>) -> impl Int
div() div()
.text_lg() .text_lg()
.text_color(theme::text_primary()) .text_color(theme::text_primary())
.child("Thread inspector"), .child("Conversation details"),
) )
.child(selected_message_card(selected)) .child(selected_message_card(selected))
.when_some(secondary_message(selected), |container, message| { .when_some(secondary_message(selected), |container, message| {
+2 -2
View File
@@ -275,8 +275,8 @@
"cargo test --workspace passes" "cargo test --workspace passes"
], ],
"priority": 20, "priority": 20,
"passes": false, "passes": true,
"notes": "Opened after strict current-directory-only source audit." "notes": "Passed: inbox and messages now use a tighter source-like communication shell with a simplified attention list panel, source-aligned count copy, and messages surfaces that remove off-source chrome like the message graph footer while preserving real channel/message interactions."
}, },
{ {
"id": "US-021", "id": "US-021",
+2
View File
@@ -26,3 +26,5 @@ Started: 2026-04-19
- Completed US-018 approvals remediation. Native approvals now use a grouped review-list grammar closer to the original PendingReviewList surface instead of parallel summary cards, while the lower pending-approval inspector still preserves the real approve/reject chain. - Completed US-018 approvals remediation. Native approvals now use a grouped review-list grammar closer to the original PendingReviewList surface instead of parallel summary cards, while the lower pending-approval inspector still preserves the real approve/reject chain.
- Completed US-019 document-center remediation. Native documents now follow a source-like operational shell with section header, prose list, work-product list, and a dedicated editor/inspector column while keeping the current native draft-save path intact. - Completed US-019 document-center remediation. Native documents now follow a source-like operational shell with section header, prose list, work-product list, and a dedicated editor/inspector column while keeping the current native draft-save path intact.
- Completed US-020 inbox/messages remediation. Native inbox now uses a tighter source-like attention-list shell, and messages now remove off-source chrome while preserving the channel rail, live thread header, stream, composer, and inspector interactions.