fix(browser): queue browser action dispatch failures

This commit is contained in:
ZacharyZhang-NY committed 2026-04-23 19:39:29 -04:00
1 parent 04c4059159
commit c26e7420fb
12 files changed
+251 -25

No files matched your search

@@ -62,7 +62,7 @@ export interface ApprovalHandlerDeps {
publishDomainChanged: () => void;
notify: (options: NotificationOptions) => void;
wakeAgentIfPossible: (agentId: string | null | undefined, companyId: string, trigger: string) => string | null;
dispatchBrowserAction: (actionId: string, companyId: string) => Promise<void>;
queueBrowserActionExecution: (actionId: string, companyId: string) => void;
isQuitting: () => boolean;
}
@@ -81,7 +81,7 @@ export function handleApprovalResolved(
decision: string,
): void {
if (deps.isQuitting()) return;
const { db, logger, publishDomainChanged, notify, wakeAgentIfPossible, dispatchBrowserAction } = deps;
const { db, logger, publishDomainChanged, notify, wakeAgentIfPossible, queueBrowserActionExecution } = deps;
const { dispatchAutomation, handleTaskStatusChange, runWorkflowPipeline, trackTimer } = callbacks;
const snapshot = db.projection.snapshot.listSnapshot();
@@ -259,9 +259,7 @@ export function handleApprovalResolved(
errorMessage: null,
});
publishDomainChanged();
void dispatchBrowserAction(browserAction.id, companyId).catch((error) => {
logger.error(`[browser] Failed to dispatch approved browser action ${browserAction.id}: ${error instanceof Error ? error.message : String(error)}`);
});
queueBrowserActionExecution(browserAction.id, companyId);
} else if (decision === "rejected") {
db.core.social.updateBrowserAction(browserAction.id, {
status: "cancelled",
@@ -301,9 +299,7 @@ export function handleApprovalResolved(
approvalId: approval.id,
});
publishDomainChanged();
void dispatchBrowserAction(actionId, approval.companyId).catch((error) => {
logger.error(`[automation] Failed to dispatch approved social post ${actionId}: ${error instanceof Error ? error.message : String(error)}`);
});
queueBrowserActionExecution(actionId, approval.companyId);
};
if (draft.scheduledAt) {
+1 -1
View File
@@ -13,7 +13,7 @@ export interface HandlerDeps {
publishDomainChanged: () => void;
notify: (options: NotificationOptions) => void;
wakeAgentIfPossible: (agentId: string | null | undefined, companyId: string, trigger: string) => string | null;
dispatchBrowserAction: (actionId: string, companyId: string) => Promise<void>;
queueBrowserActionExecution: (actionId: string, companyId: string) => void;
isQuitting: () => boolean;
}
+3 -3
View File
@@ -21,7 +21,7 @@ export function createAutomationService({
publishDomainChanged,
notify,
wakeAgentIfPossible,
dispatchBrowserAction,
queueBrowserActionExecution,
isQuitting,
}: AutomationDependencies) {
const activeAutomationExecutions = new Set<string>();
@@ -48,7 +48,7 @@ export function createAutomationService({
publishDomainChanged,
notify,
wakeAgentIfPossible,
dispatchBrowserAction,
queueBrowserActionExecution,
isQuitting,
};
@@ -58,7 +58,7 @@ export function createAutomationService({
publishDomainChanged,
notify,
wakeAgentIfPossible,
dispatchBrowserAction,
queueBrowserActionExecution,
isQuitting,
};
+1 -1
View File
@@ -47,7 +47,7 @@ export interface AutomationDependencies {
publishDomainChanged: () => void;
notify: (options: NotificationOptions) => void;
wakeAgentIfPossible: (agentId: string | null | undefined, companyId: string, trigger: string) => string | null;
dispatchBrowserAction: (actionId: string, companyId: string) => Promise<void>;
queueBrowserActionExecution: (actionId: string, companyId: string) => void;
isQuitting: () => boolean;
}