From d38b59255c22799d1368d3b6ff24206642fb5af2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Fri, 27 Mar 2026 00:26:25 -0400 Subject: [PATCH] test(07-01): add failing tests for task quality gate validation - validateTaskCreation: description length, heartbeat bypass, acceptance criteria - checkAcceptanceCriteria: keyword detection for 12 patterns - checkCapabilityMatch: capability overlap, skill fallback, graceful degradation --- tests/unit/task-quality-gates.test.ts | 203 ++++++++++++++++++++++++++ 1 file changed, 203 insertions(+) create mode 100644 tests/unit/task-quality-gates.test.ts diff --git a/tests/unit/task-quality-gates.test.ts b/tests/unit/task-quality-gates.test.ts new file mode 100644 index 00000000..da7787e9 --- /dev/null +++ b/tests/unit/task-quality-gates.test.ts @@ -0,0 +1,203 @@ +import { describe, expect, it } from "vitest"; +import { + validateTaskCreation, + checkAcceptanceCriteria, + checkCapabilityMatch, + ACCEPTANCE_CRITERIA_KEYWORDS, +} from "../../src/main/task-quality-gates"; +import type { TaskValidationResult } from "../../src/main/task-quality-gates"; + +// --- TASK-01: validateTaskCreation tests --- + +describe("validateTaskCreation", () => { + it("rejects description with 5 chars when not heartbeat", () => { + const result = validateTaskCreation({ title: "Fix bug", description: "Short" }, false); + expect(result.valid).toBe(false); + expect(result.errors.some(e => e.includes("at least 50 characters"))).toBe(true); + }); + + it("rejects description with exactly 49 chars when not heartbeat", () => { + const desc = "A".repeat(49); + const result = validateTaskCreation({ title: "Fix bug", description: desc }, false); + expect(result.valid).toBe(false); + expect(result.errors.some(e => e.includes("at least 50 characters"))).toBe(true); + }); + + it("accepts description with exactly 50 chars and acceptance keyword when not heartbeat", () => { + const desc = "Done when: the login page renders correctly." + "......"; + // Ensure exactly 50 chars + const padded = desc.slice(0, 50).padEnd(50, "."); + expect(padded.length).toBe(50); + // Must contain "done when" + const result = validateTaskCreation({ title: "Build login page", description: padded }, false); + expect(result.valid).toBe(true); + expect(result.errors).toHaveLength(0); + }); + + it("always returns valid for heartbeat tasks regardless of description", () => { + const result = validateTaskCreation({ title: "[Heartbeat] Check status", description: "Short" }, true); + expect(result.valid).toBe(true); + expect(result.errors).toHaveLength(0); + expect(result.warnings).toHaveLength(0); + }); + + it("rejects empty description when not heartbeat", () => { + const result = validateTaskCreation({ title: "Some task", description: "" }, false); + expect(result.valid).toBe(false); + expect(result.errors.some(e => e.includes("at least 50 characters"))).toBe(true); + }); + + it("rejects 60-char description without acceptance criteria keywords", () => { + const desc = "This is a description that is long enough to pass length check"; + expect(desc.length).toBeGreaterThanOrEqual(50); + const result = validateTaskCreation({ title: "A task", description: desc }, false); + expect(result.valid).toBe(false); + expect(result.errors.some(e => e.toLowerCase().includes("acceptance criteria"))).toBe(true); + }); + + it("returns valid=true when description has both length and acceptance criteria", () => { + const desc = "Implement the authentication flow for the login page. Done when: all tests pass and the form submits."; + expect(desc.length).toBeGreaterThanOrEqual(50); + const result = validateTaskCreation({ title: "Auth flow", description: desc }, false); + expect(result.valid).toBe(true); + expect(result.errors).toHaveLength(0); + }); + + it("includes current character count in length error message", () => { + const result = validateTaskCreation({ title: "Fix", description: "Short" }, false); + expect(result.errors.some(e => e.includes("currently 5"))).toBe(true); + }); +}); + +// --- TASK-02: checkAcceptanceCriteria tests --- + +describe("checkAcceptanceCriteria", () => { + it("detects 'done when' keyword", () => { + const result = checkAcceptanceCriteria("This task is done when all tests pass and deployment succeeds"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'Acceptance Criteria:' case insensitive", () => { + const result = checkAcceptanceCriteria("Acceptance Criteria: the form validates all fields correctly"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects '- [ ] first item' checkbox", () => { + const result = checkAcceptanceCriteria("Tasks to complete:\n- [ ] first item\n- [ ] second item"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects '- [x] completed item' checked checkbox", () => { + const result = checkAcceptanceCriteria("Progress:\n- [x] completed item\n- [ ] pending item"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'must:' keyword", () => { + const result = checkAcceptanceCriteria("The implementation must: handle all edge cases gracefully"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'requirements:' keyword", () => { + const result = checkAcceptanceCriteria("Technical requirements: use React 19 with TypeScript strict"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'success criteria' keyword", () => { + const result = checkAcceptanceCriteria("Success criteria for this task include passing all tests"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'deliverable:' keyword", () => { + const result = checkAcceptanceCriteria("Primary deliverable: a working API endpoint with docs"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'expected outcome' keyword", () => { + const result = checkAcceptanceCriteria("Expected outcome is a fully tested authentication module"); + expect(result.hasCriteria).toBe(true); + }); + + it("detects 'exit criteria' keyword", () => { + const result = checkAcceptanceCriteria("Exit criteria for this sprint includes shipped feature"); + expect(result.hasCriteria).toBe(true); + }); + + it("returns hasCriteria=false with suggestion for description with no keywords", () => { + const result = checkAcceptanceCriteria("Build a login page with email and password fields"); + expect(result.hasCriteria).toBe(false); + expect(result.suggestion).toContain("Done when:"); + }); +}); + +// --- Verify ACCEPTANCE_CRITERIA_KEYWORDS constant --- + +describe("ACCEPTANCE_CRITERIA_KEYWORDS", () => { + it("contains all required keywords", () => { + const required = [ + "acceptance criteria", + "done when", + "success criteria", + "definition of done", + "requirements:", + "must:", + "should:", + "- [ ]", + "- [x]", + "deliverable:", + "expected outcome", + "exit criteria", + ]; + for (const kw of required) { + expect(ACCEPTANCE_CRITERIA_KEYWORDS).toContain(kw); + } + }); +}); + +// --- TASK-03: checkCapabilityMatch tests --- + +describe("checkCapabilityMatch", () => { + function makeMockDb(agent: { name: string; capabilities: string }, skillAssignments: string[] = [], skills: Record = {}) { + return { + getAgent: (_id: string) => agent, + listAgentSkillAssignments: (_id: string) => skillAssignments, + getCompanySkill: (_companyId: string, skillId: string) => skills[skillId] ?? null, + }; + } + + it("returns matched=true when agent capabilities overlap with task", () => { + const db = makeMockDb({ name: "Frontend Dev", capabilities: "javascript react frontend" }); + const result = checkCapabilityMatch(db, "agent-1", "Build React login form with validation", "company-1"); + expect(result.matched).toBe(true); + }); + + it("returns matched=false with warning when capabilities do not overlap", () => { + const db = makeMockDb({ name: "Data Analyst", capabilities: "python data analysis" }); + const result = checkCapabilityMatch(db, "agent-1", "Build React login form with validation", "company-1"); + expect(result.matched).toBe(false); + expect(result.warning).toBeDefined(); + expect(result.warning).toContain("Data Analyst"); + }); + + it("returns matched=true when agent has empty capabilities and no skills (graceful degradation)", () => { + const db = makeMockDb({ name: "New Agent", capabilities: "" }); + const result = checkCapabilityMatch(db, "agent-1", "Build React login form", "company-1"); + expect(result.matched).toBe(true); + }); + + it("returns matched=true when agent has no capabilities but skill name overlaps with task", () => { + const db = makeMockDb( + { name: "Specialist", capabilities: "" }, + ["skill-1"], + { "skill-1": { name: "react development", description: "Building React components", slug: "react-dev" } }, + ); + const result = checkCapabilityMatch(db, "agent-1", "Build React component with hooks", "company-1"); + expect(result.matched).toBe(true); + }); + + it("returns matched=true when task description has no significant words", () => { + const db = makeMockDb({ name: "Agent", capabilities: "python" }); + const result = checkCapabilityMatch(db, "agent-1", "Do it", "company-1"); + // "do" and "it" are <= 3 chars, so taskWords is empty -> matched=true + expect(result.matched).toBe(true); + }); +});