Silence render-disposed spam, unbreak bundled skills, drop board wake
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
This commit is contained in:
1 parent
7a9a6779b0
commit
e74dafcd36
287 files changed
+59858
-10
No files matched your search
@@ -0,0 +1,60 @@
|
||||
# MVVM Architecture Setup
|
||||
|
||||
## MVVM Architecture Setup
|
||||
|
||||
```swift
|
||||
import Foundation
|
||||
import Combine
|
||||
|
||||
struct User: Codable, Identifiable {
|
||||
let id: UUID
|
||||
var name: String
|
||||
var email: String
|
||||
}
|
||||
|
||||
class UserViewModel: ObservableObject {
|
||||
@Published var user: User?
|
||||
@Published var isLoading = false
|
||||
@Published var errorMessage: String?
|
||||
|
||||
private let networkService: NetworkService
|
||||
|
||||
init(networkService: NetworkService = .shared) {
|
||||
self.networkService = networkService
|
||||
}
|
||||
|
||||
@MainActor
|
||||
func fetchUser(id: UUID) async {
|
||||
isLoading = true
|
||||
errorMessage = nil
|
||||
|
||||
do {
|
||||
user = try await networkService.fetch(User.self, from: "/users/\(id)")
|
||||
} catch {
|
||||
errorMessage = error.localizedDescription
|
||||
}
|
||||
|
||||
isLoading = false
|
||||
}
|
||||
|
||||
@MainActor
|
||||
func updateUser(_ userData: User) async {
|
||||
guard let user = user else { return }
|
||||
|
||||
do {
|
||||
self.user = try await networkService.put(
|
||||
User.self,
|
||||
to: "/users/\(user.id)",
|
||||
body: userData
|
||||
)
|
||||
} catch {
|
||||
errorMessage = "Failed to update user"
|
||||
}
|
||||
}
|
||||
|
||||
func logout() {
|
||||
user = nil
|
||||
errorMessage = nil
|
||||
}
|
||||
}
|
||||
```
|
||||
+99
@@ -0,0 +1,99 @@
|
||||
# Network Service with URLSession
|
||||
|
||||
## Network Service with URLSession
|
||||
|
||||
```swift
|
||||
class NetworkService {
|
||||
static let shared = NetworkService()
|
||||
|
||||
private let session: URLSession
|
||||
private let baseURL: URL
|
||||
|
||||
init(
|
||||
session: URLSession = .shared,
|
||||
baseURL: URL = URL(string: "https://api.example.com")!
|
||||
) {
|
||||
self.session = session
|
||||
self.baseURL = baseURL
|
||||
}
|
||||
|
||||
func fetch<T: Decodable>(
|
||||
_: T.Type,
|
||||
from endpoint: String
|
||||
) async throws -> T {
|
||||
let url = baseURL.appendingPathComponent(endpoint)
|
||||
var request = URLRequest(url: url)
|
||||
request.addAuthHeader()
|
||||
|
||||
let (data, response) = try await session.data(for: request)
|
||||
try validateResponse(response)
|
||||
|
||||
let decoder = JSONDecoder()
|
||||
decoder.dateDecodingStrategy = .iso8601
|
||||
return try decoder.decode(T.self, from: data)
|
||||
}
|
||||
|
||||
func put<T: Decodable, Body: Encodable>(
|
||||
_: T.Type,
|
||||
to endpoint: String,
|
||||
body: Body
|
||||
) async throws -> T {
|
||||
let url = baseURL.appendingPathComponent(endpoint)
|
||||
var request = URLRequest(url: url)
|
||||
request.httpMethod = "PUT"
|
||||
request.addAuthHeader()
|
||||
request.setValue("application/json", forHTTPHeaderField: "Content-Type")
|
||||
|
||||
let encoder = JSONEncoder()
|
||||
encoder.dateEncodingStrategy = .iso8601
|
||||
request.httpBody = try encoder.encode(body)
|
||||
|
||||
let (data, response) = try await session.data(for: request)
|
||||
try validateResponse(response)
|
||||
|
||||
let decoder = JSONDecoder()
|
||||
return try decoder.decode(T.self, from: data)
|
||||
}
|
||||
|
||||
private func validateResponse(_ response: URLResponse) throws {
|
||||
guard let httpResponse = response as? HTTPURLResponse else {
|
||||
throw NetworkError.invalidResponse
|
||||
}
|
||||
|
||||
switch httpResponse.statusCode {
|
||||
case 200...299:
|
||||
return
|
||||
case 401:
|
||||
throw NetworkError.unauthorized
|
||||
case 500...599:
|
||||
throw NetworkError.serverError
|
||||
default:
|
||||
throw NetworkError.unknown
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
enum NetworkError: LocalizedError {
|
||||
case invalidResponse
|
||||
case unauthorized
|
||||
case serverError
|
||||
case unknown
|
||||
|
||||
var errorDescription: String? {
|
||||
switch self {
|
||||
case .invalidResponse: return "Invalid response"
|
||||
case .unauthorized: return "Unauthorized"
|
||||
case .serverError: return "Server error"
|
||||
case .unknown: return "Unknown error"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
extension URLRequest {
|
||||
mutating func addAuthHeader() {
|
||||
if let token = KeychainManager.shared.getToken() {
|
||||
setValue("Bearer \(token)", forHTTPHeaderField: "Authorization")
|
||||
}
|
||||
}
|
||||
}
|
||||
```
|
||||
@@ -0,0 +1,112 @@
|
||||
# SwiftUI Views
|
||||
|
||||
## SwiftUI Views
|
||||
|
||||
```swift
|
||||
struct ContentView: View {
|
||||
@StateObject var userViewModel = UserViewModel()
|
||||
|
||||
var body: some View {
|
||||
TabView {
|
||||
HomeView()
|
||||
.tabItem { Label("Home", systemImage: "house") }
|
||||
|
||||
ProfileView(viewModel: userViewModel)
|
||||
.tabItem { Label("Profile", systemImage: "person") }
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
struct HomeView: View {
|
||||
@State var items: [Item] = []
|
||||
@State var loading = true
|
||||
|
||||
var body: some View {
|
||||
NavigationView {
|
||||
ZStack {
|
||||
if loading {
|
||||
ProgressView()
|
||||
} else {
|
||||
List(items) { item in
|
||||
NavigationLink(destination: ItemDetailView(item: item)) {
|
||||
VStack(alignment: .leading) {
|
||||
Text(item.title).font(.headline)
|
||||
Text(item.description).font(.subheadline).foregroundColor(.gray)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
.navigationTitle("Items")
|
||||
.task {
|
||||
await loadItems()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private func loadItems() async {
|
||||
do {
|
||||
items = try await NetworkService.shared.fetch([Item].self, from: "/items")
|
||||
} catch {
|
||||
print("Error: \(error)")
|
||||
}
|
||||
loading = false
|
||||
}
|
||||
}
|
||||
|
||||
struct ItemDetailView: View {
|
||||
let item: Item
|
||||
@Environment(\.dismiss) var dismiss
|
||||
|
||||
var body: some View {
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: 16) {
|
||||
Text(item.title).font(.title2).fontWeight(.bold)
|
||||
Text(item.description).font(.body)
|
||||
Text("Price: $\(String(format: "%.2f", item.price))")
|
||||
.font(.headline).foregroundColor(.blue)
|
||||
Spacer()
|
||||
}
|
||||
.padding()
|
||||
}
|
||||
.navigationBarTitleDisplayMode(.inline)
|
||||
}
|
||||
}
|
||||
|
||||
struct ProfileView: View {
|
||||
@ObservedObject var viewModel: UserViewModel
|
||||
@State var isLoading = true
|
||||
|
||||
var body: some View {
|
||||
NavigationView {
|
||||
ZStack {
|
||||
if viewModel.isLoading {
|
||||
ProgressView()
|
||||
} else if let user = viewModel.user {
|
||||
VStack(spacing: 20) {
|
||||
Text(user.name).font(.title).fontWeight(.bold)
|
||||
Text(user.email).font(.subheadline)
|
||||
Button("Logout") { viewModel.logout() }
|
||||
.foregroundColor(.red)
|
||||
Spacer()
|
||||
}
|
||||
.padding()
|
||||
} else {
|
||||
Text("No profile data")
|
||||
}
|
||||
}
|
||||
.navigationTitle("Profile")
|
||||
.task {
|
||||
await viewModel.fetchUser(id: UUID())
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
struct Item: Codable, Identifiable {
|
||||
let id: String
|
||||
let title: String
|
||||
let description: String
|
||||
let price: Double
|
||||
}
|
||||
```
|
||||
Reference in new issue
Block a user