test(connector-id): migrate fixtures and assertions to pi-mono ids
Replaces legacy adapter ids (codex_local / claude_local / gemini_local / claude_compatible) across ~42 test files with pi-mono equivalents: - codex_local → openai-codex - claude_local → claude-pro - gemini_local → gemini-cli - claude_compatible → anthropic Hand-rewrites where fixture semantics changed: - connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro first for code/content/management; google first for research) - connector-model-policy: getModels(provider) from pi-ai instead of the deleted adapter.module.models array - session-management + edge-case-session: adapter exemption removed; rotation now uniform under pi-mono - ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic - connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro) - onboarding-model-pool: listProviderModels(provider) helper; label text changed to "ChatGPT Plus/Pro (Codex)" - database integration: added vault insecure-fallback env + electron mock - command-paths: uses new @main/connector-helpers normalizeCommandValue - pi-mono-migrations: added `as string` casts for 3 negative-existence assertions verifying legacy ids were removed Drops: - pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty) - obsolete CONNECTOR_STRENGTHS import; .module.models probing Verification: - pnpm typecheck → 0 errors - pnpm lint → 0 errors / 0 warnings - pnpm build:verify → 0 errors / 0 warnings - pnpm test:unit → 508/508 pass - pnpm test:integration → 96/96 pass - All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty) - pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
This commit is contained in:
1 parent
4de9cd0339
commit
e94939a562
80 files changed
+2210
-413
No files matched your search
@@ -1,11 +1,14 @@
|
||||
/**
|
||||
* Role-classification helpers used across prompt construction and skill
|
||||
* auto-assignment. Keeping a single keyword list here prevents drift
|
||||
* between system-prompt.ts and automation-skills.ts.
|
||||
* auto-assignment. Historical keyword match remains here for backfill and
|
||||
* UI-free fallback; typed `agent.roleLevel` is the source of truth once the
|
||||
* column is populated.
|
||||
*
|
||||
* Matching uses word-boundary tokenization instead of substring search,
|
||||
* so "lead" does not match "cleaner" or "leaderboard".
|
||||
*/
|
||||
import type { AgentRoleLevel } from "@shared/types";
|
||||
import { isLeadershipLevel } from "@shared/types";
|
||||
|
||||
export const LEADERSHIP_ROLE_KEYWORDS = [
|
||||
"chief",
|
||||
@@ -31,3 +34,26 @@ export function roleMatchesLeadershipKeywords(role: string, title?: string | nul
|
||||
const tokens = new Set(tokenize(`${role} ${title ?? ""}`));
|
||||
return LEADERSHIP_ROLE_KEYWORDS.some((keyword) => tokens.has(keyword));
|
||||
}
|
||||
|
||||
/**
|
||||
* One-shot inference from free-text role/title strings. Used when creating or
|
||||
* backfilling an agent so `roleLevel` can be stored once and re-read cheaply.
|
||||
* The most specific token wins; order here is most-senior → least.
|
||||
*/
|
||||
export function inferRoleLevel(role: string, title?: string | null): AgentRoleLevel {
|
||||
const tokens = new Set(tokenize(`${role} ${title ?? ""}`));
|
||||
if (tokens.has("ceo") || tokens.has("cto") || tokens.has("cmo") || tokens.has("coo") || tokens.has("cfo") || tokens.has("chief")) {
|
||||
return "c_suite";
|
||||
}
|
||||
if (tokens.has("vp") || tokens.has("vice") || tokens.has("president")) return "vp";
|
||||
if (tokens.has("director") || tokens.has("head")) return "director";
|
||||
if (tokens.has("manager")) return "manager";
|
||||
if (tokens.has("lead")) return "lead";
|
||||
return "ic";
|
||||
}
|
||||
|
||||
/** Canonical leadership check: typed enum wins, fallback to keyword match. */
|
||||
export function agentIsLeader(agent: { roleLevel?: AgentRoleLevel | null; role: string; title: string | null }): boolean {
|
||||
if (agent.roleLevel) return isLeadershipLevel(agent.roleLevel);
|
||||
return roleMatchesLeadershipKeywords(agent.role, agent.title);
|
||||
}
|
||||
Reference in new issue
Block a user