test(connector-id): migrate fixtures and assertions to pi-mono ids

Replaces legacy adapter ids (codex_local / claude_local / gemini_local /
claude_compatible) across ~42 test files with pi-mono equivalents:
- codex_local → openai-codex
- claude_local → claude-pro
- gemini_local → gemini-cli
- claude_compatible → anthropic

Hand-rewrites where fixture semantics changed:
- connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro
  first for code/content/management; google first for research)
- connector-model-policy: getModels(provider) from pi-ai instead of the
  deleted adapter.module.models array
- session-management + edge-case-session: adapter exemption removed;
  rotation now uniform under pi-mono
- ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic
- connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro)
- onboarding-model-pool: listProviderModels(provider) helper; label text
  changed to "ChatGPT Plus/Pro (Codex)"
- database integration: added vault insecure-fallback env + electron mock
- command-paths: uses new @main/connector-helpers normalizeCommandValue
- pi-mono-migrations: added `as string` casts for 3 negative-existence
  assertions verifying legacy ids were removed

Drops:
- pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty)
- obsolete CONNECTOR_STRENGTHS import; .module.models probing

Verification:
- pnpm typecheck → 0 errors
- pnpm lint → 0 errors / 0 warnings
- pnpm build:verify → 0 errors / 0 warnings
- pnpm test:unit → 508/508 pass
- pnpm test:integration → 96/96 pass
- All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty)
- pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 02:36:53 -04:00
1 parent 4de9cd0339
commit e94939a562
80 files changed
+2210 -413

No files matched your search

+20 -6
View File
@@ -1,7 +1,21 @@
import { mkdtemp, rm } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { afterEach, describe, expect, it } from "vitest";
import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
beforeAll(() => {
process.env.AGENTCOMPANY_ALLOW_INSECURE_VAULT = "true";
});
vi.mock("electron", () => ({
safeStorage: {
isEncryptionAvailable: () => false,
getSelectedStorageBackend: () => "basic_text",
encryptString: (value: string) => Buffer.from(value, "utf8"),
decryptString: (value: Buffer) => value.toString("utf8"),
},
}));
import { AppDatabase } from "../../src/main/database";
const tempDirs: string[] = [];
@@ -45,7 +59,7 @@ describe("AppDatabase", () => {
title: "Lead agent",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Operate the company",
@@ -89,7 +103,7 @@ describe("AppDatabase", () => {
});
db.saveConnector({
id: "codex_local",
id: "openai-codex",
command: "codex",
model: null,
envBindingText: "OPENAI_API_KEY=vault-openai",
@@ -105,7 +119,7 @@ describe("AppDatabase", () => {
taskId,
agentId,
workspaceId,
connectorId: "codex_local",
connectorId: "openai-codex",
});
await db.appendRunLog(run.id, "stdout", "hello from run\n");
@@ -190,7 +204,7 @@ describe("AppDatabase", () => {
title: "",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: alphaWorkspaceId,
model: null,
capabilities: "Lead alpha",
@@ -204,7 +218,7 @@ describe("AppDatabase", () => {
title: "",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: betaWorkspaceId,
model: null,
capabilities: "Lead beta",