test(connector-id): migrate fixtures and assertions to pi-mono ids

Replaces legacy adapter ids (codex_local / claude_local / gemini_local /
claude_compatible) across ~42 test files with pi-mono equivalents:
- codex_local → openai-codex
- claude_local → claude-pro
- gemini_local → gemini-cli
- claude_compatible → anthropic

Hand-rewrites where fixture semantics changed:
- connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro
  first for code/content/management; google first for research)
- connector-model-policy: getModels(provider) from pi-ai instead of the
  deleted adapter.module.models array
- session-management + edge-case-session: adapter exemption removed;
  rotation now uniform under pi-mono
- ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic
- connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro)
- onboarding-model-pool: listProviderModels(provider) helper; label text
  changed to "ChatGPT Plus/Pro (Codex)"
- database integration: added vault insecure-fallback env + electron mock
- command-paths: uses new @main/connector-helpers normalizeCommandValue
- pi-mono-migrations: added `as string` casts for 3 negative-existence
  assertions verifying legacy ids were removed

Drops:
- pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty)
- obsolete CONNECTOR_STRENGTHS import; .module.models probing

Verification:
- pnpm typecheck → 0 errors
- pnpm lint → 0 errors / 0 warnings
- pnpm build:verify → 0 errors / 0 warnings
- pnpm test:unit → 508/508 pass
- pnpm test:integration → 96/96 pass
- All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty)
- pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 02:36:53 -04:00
1 parent 4de9cd0339
commit e94939a562
80 files changed
+2210 -413

No files matched your search

+7 -35
View File
@@ -1,15 +1,10 @@
import { describe, expect, it } from "vitest";
import { buildWindowsSpawnTarget, normalizeCommandValue } from "@agentcompany/adapter-utils/server-utils";
import { commandLooksLike } from "@agentcompany/adapter-utils/test-utils";
import { normalizeCommandValue } from "@main/connector-helpers";
describe("command path normalization", () => {
it("removes surrounding quotes from absolute executable paths", () => {
expect(normalizeCommandValue('"C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe"')).toBe(
"C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe",
);
expect(normalizeCommandValue("'C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe'")).toBe(
"C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe",
);
it("trims surrounding whitespace from command values", () => {
expect(normalizeCommandValue(" claude ")).toBe("claude");
expect(normalizeCommandValue("\tcodex\n")).toBe("codex");
});
it("keeps bare commands unchanged", () => {
@@ -17,31 +12,8 @@ describe("command path normalization", () => {
expect(normalizeCommandValue("codex")).toBe("codex");
});
it("matches quoted commands against connector executables", () => {
expect(commandLooksLike('"C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe"', "claude")).toBe(true);
expect(commandLooksLike("'C:\\Users\\First Last\\AppData\\Local\\bin\\codex.exe'", "codex")).toBe(true);
});
it("spawns direct exe paths on Windows instead of wrapping them through cmd.exe", () => {
const target = buildWindowsSpawnTarget(
"C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe",
["--version"],
"cmd.exe",
);
expect(target).toEqual({
command: "C:\\Users\\First Last\\AppData\\Local\\bin\\claude.exe",
args: ["--version"],
});
});
it("still wraps shell scripts through cmd.exe on Windows", () => {
const target = buildWindowsSpawnTarget(
"C:\\Tools\\agentcompany\\launch.cmd",
["--version"],
"cmd.exe",
);
expect(target.command).toBe("cmd.exe");
expect(target.args[0]).toBe("/d");
expect(target.args.at(-1)).toContain("launch.cmd");
it("normalizes null and undefined to empty string", () => {
expect(normalizeCommandValue(null)).toBe("");
expect(normalizeCommandValue(undefined)).toBe("");
});
});