test(connector-id): migrate fixtures and assertions to pi-mono ids

Replaces legacy adapter ids (codex_local / claude_local / gemini_local /
claude_compatible) across ~42 test files with pi-mono equivalents:
- codex_local → openai-codex
- claude_local → claude-pro
- gemini_local → gemini-cli
- claude_compatible → anthropic

Hand-rewrites where fixture semantics changed:
- connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro
  first for code/content/management; google first for research)
- connector-model-policy: getModels(provider) from pi-ai instead of the
  deleted adapter.module.models array
- session-management + edge-case-session: adapter exemption removed;
  rotation now uniform under pi-mono
- ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic
- connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro)
- onboarding-model-pool: listProviderModels(provider) helper; label text
  changed to "ChatGPT Plus/Pro (Codex)"
- database integration: added vault insecure-fallback env + electron mock
- command-paths: uses new @main/connector-helpers normalizeCommandValue
- pi-mono-migrations: added `as string` casts for 3 negative-existence
  assertions verifying legacy ids were removed

Drops:
- pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty)
- obsolete CONNECTOR_STRENGTHS import; .module.models probing

Verification:
- pnpm typecheck → 0 errors
- pnpm lint → 0 errors / 0 warnings
- pnpm build:verify → 0 errors / 0 warnings
- pnpm test:unit → 508/508 pass
- pnpm test:integration → 96/96 pass
- All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty)
- pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 02:36:53 -04:00
1 parent 4de9cd0339
commit e94939a562
80 files changed
+2210 -413

No files matched your search

+16 -16
View File
@@ -54,7 +54,7 @@ describe("AppDatabase", () => {
title: "Lead operator",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId,
model: "gpt-5",
capabilities: "Directs execution",
@@ -95,7 +95,7 @@ describe("AppDatabase", () => {
value: "sk-test-secret",
});
db.saveConnector({
id: "codex_local",
id: "openai-codex",
command: "codex",
model: "gpt-5",
envBindingText: "OPENAI_API_KEY=vault-openai",
@@ -189,14 +189,14 @@ describe("AppDatabase", () => {
title: "Lead",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Leads",
budgetMonthlyUsd: 100,
});
db.saveConnector({
id: "codex_local",
id: "openai-codex",
command: "codex",
model: "gpt-5",
envBindingText: "",
@@ -217,14 +217,14 @@ describe("AppDatabase", () => {
taskId,
agentId: leadId,
workspaceId,
connectorId: "codex_local",
connectorId: "openai-codex",
});
const { id: runId2 } = db.createRun({
companyId,
taskId,
agentId: leadId,
workspaceId,
connectorId: "codex_local",
connectorId: "openai-codex",
});
expect(db.checkoutTask(taskId, runId1)).toBe(true);
@@ -255,7 +255,7 @@ describe("AppDatabase", () => {
title: "Budget Owner",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Ships work",
@@ -276,7 +276,7 @@ describe("AppDatabase", () => {
taskId,
agentId,
workspaceId,
connectorId: "codex_local",
connectorId: "openai-codex",
});
const outcome = db.finishRun({
@@ -310,7 +310,7 @@ describe("AppDatabase", () => {
title: "Manager",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "Manages",
@@ -323,7 +323,7 @@ describe("AppDatabase", () => {
title: "Pending Hire",
status: "pending_approval",
reportsTo: managerId,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "Will execute after approval",
@@ -362,7 +362,7 @@ describe("AppDatabase", () => {
title: "Active",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "Ships",
@@ -375,7 +375,7 @@ describe("AppDatabase", () => {
title: "Pending",
status: "pending_approval",
reportsTo: activeAgentId,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "Waiting",
@@ -479,7 +479,7 @@ describe("AppDatabase", () => {
title: "Test",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: wsId,
model: null,
capabilities: "test",
@@ -495,7 +495,7 @@ describe("AppDatabase", () => {
status: "todo",
});
const run = db.createRun({ companyId, taskId, agentId, workspaceId: wsId, connectorId: "codex_local" });
const run = db.createRun({ companyId, taskId, agentId, workspaceId: wsId, connectorId: "openai-codex" });
await db.appendRunLog(run.id, "stdout", "test log line\n");
// Finish the run with a very old timestamp
@@ -544,7 +544,7 @@ describe("AppDatabase", () => {
title: "CEO",
status: "active",
reportsTo: null,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "manage",
@@ -557,7 +557,7 @@ describe("AppDatabase", () => {
title: "IC",
status: "pending_approval",
reportsTo: managerId,
connectorId: "codex_local",
connectorId: "openai-codex",
workspaceId: null,
model: null,
capabilities: "code",