test(connector-id): migrate fixtures and assertions to pi-mono ids

Replaces legacy adapter ids (codex_local / claude_local / gemini_local /
claude_compatible) across ~42 test files with pi-mono equivalents:
- codex_local → openai-codex
- claude_local → claude-pro
- gemini_local → gemini-cli
- claude_compatible → anthropic

Hand-rewrites where fixture semantics changed:
- connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro
  first for code/content/management; google first for research)
- connector-model-policy: getModels(provider) from pi-ai instead of the
  deleted adapter.module.models array
- session-management + edge-case-session: adapter exemption removed;
  rotation now uniform under pi-mono
- ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic
- connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro)
- onboarding-model-pool: listProviderModels(provider) helper; label text
  changed to "ChatGPT Plus/Pro (Codex)"
- database integration: added vault insecure-fallback env + electron mock
- command-paths: uses new @main/connector-helpers normalizeCommandValue
- pi-mono-migrations: added `as string` casts for 3 negative-existence
  assertions verifying legacy ids were removed

Drops:
- pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty)
- obsolete CONNECTOR_STRENGTHS import; .module.models probing

Verification:
- pnpm typecheck → 0 errors
- pnpm lint → 0 errors / 0 warnings
- pnpm build:verify → 0 errors / 0 warnings
- pnpm test:unit → 508/508 pass
- pnpm test:integration → 96/96 pass
- All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty)
- pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
This commit is contained in:
ZacharyZhang-NY committed 2026-04-17 02:36:53 -04:00
1 parent 4de9cd0339
commit e94939a562
80 files changed
+2210 -413

No files matched your search

+14 -14
View File
@@ -37,7 +37,7 @@ function createTestCompany(db: AppDatabase): string {
function createTestConnector(db: AppDatabase): void {
db.saveConnector({
id: "gemini_local",
id: "gemini-cli",
command: "gemini",
model: "gemini-pro",
envBindingText: "",
@@ -64,7 +64,7 @@ function createTestAgent(db: AppDatabase, companyId: string, workspaceId: string
title: name,
status: "active",
reportsTo: null,
connectorId: "gemini_local",
connectorId: "gemini-cli",
workspaceId,
model: null,
capabilities: "Executes tasks",
@@ -116,14 +116,14 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const { id: runIdB } = db.createRun({
companyId,
taskId,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
// Agent-A claims first
@@ -152,14 +152,14 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId: taskId1,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const { id: runIdB1 } = db.createRun({
companyId,
taskId: taskId1,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
// Agent-A wins first task
@@ -174,7 +174,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId: taskId2,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const resultB2 = db.checkoutTask(taskId2, runIdB2);
expect(resultB2).toBe(true);
@@ -198,7 +198,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
expect(db.checkoutTask(taskId, runIdA)).toBe(true);
@@ -208,7 +208,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const result = db.checkoutTask(taskId, runIdB);
expect(result).toBe(false);
@@ -231,7 +231,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
expect(db.checkoutTask(taskId, runIdA)).toBe(true);
@@ -252,7 +252,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const result = db.checkoutTask(taskId, runIdB);
expect(result).toBe(false);
@@ -270,7 +270,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
expect(db.checkoutTask(taskId, runIdA)).toBe(true);
@@ -306,7 +306,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentA,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
expect(db.checkoutTask(taskId, runIdA)).toBe(true);
@@ -328,7 +328,7 @@ describe("Edge Case: Concurrent Task Checkout (D-05.1)", () => {
taskId,
agentId: agentB,
workspaceId,
connectorId: "gemini_local",
connectorId: "gemini-cli",
});
const result = db.checkoutTask(taskId, runIdB);
expect(result).toBe(true);