refactor(runtime): centralize lifecycle constants
This commit is contained in:
1 parent
e540cbb2a6
commit
fa006524c2
6 files changed
+49
-14
No files matched your search
@@ -0,0 +1,18 @@
|
|||||||
|
/**
|
||||||
|
* Task and workspace locks are considered stale after 15 minutes. The window
|
||||||
|
* covers heartbeat cadence, worst-case model/tool round trips, and shutdown
|
||||||
|
* recovery margin while still releasing abandoned work within one operator
|
||||||
|
* session.
|
||||||
|
*/
|
||||||
|
export const STALE_LOCK_TIMEOUT_MS = 15 * 60 * 1000;
|
||||||
|
|
||||||
|
export const DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS = {
|
||||||
|
/** Five attempts cover transient filesystem/indexing failures without hiding a broken hook. */
|
||||||
|
maxAttempts: 5,
|
||||||
|
/** Document hooks are local metadata side effects; 60s separates a dead handler from a slow one. */
|
||||||
|
staleRunningMs: 60_000,
|
||||||
|
/** Keeps a burst of document hooks efficient while bounding one sweep's synchronous work. */
|
||||||
|
batchSize: 32,
|
||||||
|
/** Recovers crash leftovers quickly without turning idle profiles into polling loops. */
|
||||||
|
sweepIntervalMs: 15_000,
|
||||||
|
} as const;
|
||||||
@@ -32,12 +32,11 @@ import { MODEL_CAPABILITY_SEED } from "./model-capability-seed";
|
|||||||
import { initializeDatabase } from "./database/schema";
|
import { initializeDatabase } from "./database/schema";
|
||||||
import { SecretVault } from "./vault";
|
import { SecretVault } from "./vault";
|
||||||
import type { AgentStatus, ConnectorId, ProfileSnapshot, RunStatus } from "@shared/types";
|
import type { AgentStatus, ConnectorId, ProfileSnapshot, RunStatus } from "@shared/types";
|
||||||
|
import { STALE_LOCK_TIMEOUT_MS } from "./constants";
|
||||||
|
|
||||||
function nowIso() {
|
function nowIso() {
|
||||||
return new Date().toISOString();
|
return new Date().toISOString();
|
||||||
}
|
}
|
||||||
export const STALE_LOCK_TIMEOUT_MS = 15 * 60 * 1000;
|
|
||||||
|
|
||||||
export class AppDatabaseBase {
|
export class AppDatabaseBase {
|
||||||
readonly profileDir: string;
|
readonly profileDir: string;
|
||||||
readonly dbPath: string;
|
readonly dbPath: string;
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
import type { SQLInputValue } from "node:sqlite";
|
import type { SQLInputValue } from "node:sqlite";
|
||||||
import { AppDatabaseBase } from "./database-base";
|
import { AppDatabaseBase } from "./database-base";
|
||||||
|
|
||||||
export { STALE_LOCK_TIMEOUT_MS } from "./database-base";
|
export { STALE_LOCK_TIMEOUT_MS } from "./constants";
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* AppDatabase — concrete persistence surface wired to the twenty-six
|
* AppDatabase — concrete persistence surface wired to the twenty-six
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import log from "electron-log/main.js";
|
import log from "electron-log/main.js";
|
||||||
|
import { STALE_LOCK_TIMEOUT_MS } from "../../constants";
|
||||||
import type { Migration, MigrationDeps } from "./types";
|
import type { Migration, MigrationDeps } from "./types";
|
||||||
import { columnExists, nowIso, tableExists } from "./types";
|
import { columnExists, nowIso, tableExists } from "./types";
|
||||||
|
|
||||||
@@ -42,8 +43,6 @@ import { columnExists, nowIso, tableExists } from "./types";
|
|||||||
* already orphaned pre-migration.
|
* already orphaned pre-migration.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
const STALE_LOCK_TIMEOUT_MS = 15 * 60 * 1000;
|
|
||||||
|
|
||||||
export function createMigrationsV50V50(deps: MigrationDeps): Migration[] {
|
export function createMigrationsV50V50(deps: MigrationDeps): Migration[] {
|
||||||
const { db } = deps;
|
const { db } = deps;
|
||||||
return [
|
return [
|
||||||
|
|||||||
@@ -24,6 +24,7 @@
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
import type { AppDatabase } from "./database";
|
import type { AppDatabase } from "./database";
|
||||||
|
import { DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS } from "./constants";
|
||||||
import type { DocumentLifecycleEventRow } from "./database/document-lifecycle-events";
|
import type { DocumentLifecycleEventRow } from "./database/document-lifecycle-events";
|
||||||
|
|
||||||
export interface LifecycleHookContext {
|
export interface LifecycleHookContext {
|
||||||
@@ -59,19 +60,11 @@ export interface LifecycleProcessorOptions {
|
|||||||
sweepIntervalMs: number;
|
sweepIntervalMs: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
const DEFAULT_MAX_ATTEMPTS = 5;
|
|
||||||
const DEFAULT_STALE_RUNNING_MS = 60_000;
|
|
||||||
const DEFAULT_BATCH_SIZE = 32;
|
|
||||||
const DEFAULT_SWEEP_INTERVAL_MS = 15_000;
|
|
||||||
|
|
||||||
export function makeLifecycleProcessorOptions(
|
export function makeLifecycleProcessorOptions(
|
||||||
overrides: Partial<LifecycleProcessorOptions> & Pick<LifecycleProcessorOptions, "db" | "logger">,
|
overrides: Partial<LifecycleProcessorOptions> & Pick<LifecycleProcessorOptions, "db" | "logger">,
|
||||||
): LifecycleProcessorOptions {
|
): LifecycleProcessorOptions {
|
||||||
return {
|
return {
|
||||||
maxAttempts: DEFAULT_MAX_ATTEMPTS,
|
...DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS,
|
||||||
staleRunningMs: DEFAULT_STALE_RUNNING_MS,
|
|
||||||
batchSize: DEFAULT_BATCH_SIZE,
|
|
||||||
sweepIntervalMs: DEFAULT_SWEEP_INTERVAL_MS,
|
|
||||||
...overrides,
|
...overrides,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,26 @@
|
|||||||
|
import { describe, expect, it } from "vitest";
|
||||||
|
import type { AppDatabase } from "../../src/main/database";
|
||||||
|
import {
|
||||||
|
DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS,
|
||||||
|
STALE_LOCK_TIMEOUT_MS,
|
||||||
|
} from "../../src/main/constants";
|
||||||
|
import { makeLifecycleProcessorOptions } from "../../src/main/document-lifecycle-processor";
|
||||||
|
|
||||||
|
describe("runtime constants", () => {
|
||||||
|
it("uses one stale lock timeout for task lease recovery", () => {
|
||||||
|
expect(STALE_LOCK_TIMEOUT_MS).toBe(15 * 60 * 1000);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("uses shared document lifecycle processor defaults", () => {
|
||||||
|
const logger = { info: () => undefined, warn: () => undefined, error: () => undefined };
|
||||||
|
const options = makeLifecycleProcessorOptions({
|
||||||
|
db: {} as AppDatabase,
|
||||||
|
logger,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(options.maxAttempts).toBe(DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS.maxAttempts);
|
||||||
|
expect(options.staleRunningMs).toBe(DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS.staleRunningMs);
|
||||||
|
expect(options.batchSize).toBe(DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS.batchSize);
|
||||||
|
expect(options.sweepIntervalMs).toBe(DOCUMENT_LIFECYCLE_PROCESSOR_DEFAULTS.sweepIntervalMs);
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in new issue
Block a user