Q131: remove review agents and eval suites whose pass only counted configuration rows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

src/shared/commands/governance.ts

@@ -3,7 +3,6 @@ import type {
   ComplianceSubjectType,
   LegalHoldEntityType,
   RetentionFreezeScopeType,
-  SdlcReviewTargetType,
 } from "../domain";
 
 export interface CreateMigrationReportInput {
@@ -85,18 +84,6 @@ export interface RunChaosDrillInput {
   drillId: string;
 }
 
-export interface RunSdlcReviewInput {
-  orgId: string;
-  reviewAgentId: string;
-  targetType: SdlcReviewTargetType;
-  targetRef: string;
-}
-
-export interface RunEvalSuiteInput {
-  orgId: string;
-  suiteId: string;
-}
-
 export interface SetPrBotGateInput {
   orgId: string;
   gateId: string;

src/shared/desktop-api.ts

@@ -66,8 +66,6 @@ import type {
   LaunchSocialLoginInput,
   ResolveMigrationReconciliationInput,
   RunChaosDrillInput,
-  RunEvalSuiteInput,
-  RunSdlcReviewInput,
   RunTaskInput,
   RevokeProviderCredentialInput,
   SaveProviderCredentialInput,
@@ -192,8 +190,6 @@ export interface DesktopApi {
   resolveMigrationReconciliation(input: ResolveMigrationReconciliationInput): Promise<DesktopResult<AppSnapshot>>;
   setFeatureFlag(input: SetFeatureFlagInput): Promise<DesktopResult<AppSnapshot>>;
   runChaosDrill(input: RunChaosDrillInput): Promise<DesktopResult<AppSnapshot>>;
-  runSdlcReview(input: RunSdlcReviewInput): Promise<DesktopResult<AppSnapshot>>;
-  runEvalSuite(input: RunEvalSuiteInput): Promise<DesktopResult<AppSnapshot>>;
   setPrBotGate(input: SetPrBotGateInput): Promise<DesktopResult<AppSnapshot>>;
   createComplianceExport(input: CreateComplianceExportInput): Promise<DesktopResult<AppSnapshot>>;
   createAuditReplay(input: CreateAuditReplayInput): Promise<DesktopResult<AppSnapshot>>;

src/shared/domain.ts

@@ -11,7 +11,7 @@ export { PROVIDER_DATA_POLICY, PROVIDER_EXECUTION_MODE, type ProviderDataPolicy,
 export { PROVIDER_REQUEST_STATE, type ProviderRequestRecord, type ProviderRequestState, type ProviderStreamRendererEvent } from "./provider-request-domain";
 export type { ProviderRateLimitObservationRecord, ProviderRateLimitStateRecord } from "./provider-runtime-domain";
 export type { MigrationCutoverEventRecord, MigrationReconciliationItemRecord, RollbackSnapshotRecord } from "./rollback-domain";
-export { EVAL_SUITE_KEY, PR_BOT_GATE_KEY, SDLC_REVIEW_AGENT_KEY, SDLC_REVIEW_TARGET_TYPE, SDLC_RUN_STATE, type EvalCaseRecord, type EvalRunRecord, type EvalSuiteKey, type EvalSuiteRecord, type PrBotGateKey, type PrBotGateRecord, type SdlcReviewAgentKey, type SdlcReviewAgentRecord, type SdlcReviewRunRecord, type SdlcReviewTargetType, type SdlcRunState } from "./sdlc-domain";
+export { PR_BOT_GATE_KEY, type PrBotGateKey, type PrBotGateRecord } from "./sdlc-domain";
 export { SEARCH_ENTITY_TYPES, type SearchEntityType, type SearchResultRecord } from "./search-domain";
 export type { BrowserActionPolicyRecord, BrowserActionRecord, BrowserSessionContainerRecord, SocialAccountGrantRecord, SocialAccountRecord, SocialApprovalRouteRecord, SocialAuditRecord } from "./social-domain";
 export type { AppSnapshot, UiLanguage, UiPreferences, UiTheme } from "./snapshot-domain";

src/shared/ipc.ts

@@ -54,8 +54,6 @@ export const IPC_CHANNELS = {
   resolveMigrationReconciliation: "agentcompany:resolve-migration-reconciliation",
   setFeatureFlag: "agentcompany:set-feature-flag",
   runChaosDrill: "agentcompany:run-chaos-drill",
-  runSdlcReview: "agentcompany:run-sdlc-review",
-  runEvalSuite: "agentcompany:run-eval-suite",
   setPrBotGate: "agentcompany:set-pr-bot-gate",
   createComplianceExport: "agentcompany:create-compliance-export",
   createAuditReplay: "agentcompany:create-audit-replay",

src/shared/sdlc-domain.ts

@@ -1,14 +1,5 @@
 type ValueOf<T> = T[keyof T];
 
-export const SDLC_REVIEW_AGENT_KEY = {
-  CODE_REVIEWER: "code_reviewer",
-  MIGRATION_REVIEWER: "migration_reviewer",
-  POLICY_REVIEWER: "policy_reviewer",
-} as const;
-
-export const SDLC_REVIEW_TARGET_TYPE = { WORKSPACE: "workspace", MIGRATION: "migration", POLICY: "policy" } as const;
-export const EVAL_SUITE_KEY = { CONTRACT: "contract", INTEGRATION: "integration", REPLAY: "replay" } as const;
-export const SDLC_RUN_STATE = { PASSED: "passed", FAILED: "failed" } as const;
 export const PR_BOT_GATE_KEY = {
   STATIC_CHECKS: "static_checks",
   MIGRATION_DIFF: "migration_diff",
@@ -16,33 +7,8 @@ export const PR_BOT_GATE_KEY = {
   HUMAN_APPROVAL: "human_approval",
 } as const;
 
-export type SdlcReviewAgentKey = ValueOf<typeof SDLC_REVIEW_AGENT_KEY>;
-export type SdlcReviewTargetType = ValueOf<typeof SDLC_REVIEW_TARGET_TYPE>;
-export type EvalSuiteKey = ValueOf<typeof EVAL_SUITE_KEY>;
-export type SdlcRunState = ValueOf<typeof SDLC_RUN_STATE>;
 export type PrBotGateKey = ValueOf<typeof PR_BOT_GATE_KEY>;
 
-export interface SdlcReviewAgentRecord {
-  id: string; orgId: string; key: SdlcReviewAgentKey; label: string; specialty: string; enabled: boolean; createdAt: string; updatedAt: string;
-}
-
-export interface SdlcReviewRunRecord {
-  id: string; orgId: string; reviewAgentId: string; targetType: SdlcReviewTargetType; targetRef: string;
-  state: SdlcRunState; resultJson: string; createdAt: string; completedAt: string;
-}
-
-export interface EvalSuiteRecord {
-  id: string; orgId: string; key: EvalSuiteKey; label: string; scope: string; createdAt: string; updatedAt: string;
-}
-
-export interface EvalCaseRecord {
-  id: string; orgId: string; suiteId: string; title: string; sourceType: string; sourceRef: string; expectedSignal: string; createdAt: string;
-}
-
-export interface EvalRunRecord {
-  id: string; orgId: string; suiteId: string; state: SdlcRunState; passedCount: number; failedCount: number; resultJson: string; createdAt: string; completedAt: string;
-}
-
 export interface PrBotGateRecord {
   id: string; orgId: string; key: PrBotGateKey; label: string; gateType: string; enabled: boolean; createdAt: string; updatedAt: string;
 }

src/shared/snapshot-domain.ts

@@ -49,7 +49,7 @@ import type { ProviderAuthProfileRecord, ProviderAuthSessionRecord } from "./pro
 import type { ProviderRequestRecord } from "./provider-request-domain";
 import type { ProviderRateLimitObservationRecord, ProviderRateLimitStateRecord } from "./provider-runtime-domain";
 import type { MigrationCutoverEventRecord, MigrationReconciliationItemRecord, RollbackSnapshotRecord } from "./rollback-domain";
-import type { EvalCaseRecord, EvalRunRecord, EvalSuiteRecord, PrBotGateRecord, SdlcReviewAgentRecord, SdlcReviewRunRecord } from "./sdlc-domain";
+import type { PrBotGateRecord } from "./sdlc-domain";
 import type {
   BrowserActionPolicyRecord,
   BrowserActionRecord,
@@ -139,11 +139,6 @@ export interface AppSnapshot {
   operationalEvents: OperationalEventRecord[];
   chaosDrills: ChaosDrillRecord[];
   chaosDrillRuns: ChaosDrillRunRecord[];
-  sdlcReviewAgents: SdlcReviewAgentRecord[];
-  sdlcReviewRuns: SdlcReviewRunRecord[];
-  evalSuites: EvalSuiteRecord[];
-  evalCases: EvalCaseRecord[];
-  evalRuns: EvalRunRecord[];
   prBotGates: PrBotGateRecord[];
   auditReplayRuns: AuditReplayRunRecord[];
   auditEvents: AuditEventRecord[];