Files
AgentCompany/docs/2026-03-18-adversarial-review-verdict.md
T
2026-03-18 14:42:14 -04:00

2.7 KiB

Intent

Unify and harden cross-process message flow in AgentCompany so API/IPC/automation/renderer behavior is consistent, secure, and production-safe.

Verdict: CONTESTED (pre-fix) -> PASS (post-fix)

Pre-fix review surfaced multiple high-severity issues; after remediation in this cycle, no remaining high-severity blocker is accepted.

Findings

  1. [high] Unsafe connector bypass inconsistency (src/main/orchestrator/worker.ts:114-119)

    • Lens: Skeptic, Architect
    • Principle: fix-root-causes, boundary-discipline
    • Recommendation: gate dangerouslySkipPermissions by explicit env flag.
  2. [high] API message path missing real-time message event parity (src/main/api-server.ts:1456-1465)

    • Lens: Architect, Minimalist
    • Principle: prove-it-works, foundational-thinking
    • Recommendation: wire emitEvent through API callbacks and dispatch dependencies.
  3. [high] Mark-read visibility check false negatives under message volume (src/main/ipc-agent-coordination-handlers.ts:82-87)

    • Lens: Skeptic
    • Principle: prove-it-works
    • Recommendation: replace bounded list scan with targeted lookup by messageId.
  4. [medium] Message validation drift risk (schema vs dispatch normalization) (src/shared/contracts.ts:413-436, src/main/message-dispatch.ts:99-110)

    • Lens: Skeptic, Architect, Minimalist
    • Principle: foundational-thinking
    • Recommendation: enforce same recipient/channel invariants in dispatch layer (implemented).
  5. [medium] Wake target resolution snapshot scaling risk (src/main/message-dispatch.ts:177-223)

    • Lens: Skeptic, Architect
    • Principle: cost-aware-delegation
    • Recommendation: follow-up optimization to avoid full snapshot traversal per message.
  6. [low] Direct-channel avatar identity ambiguity (src/renderer/components/communication.tsx:134-140, :288-304)

    • Lens: Skeptic, Minimalist
    • Principle: outcome-oriented-execution
    • Recommendation: bind avatar identity to active viewer context (deferred).

What Went Well

  • Message flow now has one dispatch path shared by API, IPC, and automation.
  • Quality gates (typecheck/lint/unit/integration/e2e/build) all pass after remediation.
  • Build pipeline now emits cleaned release artifacts to /build/release with explicit version.

Lead Judgment

  1. Accept. Fixed in this cycle.
  2. Accept. Fixed in this cycle.
  3. Accept. Fixed in this cycle.
  4. Accept. Partially fixed by dispatch-layer invariant enforcement; future refactor can further reduce duplication.
  5. Accept as valid risk. Deferred to next optimization wave because correctness/security was prioritized first.
  6. Accept as low-priority UX consistency issue. Deferred.