ZacharyZhang-NY
118e3d8795
Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:
- createHireRequest (multi-module composite: agents + approvalsMod)
- rollbackConfigRevision (multi-module composite: documents + entityCrud)
- queryAll (raw-SQL escape hatch, @internal)
The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.
Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.
A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
65 lines
2.0 KiB
TypeScript
65 lines
2.0 KiB
TypeScript
/**
|
|
* Step 6: Run failure escalation (database layer).
|
|
* Physically extracted from autonomous-chain.spec.ts without behavior changes.
|
|
*/
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
import { installSharedSetup } from "./shared-setup";
|
|
|
|
const shared = installSharedSetup();
|
|
const { createAgent } = shared;
|
|
|
|
describe("Step 6: Run failure escalation (database layer)", () => {
|
|
it("finishRun marks run as failed and returns outcome", () => {
|
|
const agentId = createAgent({ name: "IC", role: "Engineer" });
|
|
const taskId = shared.db.tasks.saveTask({
|
|
companyId: shared.companyId,
|
|
title: "Failing task",
|
|
description: "Will fail",
|
|
assigneeAgentId: agentId,
|
|
workspaceId: shared.workspaceId,
|
|
priority: "medium",
|
|
status: "in_progress",
|
|
});
|
|
|
|
const run = shared.db.runs.createRun({
|
|
companyId: shared.companyId,
|
|
taskId,
|
|
agentId,
|
|
workspaceId: shared.workspaceId,
|
|
connectorId: "openai-codex",
|
|
});
|
|
|
|
shared.db.runs.markRunStatus(run.id, "running", "Started");
|
|
|
|
const outcome = shared.db.runs.finishRun({
|
|
runId: run.id,
|
|
status: "failed",
|
|
summary: null,
|
|
errorMessage: "Process crashed",
|
|
exitCode: 1,
|
|
signal: null,
|
|
model: "gpt-5-codex",
|
|
unattributedCost: false,
|
|
});
|
|
|
|
expect(outcome.budgetHardStopped).toBe(false);
|
|
|
|
const snapshot = shared.db.snap.listSnapshot();
|
|
const finishedRun = snapshot.runs.find((r) => r.id === run.id);
|
|
expect(finishedRun?.status).toBe("failed");
|
|
expect(finishedRun?.errorMessage).toBe("Process crashed");
|
|
});
|
|
|
|
it("getChainOfCommand returns manager for failure escalation", () => {
|
|
const ceoId = createAgent({ name: "CEO", role: "CEO" });
|
|
const ctoId = createAgent({ name: "CTO", role: "CTO", reportsTo: ceoId });
|
|
const icId = createAgent({ name: "Dev", role: "Engineer", reportsTo: ctoId });
|
|
|
|
const chain = shared.db.agents.getChainOfCommand(icId);
|
|
// First in chain is the immediate manager (CTO)
|
|
expect(chain.length).toBeGreaterThan(0);
|
|
expect(chain[0].name).toBe("CTO");
|
|
});
|
|
});
|