ZacharyZhang-NY
f041336721
Full-codebase ts-prune + manual audit sweep. Every change below is a pure
deletion (or a 2-line re-wire where a dead function was supposed to be
alive). No scope additions.
Dead wrappers / phantom features
- shouldAutoApproveApproval: zero-value wrapper over shouldAutoApprove.
Four call sites now import shouldAutoApprove from execution-policy
directly.
- evaluateRotation(session, connectorId, thresholdsOverride): the
connectorId arg was never read (underscored), and thresholdsOverride
was only exercised by the test suite — no production caller. Signature
collapses to evaluateRotation(session). DEFAULT_THRESHOLDS /
RotationThresholds exports and their tests go with it.
- installLogRedactor: defensive console wrapper that was never wired
from worker-entry. buildRedactor handles the known threat (env-value
leaks); the pattern-based redactTokens stays for tests and future
composition.
Dead files
- resume-interrupted-tasks.ts: helper function never imported.
- service-graph-orchestration-deps.ts: three factory closures
superseded by the inline closures in create-orchestration-service.
Dead exports
- listConnectorsByAuthKind (shared/connector-catalog)
- getLocalePromptInstruction + whole localization.ts file
- ImportantDocType
- main-side ConnectorAuthKind (duplicated the shared one; not referenced)
- CheckpointEngineService, RunHousekeepingService types
- WorkspaceResolution type
- cmdOrCtrlSymbol
- AgentEventPush, CredentialPayload type aliases
- parseApprovalPayloadJson, parseEnvValue, ProviderCard
- getSOP — buildSOPSection reads the SOPS map directly; the individual
getter had no callers. Deduped to a flat array.
- renderWakeReason in wake-reasons/en.ts: byte-for-byte duplicate of the
one in wake-reasons/index.ts.
Forgotten wiring (not cleanup, but adjacent)
- registerAgentStandupRoute: the GET /api/agents/me/standup endpoint is
advertised in every system prompt and wake-reason doc, but the route
handler was never registered in api-server/index.ts. Agents have been
hitting 404 since Pi Mono. Registered.
Dead DB column
- v44 migration drops runs.context_snapshot_json. Column was added by
v16-v25, never written or read, and v43's deliberate preservation
was an interim measure. Same idempotent table-rebuild pattern as
v41/v43.
Test tree
- Phantom-feature threshold override tests removed (3). The rest of
the rotation suite re-expressed against the real maxRuns=20 floor.
495/495 unit tests pass. typecheck + build clean.
43 lines
1.7 KiB
TypeScript
43 lines
1.7 KiB
TypeScript
import { AgentApiServer, type ApiServerEventCallbacks } from "./server-core";
|
|
import { registerAgentRoutes } from "./routes-agents";
|
|
import { registerAgentControlRoutes } from "./routes-agent-control";
|
|
import { registerAgentStandupRoute } from "./routes-agents-standup";
|
|
import { registerTaskRoutes } from "./routes-tasks";
|
|
import { registerWorkGraphRoutes } from "./routes-work-graph";
|
|
import { registerMessageRoutes } from "./routes-messages";
|
|
import { registerApprovalRoutes } from "./routes-approvals";
|
|
import { registerFileRoutes } from "./routes-files";
|
|
import { registerMiscRoutes } from "./routes-misc";
|
|
import { registerMeetingRoutes } from "./routes-meetings";
|
|
import { registerRunRoutes } from "./routes-runs";
|
|
import type { AppDatabase } from "../database";
|
|
|
|
export type { ApiServerEventCallbacks };
|
|
export { AgentApiServer };
|
|
|
|
/**
|
|
* Factory that creates and returns a fully-wired AgentApiServer with all
|
|
* domain route modules registered.
|
|
*/
|
|
export function createApiServer(
|
|
db: AppDatabase,
|
|
onDomainChanged: () => void,
|
|
onWakeAgent: (agentId: string, companyId: string, trigger: string) => string | null,
|
|
callbacks?: Partial<ApiServerEventCallbacks>,
|
|
allowedOrigins?: Iterable<string>,
|
|
): AgentApiServer {
|
|
const server = new AgentApiServer(db, onDomainChanged, onWakeAgent, callbacks, allowedOrigins);
|
|
registerAgentRoutes(server);
|
|
registerAgentControlRoutes(server);
|
|
registerAgentStandupRoute(server);
|
|
registerTaskRoutes(server);
|
|
registerWorkGraphRoutes(server);
|
|
registerMessageRoutes(server);
|
|
registerApprovalRoutes(server);
|
|
registerFileRoutes(server);
|
|
registerMiscRoutes(server);
|
|
registerMeetingRoutes(server);
|
|
registerRunRoutes(server);
|
|
return server;
|
|
}
|