ZacharyZhang-NY
118e3d8795
Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:
- createHireRequest (multi-module composite: agents + approvalsMod)
- rollbackConfigRevision (multi-module composite: documents + entityCrud)
- queryAll (raw-SQL escape hatch, @internal)
The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.
Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.
A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
39 lines
872 B
TypeScript
39 lines
872 B
TypeScript
import type { AppDatabase } from "./database";
|
|
|
|
export function resolveApprovalDecision({
|
|
db,
|
|
handleApprovalResolved,
|
|
companyId,
|
|
approvalId,
|
|
state,
|
|
decisionNote,
|
|
detail,
|
|
actor = "board",
|
|
}: {
|
|
db: AppDatabase;
|
|
handleApprovalResolved: (approvalId: string, companyId: string, decision: string) => void;
|
|
companyId: string;
|
|
approvalId: string;
|
|
state: "approved" | "rejected" | "revision_requested";
|
|
decisionNote?: string;
|
|
detail?: string | null;
|
|
actor?: string;
|
|
}) {
|
|
const note = decisionNote ?? "";
|
|
db.approvalsMod.decideApproval({
|
|
companyId,
|
|
approvalId,
|
|
state,
|
|
decisionNote: note,
|
|
});
|
|
db.activityMod.addActivity({
|
|
companyId,
|
|
actor,
|
|
action: `approval.${state}`,
|
|
entityType: "approval",
|
|
entityId: approvalId,
|
|
detail: detail ?? note,
|
|
});
|
|
handleApprovalResolved(approvalId, companyId, state);
|
|
}
|