Replaces legacy adapter ids (codex_local / claude_local / gemini_local / claude_compatible) across ~42 test files with pi-mono equivalents: - codex_local → openai-codex - claude_local → claude-pro - gemini_local → gemini-cli - claude_compatible → anthropic Hand-rewrites where fixture semantics changed: - connector-matching: TASK_TYPE_PREFERENCE ordering rebased (claude-pro first for code/content/management; google first for research) - connector-model-policy: getModels(provider) from pi-ai instead of the deleted adapter.module.models array - session-management + edge-case-session: adapter exemption removed; rotation now uniform under pi-mono - ipc-core-admin-handlers: CSV compat model replaced with pi-ai anthropic - connectors.spec: lookup by openai-codex id (catalog now starts with claude-pro) - onboarding-model-pool: listProviderModels(provider) helper; label text changed to "ChatGPT Plus/Pro (Codex)" - database integration: added vault insecure-fallback env + electron mock - command-paths: uses new @main/connector-helpers normalizeCommandValue - pi-mono-migrations: added `as string` casts for 3 negative-existence assertions verifying legacy ids were removed Drops: - pnpm-workspace.yaml packages: [] (was "packages/*"; directory empty) - obsolete CONNECTOR_STRENGTHS import; .module.models probing Verification: - pnpm typecheck → 0 errors - pnpm lint → 0 errors / 0 warnings - pnpm build:verify → 0 errors / 0 warnings - pnpm test:unit → 508/508 pass - pnpm test:integration → 96/96 pass - All 6 adapter hard gates pass (NOT FOUND / 0 matches / empty) - pi-ai / pi-agent-core / pi-coding-agent all resolved @0.67.6
250 lines
7.2 KiB
TypeScript
250 lines
7.2 KiB
TypeScript
import { mkdtemp, rm } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { AppDatabase } from "../../src/main/database";
|
|
import {
|
|
canAssignTask,
|
|
canControlAgent,
|
|
canManageGoal,
|
|
canManageOrganization,
|
|
canManageProject,
|
|
canRequestHire,
|
|
} from "../../src/main/agent-permissions";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
async function createTempDir(prefix: string) {
|
|
const dir = await mkdtemp(join(tmpdir(), prefix));
|
|
tempDirs.push(dir);
|
|
return dir;
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(tempDirs.splice(0).map((dir) => rm(dir, { recursive: true, force: true })));
|
|
});
|
|
|
|
describe("canManageOrganization", () => {
|
|
it("allows executive leaders without direct reports to manage organization growth", async () => {
|
|
const profileDir = await createTempDir("agentcompany-agent-perms-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const companyId = db.saveCompany({
|
|
name: "Org Permissions Co",
|
|
description: "Tests recursive org authority",
|
|
status: "active",
|
|
});
|
|
const workspaceId = db.saveWorkspace({
|
|
companyId,
|
|
name: "Primary",
|
|
localPath: profileDir,
|
|
repoUrl: "",
|
|
repoRef: "",
|
|
isPrimary: true,
|
|
});
|
|
|
|
const ceoId = db.saveAgent({
|
|
companyId,
|
|
name: "CEO",
|
|
role: "CEO",
|
|
title: "Chief Executive Officer",
|
|
status: "active",
|
|
reportsTo: null,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead the company",
|
|
budgetMonthlyUsd: 250,
|
|
});
|
|
const ctoId = db.saveAgent({
|
|
companyId,
|
|
name: "CTO",
|
|
role: "CTO",
|
|
title: "Chief Technology Officer",
|
|
status: "active",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead engineering",
|
|
budgetMonthlyUsd: 220,
|
|
department: "engineering",
|
|
});
|
|
const engineerId = db.saveAgent({
|
|
companyId,
|
|
name: "Engineer",
|
|
role: "Engineer",
|
|
title: "Software Engineer",
|
|
status: "active",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Build features",
|
|
budgetMonthlyUsd: 180,
|
|
department: "engineering",
|
|
});
|
|
|
|
expect(canManageOrganization(db, companyId, ceoId)).toBe(true);
|
|
expect(canManageOrganization(db, companyId, ctoId)).toBe(false);
|
|
expect(canRequestHire(db, companyId, ctoId)).toBe(true);
|
|
expect(canManageOrganization(db, companyId, engineerId)).toBe(false);
|
|
expect(canRequestHire(db, companyId, engineerId)).toBe(false);
|
|
|
|
db.close();
|
|
});
|
|
|
|
it("allows explicit organization_manage permission to grant recursive org authority", async () => {
|
|
const profileDir = await createTempDir("agentcompany-agent-perms-override-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const companyId = db.saveCompany({
|
|
name: "Org Permission Override Co",
|
|
description: "Tests permission-based org authority",
|
|
status: "active",
|
|
});
|
|
const workspaceId = db.saveWorkspace({
|
|
companyId,
|
|
name: "Primary",
|
|
localPath: profileDir,
|
|
repoUrl: "",
|
|
repoRef: "",
|
|
isPrimary: true,
|
|
});
|
|
const ceoId = db.saveAgent({
|
|
companyId,
|
|
name: "CEO",
|
|
role: "CEO",
|
|
title: "Chief Executive Officer",
|
|
status: "active",
|
|
reportsTo: null,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead the company",
|
|
budgetMonthlyUsd: 250,
|
|
});
|
|
const agentId = db.saveAgent({
|
|
companyId,
|
|
name: "Operations Lead",
|
|
role: "Specialist",
|
|
title: "Operations Specialist",
|
|
status: "active",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Coordinate operations",
|
|
budgetMonthlyUsd: 180,
|
|
department: "operations",
|
|
});
|
|
|
|
expect(canManageOrganization(db, companyId, agentId)).toBe(false);
|
|
db.setAgentPermission(agentId, companyId, "organization_manage", true);
|
|
expect(canManageOrganization(db, companyId, agentId)).toBe(true);
|
|
expect(canRequestHire(db, companyId, agentId)).toBe(true);
|
|
|
|
db.close();
|
|
});
|
|
|
|
it("manager subtree growth does not become org-wide admin after the first hire", async () => {
|
|
const profileDir = await createTempDir("agentcompany-agent-perms-scope-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const companyId = db.saveCompany({
|
|
name: "Scoped Authority Co",
|
|
description: "Tests that branch growth does not unlock org-wide admin powers",
|
|
status: "active",
|
|
});
|
|
const workspaceId = db.saveWorkspace({
|
|
companyId,
|
|
name: "Primary",
|
|
localPath: profileDir,
|
|
repoUrl: "",
|
|
repoRef: "",
|
|
isPrimary: true,
|
|
});
|
|
const ceoId = db.saveAgent({
|
|
companyId,
|
|
name: "CEO",
|
|
role: "CEO",
|
|
title: "Chief Executive Officer",
|
|
status: "active",
|
|
reportsTo: null,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead the company",
|
|
budgetMonthlyUsd: 250,
|
|
});
|
|
const ctoId = db.saveAgent({
|
|
companyId,
|
|
name: "CTO",
|
|
role: "CTO",
|
|
title: "Chief Technology Officer",
|
|
status: "active",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead engineering",
|
|
budgetMonthlyUsd: 220,
|
|
department: "engineering",
|
|
});
|
|
const cmoId = db.saveAgent({
|
|
companyId,
|
|
name: "CMO",
|
|
role: "CMO",
|
|
title: "Chief Marketing Officer",
|
|
status: "active",
|
|
reportsTo: ceoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Lead marketing",
|
|
budgetMonthlyUsd: 220,
|
|
department: "marketing",
|
|
});
|
|
const ctoReportId = db.saveAgent({
|
|
companyId,
|
|
name: "Engineer",
|
|
role: "Engineer",
|
|
title: "Frontend Engineer",
|
|
status: "active",
|
|
reportsTo: ctoId,
|
|
connectorId: "openai-codex",
|
|
workspaceId,
|
|
model: null,
|
|
capabilities: "Build frontend features",
|
|
budgetMonthlyUsd: 180,
|
|
department: "engineering",
|
|
});
|
|
|
|
const cmoTaskId = db.saveTask({
|
|
companyId,
|
|
title: "Launch campaign",
|
|
description: "Owned by the marketing branch",
|
|
assigneeAgentId: cmoId,
|
|
workspaceId,
|
|
priority: "high",
|
|
status: "todo",
|
|
});
|
|
expect(canRequestHire(db, companyId, ctoId)).toBe(true);
|
|
expect(canManageOrganization(db, companyId, ctoId)).toBe(false);
|
|
expect(canControlAgent(db, companyId, ctoId, ctoReportId)).toBe(true);
|
|
expect(canControlAgent(db, companyId, ctoId, cmoId)).toBe(false);
|
|
expect(canAssignTask(db, companyId, ctoId, ctoReportId)).toBe(true);
|
|
expect(canAssignTask(db, companyId, ctoId, cmoId)).toBe(false);
|
|
expect(canManageGoal(db, companyId, ctoId, cmoId)).toBe(false);
|
|
expect(canManageProject(db, companyId, ctoId, cmoId)).toBe(false);
|
|
expect(canManageGoal(db, companyId, ceoId, cmoId)).toBe(true);
|
|
expect(canManageProject(db, companyId, ceoId, cmoId)).toBe(true);
|
|
expect(db.getTask(cmoTaskId).assigneeAgentId).toBe(cmoId);
|
|
|
|
db.close();
|
|
});
|
|
});
|