Files
AgentCompany/tests/unit/agent-permissions-ceo-strategy.test.ts
T
ZacharyZhang-NY 1fad88bad1 C4 follow-up #1: split canFileCeoStrategy from canRequestHire for file_approval tool scope
Old internal-tool-selector attached `file_approval` to any agent with
`reportsTo === null`, and attached both tools through the same
management-keyword predicate chain. That let a VP or director with
org-management authority walk away with `file_approval`, contradicting
the C4 commit narrative that scoped `approve_ceo_strategy` as CEO-only.

Introduce `canFileCeoStrategy(db, companyId, agentId)` as a dedicated
predicate requiring both a CEO-equivalent role/title AND
`reportsTo === null`. Using either half alone is too loose: role alone
lets a demoted CEO with a virtual superior still file strategy,
`reportsTo` alone lets a VP with no manager slip through. The two
conditions together pin the predicate to a genuine top-level CEO.

- `hire_agent` continues to gate on `canRequestHire` (managers hiring
  ICs is a legitimate flow and the original "CEO-only" framing in the
  C4 commit message was narrower than the production reality).
- `file_approval` now gates on `canFileCeoStrategy`, orthogonal to hire
  authority.
- New unit test covers 4 edges: genuine CEO, CEO title with virtual
  superior, VP without manager, and plain IC.
2026-04-20 14:56:11 -04:00

160 lines
4.3 KiB
TypeScript

import { mkdtemp, rm } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { afterEach, describe, expect, it } from "vitest";
import { AppDatabase } from "../../src/main/database";
import { canFileCeoStrategy, canRequestHire } from "../../src/main/agent-permissions";
const tempDirs: string[] = [];
async function createTempDir(prefix: string) {
const dir = await mkdtemp(join(tmpdir(), prefix));
tempDirs.push(dir);
return dir;
}
async function setupCompany(prefix: string) {
const profileDir = await createTempDir(prefix);
const db = new AppDatabase(profileDir);
db.init();
const companyId = db.company.saveCompany({
name: "CEO Strategy Co",
description: "Tests canFileCeoStrategy orthogonality",
status: "active",
});
const workspaceId = db.workspacesMod.saveWorkspace({
companyId,
name: "Primary",
localPath: profileDir,
repoUrl: "",
repoRef: "",
isPrimary: true,
});
return { db, companyId, workspaceId };
}
afterEach(async () => {
await Promise.all(tempDirs.splice(0).map((dir) => rm(dir, { recursive: true, force: true })));
});
describe("canFileCeoStrategy", () => {
it("returns true for a genuine CEO who reports to the board", async () => {
const { db, companyId, workspaceId } = await setupCompany("agentcompany-ceo-strategy-real-");
const ceoId = db.agents.saveAgent({
companyId,
name: "Ada",
role: "CEO",
title: "Chief Executive Officer",
status: "active",
reportsTo: null,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Lead the company",
budgetMonthlyUsd: 250,
});
expect(canFileCeoStrategy(db, companyId, ceoId)).toBe(true);
db.close();
});
it("returns false for a CEO-titled agent with a virtual superior", async () => {
const { db, companyId, workspaceId } = await setupCompany("agentcompany-ceo-strategy-virtual-");
const boardId = db.agents.saveAgent({
companyId,
name: "Board Proxy",
role: "Board",
title: "Board Representative",
status: "active",
reportsTo: null,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Hold CEO accountable",
budgetMonthlyUsd: 100,
});
const ceoId = db.agents.saveAgent({
companyId,
name: "Ada",
role: "CEO",
title: "Chief Executive Officer",
status: "active",
reportsTo: boardId,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Lead the company",
budgetMonthlyUsd: 250,
});
expect(canFileCeoStrategy(db, companyId, ceoId)).toBe(false);
db.close();
});
it("returns false for a VP with no manager (role is not CEO)", async () => {
const { db, companyId, workspaceId } = await setupCompany("agentcompany-ceo-strategy-vp-");
const vpId = db.agents.saveAgent({
companyId,
name: "Kai",
role: "VP Product",
title: "Vice President of Product",
status: "active",
reportsTo: null,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Own product strategy",
budgetMonthlyUsd: 220,
department: "product",
});
expect(canFileCeoStrategy(db, companyId, vpId)).toBe(false);
expect(canRequestHire(db, companyId, vpId)).toBe(true);
db.close();
});
it("returns false for a plain IC", async () => {
const { db, companyId, workspaceId } = await setupCompany("agentcompany-ceo-strategy-ic-");
const ceoId = db.agents.saveAgent({
companyId,
name: "Ada",
role: "CEO",
title: "Chief Executive Officer",
status: "active",
reportsTo: null,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Lead the company",
budgetMonthlyUsd: 250,
});
const icId = db.agents.saveAgent({
companyId,
name: "Eve",
role: "Engineer",
title: "Software Engineer",
status: "active",
reportsTo: ceoId,
connectorId: "openai-codex",
workspaceId,
model: null,
capabilities: "Build features",
budgetMonthlyUsd: 180,
department: "engineering",
});
expect(canFileCeoStrategy(db, companyId, icId)).toBe(false);
db.close();
});
});