ZacharyZhang-NY
e0e43d6127
These columns and the messages that plumbed them existed for the CLI-
adapter era — Gemini's resume id and provider-specific session params
rode the run-finished envelope back onto the session row so the next
turn could resume. Pi Mono dispatches every provider through pi-ai and
emits neither value. The worker has been posting literal null on every
finish, finalizeRun has been writing null into task_sessions, and
rotateSession has been carrying null forward.
Remove the wire, the writer, the carry-forward, and the columns:
- v43 migration rebuilds task_sessions without session_params_json /
session_display_id, and runs without session_display_id. Follows
the idempotent "create new, copy, swap, reindex" pattern used by
v41. context_snapshot_json is preserved (also unreferenced today
but outside this cleanup's scope).
- RunJob / EnqueueRunPayload / ChildMessage / worker-types zod
schema no longer carry the fields. finishRun() / createNewSession()
signatures tighten in lockstep.
- rotateSession starts the new session with fresh counters and no
carry-forward.
- turn-context resolveSession returns just the session id.
- TaskSessionRecord / RunRecord lose the dead fields.
498/498 unit tests pass. typecheck + build clean.
92 lines
2.8 KiB
TypeScript
92 lines
2.8 KiB
TypeScript
/**
|
|
* Step 7: Worker crash recovery (database layer).
|
|
* Physically extracted from autonomous-chain.spec.ts without behavior changes.
|
|
*/
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
import { AppDatabase } from "../../../src/main/database";
|
|
import { installSharedSetup } from "./shared-setup";
|
|
|
|
const shared = installSharedSetup();
|
|
const { createAgent } = shared;
|
|
|
|
describe("Step 7: Worker crash recovery (database layer)", () => {
|
|
it("interruptStaleRuns clears running and queued runs on init", async () => {
|
|
const agentId = createAgent({ name: "Agent" });
|
|
const taskId = shared.db.saveTask({
|
|
companyId: shared.companyId,
|
|
title: "In-progress task",
|
|
description: "Running when crash happened",
|
|
assigneeAgentId: agentId,
|
|
workspaceId: shared.workspaceId,
|
|
priority: "medium",
|
|
status: "in_progress",
|
|
});
|
|
|
|
const run = shared.db.createRun({
|
|
companyId: shared.companyId,
|
|
taskId,
|
|
agentId,
|
|
workspaceId: shared.workspaceId,
|
|
connectorId: "openai-codex",
|
|
});
|
|
|
|
shared.db.markRunStatus(run.id, "running", "Started");
|
|
|
|
// Verify it's running
|
|
let snapshot = shared.db.listSnapshot();
|
|
expect(snapshot.runs.find((r) => r.id === run.id)?.status).toBe("running");
|
|
|
|
// Simulate app restart — close and re-init
|
|
shared.db.close();
|
|
|
|
const profileDir = shared.tempDirs[shared.tempDirs.length - 1]!;
|
|
shared.db = new AppDatabase(profileDir);
|
|
shared.db.init(); // This calls interruptStaleRuns()
|
|
|
|
snapshot = shared.db.listSnapshot();
|
|
const recoveredRun = snapshot.runs.find((r) => r.id === run.id);
|
|
expect(recoveredRun?.status).toBe("interrupted");
|
|
});
|
|
|
|
it("finishRun can mark interrupted runs from crash recovery", () => {
|
|
const agentId = createAgent({ name: "Agent" });
|
|
const taskId = shared.db.saveTask({
|
|
companyId: shared.companyId,
|
|
title: "Crash recovery task",
|
|
description: "Test",
|
|
assigneeAgentId: agentId,
|
|
workspaceId: shared.workspaceId,
|
|
priority: "medium",
|
|
status: "in_progress",
|
|
});
|
|
|
|
const run = shared.db.createRun({
|
|
companyId: shared.companyId,
|
|
taskId,
|
|
agentId,
|
|
workspaceId: shared.workspaceId,
|
|
connectorId: "openai-codex",
|
|
});
|
|
|
|
shared.db.markRunStatus(run.id, "running", "Started");
|
|
|
|
// Simulate crash recovery - mark as interrupted
|
|
shared.db.finishRun({
|
|
runId: run.id,
|
|
status: "interrupted",
|
|
summary: "Worker process crashed.",
|
|
errorMessage: "Worker process exited unexpectedly.",
|
|
exitCode: 1,
|
|
signal: null,
|
|
model: null,
|
|
unattributedCost: true,
|
|
});
|
|
|
|
const snapshot = shared.db.listSnapshot();
|
|
const recovered = snapshot.runs.find((r) => r.id === run.id);
|
|
expect(recovered?.status).toBe("interrupted");
|
|
expect(recovered?.errorMessage).toBe("Worker process exited unexpectedly.");
|
|
});
|
|
});
|