Files
AgentCompany/src/main/worker/worker-runner.ts
T
ZacharyZhang-NY d9b35d73ab Pin work_products identity to (company, workspace, path)
The natural key used to be (companyId, provider, externalId), so two
workspaces with the same workspace-relative path collided onto one
row. Provenance was also frozen at the first write: `created_by_run_id`
never refreshed, so a run that edited a pre-existing file never
qualified as a deliverable and the DocumentCenter "open" link could
still jump into the first workspace after a repo move.

Migration v45 adds `workspace_id` + `last_touched_by_run_id`, backfills
`workspace_id` via the task/run join, seeds `last_touched_by_run_id =
created_by_run_id`, and installs a partial unique index on
`(company_id, workspace_id, provider, external_id)` scoped to rows
that have a workspace. The artifact projector now records
`workspace_id` on insert and refreshes `last_touched_by_run_id` on
every upsert. The deliverable signal query reads either provenance
column so a run that only edited a pre-existing file still counts.
`resolveWorkProductTarget` prefers the stored `workspace_id` and falls
back to the task/run join for legacy NULL rows.
2026-04-19 15:43:48 -04:00

240 lines
9.0 KiB
TypeScript

import type { Agent, AgentMessage } from "@mariozechner/pi-agent-core";
import { resolveModel, resolveExtraStreamHeaders } from "../model-resolver";
import type { RunStatus } from "@shared/types";
import type { ChildMessage, RunJob } from "./worker-helpers";
import { applyEnvOverrides, buildRedactor } from "./worker-helpers";
import { createCodingTools } from "@mariozechner/pi-coding-agent";
import { createPiAgent, resolveThinkingLevel } from "./pi-agent-factory";
import type { WorkerRpcClient } from "./worker-rpc";
interface PrepareRunResult {
provider: string;
apiKey: string;
extraEnv: Record<string, string>;
priorMessages: AgentMessage[];
}
interface RunnerDeps {
post: (message: ChildMessage) => void;
rpc: WorkerRpcClient;
isCancelled: (runId: string) => boolean;
}
/**
* Lifecycle owner for one-and-only-one active pi `Agent` per run.
*
* Responsibilities:
* - Calls `prepareRun` on main to materialise session + credentials.
* - Builds an `Agent` via `createPiAgent` with the full Pi contract.
* - Streams every pi `AgentEvent` into the worker → main pipe.
* - Persists each `message_end` message through `persistMessage` RPC.
* - Exposes `steer` to the worker entry so mid-run injections from
* main land on the in-process Agent instance.
* - Publishes `run-agent-state` transitions so main can tell whether
* an active run is actually ready to accept steer messages.
*/
export class WorkerRunner {
private readonly abortControllers = new Map<string, AbortController>();
private readonly runPromises = new Map<string, Promise<void>>();
private readonly activeAgents = new Map<string, Agent>();
constructor(private readonly deps: RunnerDeps) {}
cancel(runId: string): void {
const controller = this.abortControllers.get(runId);
if (controller) controller.abort();
}
/**
* Enqueue a steering message onto the active Agent for this run. Returns
* true iff the Agent instance exists in `activeAgents` and the message
* was appended to its steering queue. A false return means the run has
* either not finished construction (pre-`agent_active`) or has already
* torn down (post-`closing`); callers must treat the steer as rejected
* so main can hold the inbox `delivered_at` write and fall back to the
* inbox + wake path instead.
*/
steer(runId: string, message: AgentMessage): boolean {
const agent = this.activeAgents.get(runId);
if (!agent) return false;
agent.steer(message);
return true;
}
/**
* Aborts every in-flight run and returns a promise that resolves once
* each `run()` has settled (success, failure, or abort). Callers (the
* worker shutdown handler) must `await` this before `process.exit` so
* pending `persistMessage` RPCs and the final `run-finished` post reach
* the parent before the worker dies.
*/
async cancelAll(): Promise<void> {
for (const controller of this.abortControllers.values()) {
controller.abort();
}
const pending = [...this.runPromises.values()];
this.abortControllers.clear();
await Promise.allSettled(pending);
}
run(job: RunJob): Promise<void> {
const promise = this.runImpl(job).finally(() => {
this.runPromises.delete(job.runId);
});
this.runPromises.set(job.runId, promise);
return promise;
}
private async runImpl(job: RunJob): Promise<void> {
const { post, rpc, isCancelled } = this.deps;
const redact = buildRedactor(job.env);
const abortController = new AbortController();
this.abortControllers.set(job.runId, abortController);
post({ type: "run-status", runId: job.runId, status: "running", message: `Running agent ${job.agentName}.` });
let resolvedModelId: string | null = job.model;
let finalUsage: { inputTokens: number | null; outputTokens: number | null } = {
inputTokens: null,
outputTokens: null,
};
let errorMessage: string | null = null;
// Inject the AgentCompany job env (AGENT_COMPANY_API_URL / API_KEY /
// AGENT_ID / COMPANY_ID / RUN_ID / TASK_ID / WAKE_REASON + provider
// secret bindings) into the worker's process.env BEFORE Agent
// construction, so the agent's bash-tool children can call back into
// our HTTP API via fetch(process.env.AGENT_COMPANY_API_URL). Restored
// in the outer finally regardless of success / abort / throw.
const restoreJobEnv = applyEnvOverrides(job.env);
try {
if (!job.model) {
throw new Error(`Run ${job.runId} has no model selected.`);
}
const prepareResponse = await rpc.invoke(job.runId, "prepareRun", {
connectorId: job.connectorId,
taskSessionId: job.taskSessionId,
agentId: job.agentId,
companyId: job.companyId,
taskId: job.taskId,
modelId: job.model,
workspaceId: job.workspaceId ?? null,
workspacePath: job.workspacePath ?? null,
});
if (!prepareResponse.ok) {
throw new Error(prepareResponse.error);
}
const prepared = prepareResponse.result as PrepareRunResult;
const restoreProviderEnv = applyEnvOverrides(prepared.extraEnv);
try {
const model = resolveModel(prepared.provider, job.model);
if (!model) {
throw new Error(`Unknown model ${job.model} for provider ${prepared.provider}.`);
}
resolvedModelId = model.id;
const extraHeaders = resolveExtraStreamHeaders(prepared.provider, prepared.apiKey);
const cwd = job.workspacePath ?? process.cwd();
const tools = createCodingTools(cwd) as never;
const agent = createPiAgent({
runId: job.runId,
taskSessionId: job.taskSessionId,
systemPrompt: job.systemPrompt ?? "",
model,
tools,
priorMessages: prepared.priorMessages,
thinkingLevel: resolveThinkingLevel(job.thinkingEffort),
apiKey: prepared.apiKey,
extraHeaders,
rpc,
});
this.activeAgents.set(job.runId, agent);
post({ type: "run-agent-state", runId: job.runId, state: "agent_active" });
const unsubscribe = agent.subscribe(async (event) => {
const timestamp = new Date().toISOString();
post({
type: "agent-event",
runId: job.runId,
agentId: job.agentId,
companyId: job.companyId,
taskId: job.taskId,
emittedAt: timestamp,
event: event as { type: string } & Record<string, unknown>,
});
if (event.type === "message_end" && event.message) {
await rpc.invoke(job.runId, "persistMessage", {
taskSessionId: job.taskSessionId,
message: event.message,
});
const maybeAssistant = event.message as { role?: string; usage?: { input?: number; output?: number; cost?: { total?: number } } };
if (maybeAssistant.role === "assistant" && maybeAssistant.usage) {
finalUsage = {
inputTokens: typeof maybeAssistant.usage.input === "number" ? maybeAssistant.usage.input : finalUsage.inputTokens,
outputTokens: typeof maybeAssistant.usage.output === "number" ? maybeAssistant.usage.output : finalUsage.outputTokens,
};
}
}
});
try {
const promptContent = job.initialUserTurn.trim();
if (promptContent.length === 0) {
throw new Error(`Run ${job.runId} has an empty initial user turn.`);
}
const promptMessage: AgentMessage = {
role: "user",
content: [{ type: "text", text: promptContent }],
timestamp: Date.now(),
};
const runPromise = agent.prompt(promptMessage);
abortController.signal.addEventListener("abort", () => agent.abort(), { once: true });
await runPromise;
} finally {
post({ type: "run-agent-state", runId: job.runId, state: "closing" });
unsubscribe();
this.activeAgents.delete(job.runId);
}
} finally {
restoreProviderEnv();
}
} catch (error) {
errorMessage = error instanceof Error ? error.message : String(error);
post({ type: "run-log", runId: job.runId, stream: "stderr", chunk: redact(errorMessage) });
} finally {
this.abortControllers.delete(job.runId);
restoreJobEnv();
}
const status: RunStatus = isCancelled(job.runId)
? "cancelled"
: errorMessage
? "failed"
: "succeeded";
post({
type: "run-finished",
runId: job.runId,
status,
summary: null,
errorMessage,
exitCode: null,
signal: null,
model: resolvedModelId,
// Worker no longer owns cost attribution — CostWriter (main-side)
// writes per-message rows, finishRun sums them. This flag stays true
// only for run paths that never had a chance to emit usage (errors
// before the first message_end); per-message drift detection belongs
// elsewhere.
unattributedCost: finalUsage.inputTokens === null,
inputTokens: finalUsage.inputTokens,
outputTokens: finalUsage.outputTokens,
});
}
}