ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
3.7 KiB
3.7 KiB
title, impact, impactDescription, tags
| title | impact | impactDescription | tags |
|---|---|---|---|
| Build Anti-Corruption Layers for External Systems | MEDIUM | protects domain from external model pollution | adapt, anti-corruption, external, isolation |
Build Anti-Corruption Layers for External Systems
When integrating with external systems that have different models, build an anti-corruption layer (ACL) that translates between their model and yours. Never let external concepts pollute your domain.
Incorrect (external model leaks into domain):
// Domain polluted with Stripe's model
public class Order {
private String id;
private List<OrderItem> items;
// Stripe-specific fields in domain
private String stripeCustomerId;
private String stripePaymentIntentId;
private String stripePaymentMethodId;
public void processPayment(Stripe stripe) {
// Domain directly calls Stripe
PaymentIntent intent = PaymentIntent.create(
PaymentIntentCreateParams.builder()
.setCustomer(this.stripeCustomerId)
.setPaymentMethod(this.stripePaymentMethodId)
.setAmount(this.calculateTotal().cents())
.setCurrency("usd")
.build()
);
this.stripePaymentIntentId = intent.getId();
}
}
// If we switch to PayPal, Order must change
Correct (anti-corruption layer isolates external model):
// domain/Order.java - Pure domain, no external concepts
public class Order {
private OrderId id;
private CustomerId customerId;
private List<OrderItem> items;
private PaymentStatus paymentStatus;
public Money calculateTotal() {
return items.stream()
.map(OrderItem::lineTotal)
.reduce(Money.zero(), Money::add);
}
public void markPaid(PaymentReference reference) {
this.paymentStatus = PaymentStatus.paid(reference);
}
}
// domain/ports/PaymentProcessor.java - Domain-defined port
public interface PaymentProcessor {
PaymentResult charge(CustomerId customer, Money amount);
}
// Domain-defined value objects
public record PaymentResult(PaymentReference reference, PaymentStatus status) {}
public record PaymentReference(String value) {}
// infrastructure/stripe/StripePaymentProcessor.java - ACL
public class StripePaymentProcessor implements PaymentProcessor {
private final CustomerMappingRepository customerMapping;
public PaymentResult charge(CustomerId customerId, Money amount) {
// Translate domain CustomerId to Stripe customer
String stripeCustomerId = customerMapping.getStripeId(customerId);
// Call Stripe with their model
PaymentIntent intent = PaymentIntent.create(
PaymentIntentCreateParams.builder()
.setCustomer(stripeCustomerId)
.setAmount(amount.cents())
.setCurrency("usd")
.setConfirm(true)
.build()
);
// Translate Stripe response back to domain model
return new PaymentResult(
new PaymentReference(intent.getId()),
translateStatus(intent.getStatus())
);
}
private PaymentStatus translateStatus(String stripeStatus) {
return switch (stripeStatus) {
case "succeeded" -> PaymentStatus.COMPLETED;
case "processing" -> PaymentStatus.PENDING;
case "requires_action" -> PaymentStatus.REQUIRES_ACTION;
default -> PaymentStatus.FAILED;
};
}
}
Benefits:
- Domain model remains clean and business-focused
- Switch payment providers by implementing new ACL
- External API changes isolated to ACL
Reference: Anti-Corruption Layer Pattern