ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
3.0 KiB
3.0 KiB
title, impact, impactDescription, tags
| title | impact | impactDescription | tags |
|---|---|---|---|
| Dependency Injection Containers Live at the Edge | MEDIUM | prevents DI container coupling throughout codebase | frame, dependency-injection, container, composition |
Dependency Injection Containers Live at the Edge
DI containers are infrastructure. Use them at composition root (main/startup) to wire dependencies, but don't let them invade domain or application code.
Incorrect (DI container throughout codebase):
// Domain depends on DI container
using Microsoft.Extensions.DependencyInjection;
public class Order
{
public void Process()
{
// Service locator anti-pattern
var emailService = ServiceLocator.Current.GetService<IEmailService>();
var logger = ServiceLocator.Current.GetService<ILogger>();
// ...
}
}
// Application layer decorated with DI attributes
public class CreateOrderUseCase
{
[Inject]
public IOrderRepository Orders { get; set; }
[Inject]
public IPaymentGateway Payments { get; set; }
// Properties injected by container - hidden dependencies
}
// Switching DI containers requires touching domain code
Correct (DI container only at composition root):
// Domain - no DI container knowledge
public class Order
{
public void Process(IEmailService email, ILogger logger)
{
// Dependencies passed explicitly
}
}
// Application - constructor injection, no container knowledge
public class CreateOrderUseCase
{
private readonly IOrderRepository _orders;
private readonly IPaymentGateway _payments;
// Plain constructor - works with any DI container or manual wiring
public CreateOrderUseCase(
IOrderRepository orders,
IPaymentGateway payments)
{
_orders = orders;
_payments = payments;
}
}
// Composition root - only place that knows about DI container
// Program.cs or Startup.cs
public class CompositionRoot
{
public static IServiceProvider ConfigureServices()
{
var services = new ServiceCollection();
// Infrastructure
services.AddScoped<IOrderRepository, PostgresOrderRepository>();
services.AddScoped<IPaymentGateway, StripePaymentGateway>();
services.AddScoped<IEmailService, SendGridEmailService>();
// Application
services.AddScoped<CreateOrderUseCase>();
services.AddScoped<GetOrdersUseCase>();
// Interface
services.AddScoped<OrderController>();
return services.BuildServiceProvider();
}
}
// For tests - manual wiring without container
[Test]
public void CreatesOrder()
{
var orders = new InMemoryOrderRepository();
var payments = new FakePaymentGateway();
var useCase = new CreateOrderUseCase(orders, payments);
useCase.Execute(command);
Assert.That(orders.All(), Has.Count.EqualTo(1));
}
Benefits:
- Domain and application code portable across DI containers
- Tests don't need DI container setup
- Dependencies explicit in constructors
Reference: Composition Root Pattern