ZacharyZhang-NY
e74dafcd36
Three independently ugly bugs that all fed the same log flood:
* Electron's `WebFrameMain.send` writes every "Render frame was disposed"
to stderr via `console.error`. When the worker fans a second
agent-event past a reloading renderer, we produced thousands of
identical lines and stalled the main loop on stderr I/O. Added a
`mainFrame.detached` guard so the send is short-circuited before
Electron's own catch block fires, and installed a targeted filter in
`suppress-warnings.ts` (now actually imported from the entry point)
so the specific `console.error("Error sending from webFrameMain:"…)`
noise never reaches the terminal. Any other payload still surfaces.
* `dispatchAgentMessage` accepted the human-reader sentinel as a wake
target when an agent replied to `__board__` — `wakeAgentIfPossible`
then called `db.getAgent("__board__")`, threw, and the dispatcher
kept repeating on every send. Strip `HUMAN_SENDER_ID` at
`resolveMessageWakeTargets`, and keep a defense-in-depth guard in the
heartbeat so a stray caller (future automation fan-out) cannot
reintroduce the crash.
* Pi's skills loader rejects any SKILL.md whose frontmatter `name`
diverges from its parent directory. The four bundled `my-writing-style`
copies declared `name: writing-style-skill`, so every install emitted
a warning and dropped the skill. They also lived as orphan gitlinks
(mode 160000 without .gitmodules), and the global `*.md` gitignore
hid every other SKILL.md from version control. Fixed the frontmatter
to match the dir, converted the dangling submodules to plain trees,
and allowlisted `builtin-skills/**/*.md` so a fresh clone carries the
catalogue instead of silently losing it.
1.5 KiB
1.5 KiB
title, impact, impactDescription, tags
| title | impact | impactDescription | tags |
|---|---|---|---|
| Follow the Law of Demeter | MEDIUM-HIGH | prevents hidden dependencies between modules | obj, demeter, coupling, encapsulation |
Follow the Law of Demeter
A method should only call methods on: its own object, objects passed as parameters, objects it creates, or its direct component objects. Avoid chained method calls on returned objects.
Incorrect (train wreck - violates Law of Demeter):
// Reaches through multiple objects
String outputDir = ctxt.getOptions().getScratchDir().getAbsolutePath();
// Forces knowledge of internal structure
customer.getAddress().getCity().getName();
// Chains expose implementation details
report.getFormatter().getConfiguration().getPageSize();
Correct (respects object boundaries):
// Option 1: Create a direct method
String outputDir = ctxt.getOutputDirectory();
// Option 2: Tell, don't ask
customer.sendBillingNotice(); // Let customer handle its own address
// Option 3: If data structure, use it directly (no behavior expected)
BufferedOutputStream bos = ctxt.createScratchFileStream(classFileName);
Exception: The Law of Demeter does not apply to data structures. If Options, ScratchDir, etc. are just data containers without behavior, the chaining is acceptable:
// Data transfer objects can be chained
final String outputDir = ctxt.options.scratchDir.absolutePath;
Reference: Clean Code, Chapter 6: Objects and Data Structures