ZacharyZhang-NY
b50716d4e8
Inter-agent messages previously entered the recipient's context as a separate prompt block (recentMessages), rebuilt every turn. This double- charged tokens and kept messages outside pi's native AgentMessage stream. Now at prepareRun: pull the recipient's unread inbox, project each AgentMessageRecord into a pi user-role AgentMessage, persist to SqliteSessionStore, and mark delivered. The recipient reads messages as natural conversation turns in the transcript. - db: listAgentInboxUnread + markAgentInboxDelivered (transactional) - agent-runtime/inbox-projection.ts: AgentMessageRecord -> pi AgentMessage - runtime-bridge.prepareRun: inject + deliver before loadMessages - prompt-builder: delete recentMessages context block + buildMessagesSection - message-normalize: drop unused normalizeMessagesForPrompt - delete prompt-builder/attachment-resolver.ts (orphan after section removal) Send path (api-server/routes-messages, ipc, UI) unchanged — inbox table remains the UI source. Transactional delivery marking prevents duplicate injection across runs. Failed append -> no mark -> retry on next run.
78 lines
2.1 KiB
TypeScript
78 lines
2.1 KiB
TypeScript
/**
|
|
* Message Normalization Layer
|
|
*
|
|
* Normalizes comments before they are injected into agent prompts.
|
|
* Prevents malformed, empty, or excessively long content from degrading
|
|
* model output quality. Inspired by Reference/src/utils/messages.ts.
|
|
*
|
|
* Applied at the prompt-builder boundary — the last point before content
|
|
* enters the model's context window.
|
|
*
|
|
* Inter-agent messages no longer flow through a prompt block; they are
|
|
* projected directly into the recipient's pi session transcript. See
|
|
* `agent-runtime/inbox-projection.ts`.
|
|
*/
|
|
|
|
/** Maximum comment body length in prompt context. */
|
|
const MAX_COMMENT_BODY_LENGTH = 500;
|
|
|
|
/**
|
|
* Strip control characters (except newlines/tabs) and collapse
|
|
* excessive whitespace runs into single spaces.
|
|
*/
|
|
function cleanText(text: string): string {
|
|
// eslint-disable-next-line no-control-regex
|
|
return text.replace(/[\x00-\x08\x0B\x0C\x0E-\x1F\x7F]/g, "")
|
|
.replace(/[ \t]{4,}/g, " ")
|
|
.trim();
|
|
}
|
|
|
|
/**
|
|
* Truncate text to maxLen, appending "…" if truncated.
|
|
*/
|
|
function truncate(text: string, maxLen: number): string {
|
|
if (text.length <= maxLen) return text;
|
|
return text.slice(0, maxLen - 1) + "…";
|
|
}
|
|
|
|
export interface CommentRecord {
|
|
taskId: string;
|
|
taskTitle: string;
|
|
authorName: string;
|
|
body: string;
|
|
createdAt: string;
|
|
}
|
|
|
|
/**
|
|
* Normalize task comments before prompt injection.
|
|
* - Removes empty-body comments
|
|
* - Cleans control characters
|
|
* - Truncates overly long bodies
|
|
* - Deduplicates consecutive identical comments
|
|
*/
|
|
export function normalizeCommentsForPrompt(
|
|
comments: CommentRecord[],
|
|
limit: number = 10,
|
|
): CommentRecord[] {
|
|
const result: CommentRecord[] = [];
|
|
let prevKey = "";
|
|
|
|
for (const comment of comments) {
|
|
const cleaned = cleanText(comment.body);
|
|
if (cleaned.length === 0) continue;
|
|
|
|
const key = `${comment.taskId}:${comment.authorName}:${cleaned}`;
|
|
if (key === prevKey) continue;
|
|
prevKey = key;
|
|
|
|
result.push({
|
|
...comment,
|
|
body: truncate(cleaned, MAX_COMMENT_BODY_LENGTH),
|
|
});
|
|
|
|
if (result.length >= limit) break;
|
|
}
|
|
|
|
return result;
|
|
}
|