ZacharyZhang-NY
118e3d8795
Migrate all remaining pass-through call sites (social, skills, budget,
entityCrud, documents, knowledge, automation, wakeup, backup, threads,
settings, snapshot, connectors, workspaces, activity) to their owning
domain modules. `AppDatabase` now carries only three methods:
- createHireRequest (multi-module composite: agents + approvalsMod)
- rollbackConfigRevision (multi-module composite: documents + entityCrud)
- queryAll (raw-SQL escape hatch, @internal)
The vault/env-binding infrastructure previously passed argument-by-
argument into `entityCrud.saveSecret`/`resolveSecretEnv` now binds at
module construction, letting callers invoke `db.entityCrud.saveSecret({...})`
without carrying vault plumbing.
Structural types that narrowed AppDatabase to a bag of flat methods
(`ConnectorModelPolicyDeps` callers, `CapabilityMatchDb`, test mocks in
budget-enforcement / budget-incidents / task-quality-gates /
failure-escalation / task-quality-gates-sweep) are reshaped to the new
namespace. `connectorPolicyDepsFromDb` replaces the old pattern of
handing the whole AppDatabase to `validateConnectorModelSelection`.
A new ESLint rule in eslint.config.mjs blocks new top-level methods on
AppDatabase so the pass-through layer cannot silently grow back.
`AppDatabase.ts` dropped from 193 lines to 58; `AppDatabaseBase` lost
the 270-line trailing pass-through block.
60 lines
1.8 KiB
TypeScript
60 lines
1.8 KiB
TypeScript
import { mkdtemp, rm } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { AppDatabase } from "../../src/main/database";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
async function createTempDir(prefix: string) {
|
|
const dir = await mkdtemp(join(tmpdir(), prefix));
|
|
tempDirs.push(dir);
|
|
return dir;
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(tempDirs.splice(0).map((dir) => rm(dir, { recursive: true, force: true })));
|
|
});
|
|
|
|
describe("knowledge provenance", () => {
|
|
it("preserves or refreshes sourceRunId when an existing knowledge entry is updated", async () => {
|
|
const profileDir = await createTempDir("agentcompany-knowledge-provenance-");
|
|
const db = new AppDatabase(profileDir);
|
|
db.init();
|
|
|
|
const companyId = db.company.saveCompany({
|
|
name: "Knowledge Provenance Co",
|
|
description: "Tests sourceRunId updates on knowledge entry edits",
|
|
status: "active",
|
|
});
|
|
|
|
const knowledgeId = db.knowledgeMod.saveKnowledgeEntry({
|
|
companyId,
|
|
category: "lesson_learned",
|
|
topic: "Original lesson",
|
|
content: "Initial content",
|
|
importance: "medium",
|
|
sourceRunId: null,
|
|
});
|
|
|
|
db.knowledgeMod.saveKnowledgeEntry({
|
|
id: knowledgeId,
|
|
companyId,
|
|
category: "lesson_learned",
|
|
topic: "Original lesson",
|
|
content: "Updated content with better guidance",
|
|
importance: "high",
|
|
sourceRunId: "run-123",
|
|
});
|
|
|
|
const entry = db.queryAll<{ sourceRunId: string | null; importance: string }>(
|
|
"select source_run_id as sourceRunId, importance from knowledge_base where id = ? limit 1",
|
|
knowledgeId,
|
|
)[0];
|
|
expect(entry?.sourceRunId).toBe("run-123");
|
|
expect(entry?.importance).toBe("high");
|
|
|
|
db.close();
|
|
});
|
|
});
|