Add profile history clear confirmation

This commit is contained in:
2026-05-08 04:10:04 -04:00
parent 177399dd1c
commit 02279f8984
6 changed files with 189 additions and 1 deletions
+30
View File
@@ -0,0 +1,30 @@
use gpui::Context;
use super::{ElyShell, ShellState};
impl ElyShell {
pub(super) fn request_clear_history_confirmation(&mut self, cx: &mut Context<Self>) {
if let ShellState::Ready(core) = &mut self.state
&& let Ok(snapshot) = core.snapshot()
{
self.history_clear_confirmation = Some(snapshot.active_profile_id);
cx.notify();
}
}
pub(super) fn cancel_clear_history_confirmation(&mut self, cx: &mut Context<Self>) {
self.history_clear_confirmation = None;
cx.notify();
}
pub(super) fn clear_active_profile_history(&mut self, cx: &mut Context<Self>) {
if let ShellState::Ready(core) = &mut self.state
&& let Ok(snapshot) = core.snapshot()
&& self.history_clear_confirmation.as_ref() == Some(&snapshot.active_profile_id)
&& core.clear_active_profile_history().is_ok()
{
self.history_clear_confirmation = None;
cx.notify();
}
}
}
@@ -1,6 +1,7 @@
use ely_browser_core::BrowserSnapshot;
use ely_design_system::colors;
use ely_domain::HistoryRecordingPolicy;
use gpui::prelude::FluentBuilder;
use gpui::{AnyElement, Context, IntoElement, ParentElement, Styled, div, px, rgb};
use gpui_component::{
IconName, Selectable, Sizable, StyledExt,
@@ -16,6 +17,9 @@ impl ElyShell {
snapshot: &BrowserSnapshot,
cx: &mut Context<Self>,
) -> AnyElement {
let confirming_clear =
self.history_clear_confirmation.as_ref() == Some(&snapshot.active_profile_id);
render_canvas_surface(
div()
.size_full()
@@ -25,6 +29,9 @@ impl ElyShell {
.gap_5()
.child(render_privacy_header(snapshot))
.child(render_history_summary(snapshot))
.when(snapshot.active_profile_history_entry_count > 0, |this| {
this.child(render_history_clear_controls(confirming_clear, cx))
})
.child(render_history_policy_rows(snapshot.history_recording_policy, cx)),
)
}
@@ -120,7 +127,91 @@ fn render_history_summary(snapshot: &BrowserSnapshot) -> AnyElement {
.text_xs()
.font_semibold()
.text_color(rgb(colors::MUTED))
.child(format!("{} visible entries", snapshot.history_entries.len())),
.child(format!("{} Profile entries", snapshot.active_profile_history_entry_count)),
)
.into_any_element()
}
fn render_history_clear_controls(confirming_clear: bool, cx: &mut Context<ElyShell>) -> AnyElement {
if confirming_clear {
return render_clear_history_confirmation(cx);
}
div()
.flex()
.items_center()
.justify_between()
.gap_4()
.child(
div()
.text_sm()
.text_color(rgb(colors::MUTED))
.child("Clear all history saved for this Profile."),
)
.child(
Button::new("request-clear-history")
.danger()
.xsmall()
.label("Clear History")
.tooltip("Clear Profile History")
.on_click(cx.listener(|shell, _, _, cx| {
shell.request_clear_history_confirmation(cx);
})),
)
.into_any_element()
}
fn render_clear_history_confirmation(cx: &mut Context<ElyShell>) -> AnyElement {
div()
.rounded_md()
.border_1()
.border_color(rgb(colors::ERROR))
.bg(rgb(colors::CANVAS_SOFT))
.px_4()
.py_3()
.flex()
.items_center()
.justify_between()
.gap_4()
.child(
div()
.min_w_0()
.flex()
.flex_col()
.gap_1()
.child(
div()
.text_sm()
.font_semibold()
.text_color(rgb(colors::INK))
.child("Confirm history clearing"),
)
.child(
div()
.text_xs()
.text_color(rgb(colors::MUTED))
.child("This removes Profile history across every Space."),
),
)
.child(
div()
.flex()
.items_center()
.gap_2()
.child(
Button::new("cancel-clear-history").ghost().xsmall().label("Cancel").on_click(
cx.listener(|shell, _, _, cx| {
shell.cancel_clear_history_confirmation(cx);
}),
),
)
.child(
Button::new("confirm-clear-history").danger().xsmall().label("Clear").on_click(
cx.listener(|shell, _, _, cx| {
shell.clear_active_profile_history(cx);
}),
),
),
)
.into_any_element()
}
+3
View File
@@ -1,4 +1,5 @@
mod downloads;
mod history;
mod internal_pages;
mod plugins;
mod render;
@@ -36,6 +37,7 @@ pub struct ElyShell {
download_action_error: Option<String>,
download_clear_confirmation: bool,
download_security_confirmation: Option<PendingDownloadFileAction>,
history_clear_confirmation: Option<ProfileId>,
site_permissions_clear_confirmation: Option<ProfileId>,
plugin_install_error: Option<String>,
pending_plugin_install: Option<PendingPluginInstall>,
@@ -98,6 +100,7 @@ impl ElyShell {
download_action_error: None,
download_clear_confirmation: false,
download_security_confirmation: None,
history_clear_confirmation: None,
site_permissions_clear_confirmation: None,
plugin_install_error: None,
pending_plugin_install: None,