From 2ceb00a95aee3a8c11135e0d786d4ac158d960af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Sat, 9 May 2026 21:59:50 -0400 Subject: [PATCH] Drop the fake reload glyph behavior on split-pane headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The split-pane reload glyph had `cursor_pointer` + an `on_click` that called `select_tab` — clicking the reload button just re-selected the already-active tab. That's a fake handler. Make the glyph visibly disabled (INK_5, no cursor, no click) until a real per-tab reload action lands in BrowserCore. `refresh_tab` exists but is `pub(super)` and only flips the discard state; surfacing it as "reload" would mislead. --- crates/ely_app/src/shell/chrome/split_pane.rs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/crates/ely_app/src/shell/chrome/split_pane.rs b/crates/ely_app/src/shell/chrome/split_pane.rs index c9ebfa4..6b6700d 100644 --- a/crates/ely_app/src/shell/chrome/split_pane.rs +++ b/crates/ely_app/src/shell/chrome/split_pane.rs @@ -67,17 +67,16 @@ pub(crate) fn render_split_pane_header( .into_any_element() } -fn render_reload_glyph(tab_id: TabId, cx: &mut Context) -> AnyElement { - let id = format!("split-pane-reload-{}", tab_id.as_str()); +/// Reload affordance on each split-pane header. Real page reload isn't +/// exposed through `BrowserCore` yet — `refresh_tab` is `pub(super)` +/// and only flips the discard state. Render the glyph in the disabled +/// `INK_5` color and skip cursor + on_click rather than ship a button +/// that pretends to reload by re-selecting the tab. Wire a real +/// reload action when one lands. +fn render_reload_glyph(_tab_id: TabId, _cx: &mut Context) -> AnyElement { div() - .id(SharedString::from(id)) - .text_color(rgb(colors::INK_4)) + .text_color(rgb(colors::INK_5)) .text_size(px(11.0)) - .cursor_pointer() - .hover(|style| style.text_color(rgb(colors::INK))) - .on_click(cx.listener(move |shell, _, window, cx| { - shell.select_tab(&tab_id, window, cx); - })) .child(IconName::Redo2) .into_any_element() }