From 31162da330977c2766c26d579ca63df834a7d26b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?=
 <zhangyanghaha0407@outlook.com>
Date: Fri, 8 May 2026 23:34:30 -0400
Subject: [PATCH] Assert PRD live sites reach ready web surface state

---
 .../src/shell/web_surface_live_site_tests.rs  | 31 +++++++++++++------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/crates/ely_app/src/shell/web_surface_live_site_tests.rs b/crates/ely_app/src/shell/web_surface_live_site_tests.rs
index 8282bdc..d1d4fb3 100644
--- a/crates/ely_app/src/shell/web_surface_live_site_tests.rs
+++ b/crates/ely_app/src/shell/web_surface_live_site_tests.rs
@@ -12,6 +12,7 @@ use crate::{
     shell::{
         web_surface_frame::WebSurfaceFrame,
         web_surface_geometry::{WebSurfaceScrollOffset, WebSurfaceSize},
+        web_surface_state::WebSurfaceState,
     },
 };
 
@@ -45,6 +46,7 @@ fn assert_web_surfaces_render(cases: &[LiveSiteCase]) -> Result<(), Box<dyn Erro
         let request = store
             .prepare_request(&tab, ProfileDataMode::Persistent)
             .ok_or_else(|| format!("missing web surface request for {}", case.url))?;
+        let tab_id = request.tab_id.clone();
         let snapshot = request.client.snapshot(request.snapshot_request)?;
         let frame = WebSurfaceFrame::from_snapshot(
             request.requested_url,
@@ -54,20 +56,29 @@ fn assert_web_surfaces_render(cases: &[LiveSiteCase]) -> Result<(), Box<dyn Erro
             snapshot,
         )?;
 
-        assert_eq!(
-            frame.size(),
-            WebSurfaceSize { width: LIVE_SURFACE_WIDTH, height: LIVE_SURFACE_HEIGHT },
-            "{}",
-            case.url
-        );
-        assert_eq!(frame.scroll_offset(), WebSurfaceScrollOffset::default(), "{}", case.url);
-        assert!(frame.url_label().contains(normalized_url(case.url)), "{}", frame.url_label());
-        assert!(frame.title_label().contains(case.title_fragment), "{}", frame.title_label());
-        assert_eq!(frame.detail_label(), "934x657", "{}", case.url);
+        assert_prd_frame_is_ready(&frame, case);
+        store.finish(tab_id, WebSurfaceState::Ready(frame));
+        let Some(WebSurfaceState::Ready(frame)) = store.state(tab.id()) else {
+            return Err(format!("web surface state is not ready for {}", case.url).into());
+        };
+        assert_prd_frame_is_ready(frame, case);
     }
     Ok(())
 }
 
+fn assert_prd_frame_is_ready(frame: &WebSurfaceFrame, case: &LiveSiteCase) {
+    assert_eq!(
+        frame.size(),
+        WebSurfaceSize { width: LIVE_SURFACE_WIDTH, height: LIVE_SURFACE_HEIGHT },
+        "{}",
+        case.url
+    );
+    assert_eq!(frame.scroll_offset(), WebSurfaceScrollOffset::default(), "{}", case.url);
+    assert!(frame.url_label().contains(normalized_url(case.url)), "{}", frame.url_label());
+    assert!(frame.title_label().contains(case.title_fragment), "{}", frame.title_label());
+    assert_eq!(frame.detail_label(), "934x657", "{}", case.url);
+}
+
 fn live_surface_bounds() -> Bounds<gpui::Pixels> {
     Bounds::new(
         point(px(0.0), px(0.0)),