ZacharyZhang-NY/ELY-Browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(sync): keep sync owner first-claim-wins on Windows

Browse Source
This commit is contained in:
ZacharyZhang-NY
2026-07-10 12:16:15 -04:00
parent fd7f8c3ef0
commit 4e460a51d7
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ely_sync_client/src/sync_owner.rs
+5 -7
View File
@@ -250,17 +250,15 @@ fn publish_owner(directory: &Dir, temporary: &str) -> io::Result<()> {
.map_err(Into::into) .map_err(Into::into)
} }
#[cfg(windows)] /// Windows `rename` replaces an existing target (MOVEFILE_REPLACE_EXISTING
fn publish_owner(directory: &Dir, temporary: &str) -> io::Result<()> { /// semantics), which would let a losing concurrent claim overwrite the
directory.rename(temporary, directory, OWNER_FILE) /// winner. `hard_link` fails with `AlreadyExists` on every platform, so it
} /// preserves first-claim-wins.
#[cfg(not(any( #[cfg(not(any(
target_vendor = "apple", target_vendor = "apple",
target_os = "linux", target_os = "linux",
target_os = "android", target_os = "android",
target_os = "redox", target_os = "redox"
windows
)))] )))]
fn publish_owner(directory: &Dir, temporary: &str) -> io::Result<()> { fn publish_owner(directory: &Dir, temporary: &str) -> io::Result<()> {
directory.hard_link(temporary, directory, OWNER_FILE)?; directory.hard_link(temporary, directory, OWNER_FILE)?;