ZacharyZhang-NY/ELY-Browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Track history source tabs

Browse Source
This commit is contained in:
ZacharyZhang-NY
2026-05-08 04:57:09 -04:00
parent 38672912c7
commit 5215c924ca
3 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ely_browser_core/src/state/history.rs
+2 -1
View File
@@ -44,13 +44,14 @@ impl BrowserCore {
&& entry.space_id() == tab.space_id()
&& entry.url() == tab.url()
}) {
entry.record_visit(tab.title(), visited_at);
entry.record_visit(tab.id().clone(), tab.title(), visited_at);
return;
}
self.history_entries.push(HistoryEntry::new(
tab.profile_id().clone(),
tab.space_id().clone(),
tab.id().clone(),
tab.title(),
tab.url().clone(),
visited_at,
crates/ely_browser_core/tests/history.rs
+4 -2
View File
@@ -12,12 +12,13 @@ fn navigation_records_profile_and_space_history() -> Result<(), Box<dyn Error>>
let active_profile_id = core.active_tab()?.profile_id().clone();
let active_space_id = core.snapshot()?.active_space_id;
core.open_tab(UrlText::parse("https://example.com/research")?);
let source_tab_id = core.open_tab(UrlText::parse("https://example.com/research")?);
let snapshot = core.snapshot()?;
assert_eq!(snapshot.history_entries.len(), 1);
assert_eq!(snapshot.history_entries[0].profile_id(), &active_profile_id);
assert_eq!(snapshot.history_entries[0].space_id(), &active_space_id);
assert_eq!(snapshot.history_entries[0].source_tab_id(), &source_tab_id);
assert_eq!(snapshot.history_entries[0].title(), "example.com");
assert_eq!(snapshot.history_entries[0].url().as_str(), "https://example.com/research");
assert_eq!(snapshot.history_entries[0].visit_count(), 1);
@@ -28,12 +29,13 @@ fn navigation_records_profile_and_space_history() -> Result<(), Box<dyn Error>>
fn repeated_history_visits_increment_count_in_active_context() -> Result<(), Box<dyn Error>> {
let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
core.open_tab(UrlText::parse("https://example.com/research")?);
core.open_tab(UrlText::parse("https://example.com/research")?);
let latest_source_tab_id = core.open_tab(UrlText::parse("https://example.com/research")?);
let snapshot = core.snapshot()?;
assert_eq!(snapshot.history_entries.len(), 1);
assert_eq!(snapshot.history_entries[0].url().as_str(), "https://example.com/research");
assert_eq!(snapshot.history_entries[0].source_tab_id(), &latest_source_tab_id);
assert_eq!(snapshot.history_entries[0].visit_count(), 2);
Ok(())
}