Resolve clippy warnings in this round's changes
Three nits clippy flagged on the round 13 + 14 commits. Fix each: * `RangeInclusive::contains` for the sidebar reveal-threshold guard. * Reword the popover-anchor doc-comments so the `+ tile` lines don't get parsed as Markdown list items. * Collapse the `if let Some(text)` + nested `if` in the external web keyboard handler into a single `let-and-and` chain. No behavior change. cargo clippy -p ely_app: clean. cargo test --workspace: 440 passed, 0 failed.
This commit is contained in:
@@ -231,13 +231,13 @@ pub(crate) fn render_workspace_disclosure_backdrop(
|
||||
}
|
||||
|
||||
/// Anchor of the disclosure popover relative to the window's top-left.
|
||||
/// Walks the sidebar layout: SHELL_INSET (16) + sidebar header pt (8)
|
||||
/// + title row h (20) + header gap (8) + picker row py-top (4) + tile
|
||||
/// height (32) + picker row py-bot (4) + popover lift (6) = 98.
|
||||
/// Walks the sidebar layout — SHELL_INSET 16 plus sidebar header pt 8
|
||||
/// plus title row h 20 plus header gap 8 plus picker row py-top 4 plus
|
||||
/// tile height 32 plus picker row py-bot 4 plus popover lift 6 = 98.
|
||||
const DISCLOSURE_TOP_PX: f32 = 98.0;
|
||||
|
||||
/// Left edge of the disclosure: SHELL_INSET (16) + header px-left (10)
|
||||
/// + picker row px-left (2) + tile width (32) + picker gap (6) = 66.
|
||||
/// Left edge of the disclosure — SHELL_INSET 16 plus header px-left 10
|
||||
/// plus picker row px-left 2 plus tile width 32 plus picker gap 6 = 66.
|
||||
/// That lines the disclosure up with the picker pill, not the tile.
|
||||
const DISCLOSURE_LEFT_PX: f32 = 66.0;
|
||||
|
||||
|
||||
@@ -236,7 +236,7 @@ impl ElyShell {
|
||||
return;
|
||||
}
|
||||
|
||||
if cursor_x >= REVEAL_THRESHOLD_PX && cursor_x <= COLLAPSE_THRESHOLD_PX {
|
||||
if (REVEAL_THRESHOLD_PX..=COLLAPSE_THRESHOLD_PX).contains(&cursor_x) {
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -21,10 +21,10 @@ impl ElyShell {
|
||||
return;
|
||||
}
|
||||
|
||||
if let Some(text) = special_key_text(event) {
|
||||
if self.type_text_in_external_web_viewport(tab_id, requested_url, text, cx) {
|
||||
cx.stop_propagation();
|
||||
}
|
||||
if let Some(text) = special_key_text(event)
|
||||
&& self.type_text_in_external_web_viewport(tab_id, requested_url, text, cx)
|
||||
{
|
||||
cx.stop_propagation();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user