ZacharyZhang-NY/ELY-Browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop propagation on split-pane close so the pane doesn't reselect

Browse Source 
Same fix as `adb278b` but for the split-pane close glyph: clicking ×
fires the pane wrapper's `on_click(select_tab)` after the close runs.
Add `cx.stop_propagation()` so the close ends at the glyph.
This commit is contained in:
ZacharyZhang-NY
2026-05-09 22:28:41 -04:00
parent a6e08f6267
commit 6cf2defca9
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ely_app/src/shell/chrome/split_pane.rs
+4
View File
@@ -90,8 +90,12 @@ fn render_close_glyph(close_tab_id: TabId, cx: &mut Context<ElyShell>) -> AnyEle
.cursor_pointer() .cursor_pointer()
.hover(|style| style.text_color(rgb(colors::INK))) .hover(|style| style.text_color(rgb(colors::INK)))
.on_click(cx.listener(move |shell, _, window, cx| { .on_click(cx.listener(move |shell, _, window, cx| {
// The split pane itself has an on_click that selects the
// tab. Stop propagation here so closing the pane doesn't
// also re-select the just-removed tab.
shell.select_tab(&close_tab_id, window, cx); shell.select_tab(&close_tab_id, window, cx);
shell.close_active_tab(window, cx); shell.close_active_tab(window, cx);
cx.stop_propagation();
})) }))
.child(IconName::Close) .child(IconName::Close)
.into_any_element() .into_any_element()