From a6e08f62672ba47b3fb55192bc95d6fbab2517c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Sat, 9 May 2026 22:27:45 -0400 Subject: [PATCH] Drop unwired shortcut hints from command overlay footer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Footer advertised `⌘↵ open in split` and `⇥ filter`, but neither is plumbed through `on_command_overlay_key_down` — the dispatch only handles up / down / enter. Per the no-fake-handlers rule a hint that doesn't fire is worse than no hint, so trim the footer to just the two shortcuts that actually work. The split/filter hints can come back the moment the dispatch grows to handle them. --- crates/ely_app/src/shell/chrome/command_footer.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/ely_app/src/shell/chrome/command_footer.rs b/crates/ely_app/src/shell/chrome/command_footer.rs index bfa8e1c..8f1afad 100644 --- a/crates/ely_app/src/shell/chrome/command_footer.rs +++ b/crates/ely_app/src/shell/chrome/command_footer.rs @@ -16,10 +16,12 @@ pub(crate) fn render_command_footer() -> AnyElement { .text_size(px(10.5)) .text_color(rgb(colors::INK_3)) .bg(rgba(FOOTER_BG)) + // Only the shortcuts that actually do something today. + // `⌘↵` (split-on-open) and `⇥` (filter) are real product + // features but not yet wired through the command overlay's + // key dispatch — listing them here would be a fake hint. .child(footer_chunk("↑↓", "navigate")) .child(footer_chunk("↵", "open")) - .child(footer_chunk("⌘↵", "open in split")) - .child(footer_chunk("⇥", "filter")) .child( div() .ml_auto()