ZacharyZhang-NY/ELY-Browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(privacy): drop the diagnostics reporting toggle until a reporter exists

Browse Source
This commit is contained in:
ZacharyZhang-NY
2026-07-10 11:38:47 -04:00
parent 07cd598f75
commit b87f9ae2d4
8 changed files with 15 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ely_browser_core/src/state.rs
+4 -8
View File
@@ -2,10 +2,10 @@ use std::{collections::BTreeMap, time::SystemTime};
use ely_domain::{
AppearanceSettings, ArchivePolicy, ArchivedTab, BookmarkEntry, BrowserTab, DiagnosticEvent,
DiagnosticsReportingPolicy, DomainError, DownloadEntry, DownloadPolicy, FavoriteLimit,
HistoryEntry, HistoryRecordingPolicy, NewTabDestination, NoteEntry, Profile, ProfileId,
ProfileKind, ReadingListEntry, SearchEngine, SitePermissionAuditEvent, SitePermissionEntry,
Space, SpaceId, SplitLayout, SyncStatus, TabGroup, TabId, UrlText,
DomainError, DownloadEntry, DownloadPolicy, FavoriteLimit, HistoryEntry,
HistoryRecordingPolicy, NewTabDestination, NoteEntry, Profile, ProfileId, ProfileKind,
ReadingListEntry, SearchEngine, SitePermissionAuditEvent, SitePermissionEntry, Space, SpaceId,
SplitLayout, SyncStatus, TabGroup, TabId, UrlText,
};
use crate::{CoreError, navigation::tab_title};
@@ -136,7 +136,6 @@ pub struct BrowserSnapshot {
pub search_engine: SearchEngine,
pub new_tab_destination: NewTabDestination,
pub history_recording_policy: HistoryRecordingPolicy,
pub diagnostics_reporting_policy: DiagnosticsReportingPolicy,
pub favorite_limit: FavoriteLimit,
pub appearance: AppearanceSettings,
pub command_query: String,
@@ -177,7 +176,6 @@ pub struct BrowserCore {
search_engine: SearchEngine,
new_tab_destination: NewTabDestination,
history_recording_policy: HistoryRecordingPolicy,
diagnostics_reporting_policy: DiagnosticsReportingPolicy,
favorite_limit: FavoriteLimit,
appearance: AppearanceSettings,
sync_object_policies: SyncObjectPolicies,
@@ -229,7 +227,6 @@ impl BrowserCore {
search_engine: SearchEngine::default(),
new_tab_destination,
history_recording_policy: HistoryRecordingPolicy::default(),
diagnostics_reporting_policy: DiagnosticsReportingPolicy::default(),
favorite_limit: FavoriteLimit::default(),
appearance: AppearanceSettings::default(),
sync_object_policies: SyncObjectPolicies::default(),
@@ -381,7 +378,6 @@ impl BrowserCore {
search_engine: self.search_engine,
new_tab_destination: self.new_tab_destination,
history_recording_policy: self.history_recording_policy,
diagnostics_reporting_policy: self.diagnostics_reporting_policy,
favorite_limit: self.favorite_limit,
appearance: self.appearance,
command_query: self.command_query.clone(),
crates/ely_browser_core/src/state/privacy.rs
+1 -11
View File
@@ -1,4 +1,4 @@
use ely_domain::{DiagnosticsReportingPolicy, HistoryRecordingPolicy};
use ely_domain::HistoryRecordingPolicy;
use serde::{Deserialize, Serialize};
use super::BrowserCore;
@@ -82,13 +82,8 @@ impl BrowserCore {
self.history_recording_policy = policy;
}
pub fn set_diagnostics_reporting_policy(&mut self, policy: DiagnosticsReportingPolicy) {
self.diagnostics_reporting_policy = policy;
}
pub fn reset_privacy_settings(&mut self) {
self.set_history_recording_policy(HistoryRecordingPolicy::default());
self.set_diagnostics_reporting_policy(DiagnosticsReportingPolicy::default());
}
#[must_use]
@@ -96,11 +91,6 @@ impl BrowserCore {
self.history_recording_policy
}
#[must_use]
pub fn diagnostics_reporting_policy(&self) -> DiagnosticsReportingPolicy {
self.diagnostics_reporting_policy
}
#[must_use]
pub fn active_profile_local_data_inventory(&self) -> LocalDataInventory {
let profile_id = &self.active_profile_id;