Add bookmarks internal page

crates/ely_browser_core/tests/bookmarks.rs

@@ -0,0 +1,108 @@
+use std::error::Error;
+
+use ely_browser_core::{BrowserCore, InitialBrowserConfig};
+use ely_domain::{CommandIntent, CommandScope, ProfileKind, UrlText};
+
+#[test]
+fn bookmark_active_tab_records_current_context() -> Result<(), Box<dyn Error>> {
+    let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
+    let tab_id = core.open_tab(UrlText::parse("https://example.com/research")?);
+    let active_profile_id = core.active_tab()?.profile_id().clone();
+    let active_space_id = core.active_tab()?.space_id().clone();
+
+    let bookmark_id = core.bookmark_active_tab()?;
+    let snapshot = core.snapshot()?;
+    let [bookmark] = snapshot.bookmarks.as_slice() else {
+        return Err(format!("expected 1 bookmark, got {}", snapshot.bookmarks.len()).into());
+    };
+
+    assert_eq!(snapshot.active_tab_id, tab_id);
+    assert_eq!(bookmark.id(), &bookmark_id);
+    assert_eq!(bookmark.profile_id(), &active_profile_id);
+    assert_eq!(bookmark.space_id(), &active_space_id);
+    assert_eq!(bookmark.collection_name(), "Work");
+    assert_eq!(bookmark.title(), "example.com");
+    assert_eq!(bookmark.url().as_str(), "https://example.com/research");
+    assert!(bookmark.tags().is_empty());
+    assert_eq!(bookmark.note(), None);
+    Ok(())
+}
+
+#[test]
+fn bookmark_active_tab_reuses_existing_bookmark() -> Result<(), Box<dyn Error>> {
+    let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
+    core.open_tab(UrlText::parse("https://example.com/research")?);
+
+    let first_id = core.bookmark_active_tab()?;
+    let second_id = core.bookmark_active_tab()?;
+
+    assert_eq!(first_id, second_id);
+    assert_eq!(core.snapshot()?.bookmarks.len(), 1);
+    Ok(())
+}
+
+#[test]
+fn bookmarks_scoped_search_opens_matching_bookmark() -> Result<(), Box<dyn Error>> {
+    let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
+    core.open_tab(UrlText::parse("https://example.com/research")?);
+    core.bookmark_active_tab()?;
+
+    core.set_command_query("@bookmarks research");
+    let intent = core.submit_command()?;
+    let snapshot = core.snapshot()?;
+    let active_tab = core.active_tab()?;
+
+    assert_eq!(
+        intent,
+        Some(CommandIntent::ScopedSearch {
+            scope: CommandScope::Bookmarks,
+            query: "research".to_string()
+        })
+    );
+    assert_eq!(active_tab.url().as_str(), "https://example.com/research");
+    assert_eq!(snapshot.command_query, "");
+    Ok(())
+}
+
+#[test]
+fn bookmarks_stay_with_active_profile() -> Result<(), Box<dyn Error>> {
+    let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
+    let default_profile_id = core.active_tab()?.profile_id().clone();
+    let personal_profile_id = core.create_profile("Personal", 0xf54e00, ProfileKind::Standard)?;
+
+    core.open_tab(UrlText::parse("https://example.com/personal")?);
+    core.bookmark_active_tab()?;
+    core.select_profile(&default_profile_id)?;
+
+    core.set_command_query("@bookmarks personal");
+    let intent = core.submit_command()?;
+    let snapshot = core.snapshot()?;
+
+    assert_eq!(
+        intent,
+        Some(CommandIntent::ScopedSearch {
+            scope: CommandScope::Bookmarks,
+            query: "personal".to_string()
+        })
+    );
+    assert_eq!(core.active_tab()?.profile_id(), &default_profile_id);
+    assert_ne!(core.active_tab()?.profile_id(), &personal_profile_id);
+    assert!(snapshot.bookmarks.is_empty());
+    assert_eq!(snapshot.command_query, "@bookmarks personal");
+    Ok(())
+}
+
+#[test]
+fn open_bookmarks_command_opens_bookmarks_page() -> Result<(), Box<dyn Error>> {
+    let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
+
+    core.set_command_query(">open-bookmarks");
+    let intent = core.submit_command()?;
+    let active_tab = core.active_tab()?;
+
+    assert_eq!(intent, Some(CommandIntent::Command("open-bookmarks".to_string())));
+    assert_eq!(active_tab.title(), "Bookmarks");
+    assert_eq!(active_tab.url().as_str(), "ely://bookmarks");
+    assert_eq!(core.snapshot()?.command_query, "");
+    Ok(())
+}

crates/ely_browser_core/tests/sync.rs

@@ -8,6 +8,7 @@ fn default_sync_status_reflects_local_browser_state() -> Result<(), Box<dyn Erro
     let mut core = BrowserCore::new(InitialBrowserConfig::ely_defaults()?)?;
     core.create_space("Research", "R", 0xf54e00)?;
     core.open_tab(UrlText::parse("https://example.com/research")?);
+    core.bookmark_active_tab()?;
 
     let snapshot = core.snapshot()?;
     let status = &snapshot.sync_status;
@@ -20,6 +21,7 @@ fn default_sync_status_reflects_local_browser_state() -> Result<(), Box<dyn Erro
         &[
             SyncObjectStatus::new(SyncObjectKind::Spaces, 2, SyncObjectState::LocalOnly),
             SyncObjectStatus::new(SyncObjectKind::Tabs, 3, SyncObjectState::LocalOnly),
+            SyncObjectStatus::new(SyncObjectKind::Bookmarks, 1, SyncObjectState::LocalOnly),
             SyncObjectStatus::new(SyncObjectKind::Profiles, 1, SyncObjectState::LocalOnly),
             SyncObjectStatus::new(SyncObjectKind::History, 1, SyncObjectState::PrivacyControlled),
             SyncObjectStatus::new(SyncObjectKind::PluginSettings, 0, SyncObjectState::LocalOnly),