ZacharyZhang-NY/ELYTerminal
1
8 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

T46: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m45s
Details
CI / macos (push) Canceled after 0s
Details
CI / platforms (windows-latest) (push) Canceled after 1m54s
Details

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-18 05:33:15 -04:00
1 parent 6df7534e7f
commit 1daa2599f7
2 files changed
+6 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tasks/reviews.md
+5
View File
@@ -229,3 +229,8 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict,
- Round 1, ae3de24: FAIL. Inside herdr a plain file:// link the app had opened before went to herdr, whose client opens web links only, so nothing opened. Changed in af66a70: a link the app found of another kind it opened itself.
- Round 2, af66a70: FAIL. herdr keeps its panes' OSC 8 targets from the terminal while it takes the mouse, so an OSC 8 link labelled with a file:// URL and aimed at a web page opened the label's file. Fixed in c30bd51: while herdr takes the mouse every press is herdr's again, its web-only rule with it, as its client and docs say; Shift with the press, herdr's named way past it, lets the terminal open what it sees.
- Round 3, c30bd51: PASS. With real herdr 0.9.5 the label's prefix and its file:// part both opened the web target through herdr; Shift-Cmd-press opened a visible file:///etc/hosts in the app; with herdr's mouse capture off the app opened OSC 8 web and file targets and plain file URLs itself; wrapped, tail, OSC 8 and long web links opened whole through herdr, and links outside herdr in the app; check.sh passed.
## T46
- Round 1, 9aeb3f3: FAIL. A press on Ely made her panel AppKit's key window, so keys typed after it went nowhere; switched back on during an error she opened calm, since her mood waited for the next change; on a 100-point window her fixed 140-point offset left her beside it. Fixed in 6df7534: on macOS her panel becomes key only if needed, and on Windows her window answers a press's activation with none; she opens with the sessions' mood; she stands 140 points in or less, so she holds the pane's edge at any width, and on Wayland she opens again when a new width moves her.
- Round 2, 6df7534: PASS. A native AppKit press on her kept the main window key and the program read abc; switched off and on during an error she came back worried; on a 100-point window she stood at its left edge, and 140 points in once it grew; minimized, both hid, and restored, both showed; check.sh, 8 Linux pet tests under Xvfb and the Windows cross-check passed, and on the Windows VM cargo test passed 200 tests at 6df7534. Native Windows interaction and a real Wayland desktop went unexercised.